Bug 2297994

Fixed any source issues. I now build the srpms in an isolated _sourcedir. Sigh.

Spec URL: https://jsteffan.fedorapeople.org/envision/rust-libpanel-sys.spec
SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-libpanel-sys-0.4.0-1.fc39/rust-libpanel-sys-0.4.0-1.fc40.src.rpm

[fedora-review-service-build]

Considering

# Generated by rust2rpm 26
#---- cross_validate_constants_with_c stdout ----
#Constant value mismatch for PANEL_MINOR_VERSION
#Rust: "3"
#C:    "6"
#Constant value mismatch for PANEL_VERSION_S
#Rust: "1.3.0"
#C:    "1.6.0"
#thread 'cross_validate_constants_with_c' panicked at tests/abi.rs:112:13:
#FAILED: 11 passed; 2 failed

I think that skipping all of the tests is not the right way to handle this.

It seems like these constants (PANEL_MAJOR_VERSION, PANEL_MINOR_VERSION, PANEL_MICRO_VERSION, and PANEL_VERSION_S, https://gitlab.gnome.org/World/Rust/libpanel-rs/-/blob/main/sys/src/lib.rs?ref_type=heads#L42) are designed to expose the version of the C libpanel library. On the other hand, they are also part of a file that is generated from GIR, so maybe it doesn’t make sense to patch these (because they correctly reflect that the Rust bindings were generated against an older libpanel version). If we decide it’s OK for these constants to disagree with the packaged libpanel version, then it would at least be better to skip *only* the tests that fail because of the mismatch, similar to https://bugzilla.redhat.com/show_bug.cgi?id=2292542#c9.

Spec URL: https://jsteffan.fedorapeople.org/envision/rust-libpanel-sys.spec
SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-libpanel-sys-0.4.0-1.fc39/rust-libpanel-sys-0.4.0-1.fc40.src.rpm


Updated with the tests explicitly disabled, but that results in no tests being ran. It still seems more explicit which is better.

    Finished `rpm` profile [optimized + debuginfo] target(s) in 3.47s
     Running `/builddir/build/BUILD/libpanel-sys-0.4.0/target/rpm/deps/libpanel_sys-0598ef43cda76fae --exact --skip cross_validate_constants_with_c --skip cross_validate_layout_with_c`

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running `/builddir/build/BUILD/libpanel-sys-0.4.0/target/rpm/deps/abi-1fdc50621837f906 --exact --skip cross_validate_constants_with_c --skip cross_validate_layout_with_c`

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 2 filtered out; finished in 0.00s

   Doc-tests libpanel_sys
     Running `/usr/bin/rustdoc --edition=2021 --crate-type lib --crate-name libpanel_sys --test src/lib.rs --test-run-directory /builddir/build/BUILD/libpanel-sys-0.4.0 -L dependency=/builddir/build/BUILD/libpanel-sys-0.4.0/target/rpm/deps -L dependency=/builddir/build/BUILD/libpanel-sys-0.4.0/target/rpm/deps --test-args --exact --test-args --skip --test-args cross_validate_constants_with_c --test-args --skip --test-args cross_validate_layout_with_c --extern gio_sys=/builddir/build/BUILD/libpanel-sys-0.4.0/target/rpm/deps/libgio_sys-a8d80ef665ebcad0.rlib --extern glib_sys=/builddir/build/BUILD/libpanel-sys-0.4.0/target/rpm/deps/libglib_sys-1e1bf5a6873c6e88.rlib --extern gobject_sys=/builddir/build/BUILD/libpanel-sys-0.4.0/target/rpm/deps/libgobject_sys-98ead2b98f1ab4d9.rlib --extern gtk_sys=/builddir/build/BUILD/libpanel-sys-0.4.0/target/rpm/deps/libgtk4_sys-52e6d4e077145192.rlib --extern adw_sys=/builddir/build/BUILD/libpanel-sys-0.4.0/target/rpm/deps/liblibadwaita_sys-3fa267b5453be884.rlib --extern libc=/builddir/build/BUILD/libpanel-sys-0.4.0/target/rpm/deps/liblibc-9d68931595a180e7.rlib --extern libpanel_sys=/builddir/build/BUILD/libpanel-sys-0.4.0/target/rpm/deps/liblibpanel_sys-eb7e72418f149cc0.rlib --extern shell_words=/builddir/build/BUILD/libpanel-sys-0.4.0/target/rpm/deps/libshell_words-f1560b2e7fe2ebf7.rlib --extern tempfile=/builddir/build/BUILD/libpanel-sys-0.4.0/target/rpm/deps/libtempfile-1f1a9edaf3aa557b.rlib -C embed-bitcode=no --cfg system_deps_have_libpanel_1 --error-format human`

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

[tests]
comments = [
  "Skipped tests due to differences in GIR",
]
skip-exact = true
skip = [
  "cross_validate_constants_with_c",
  "cross_validate_layout_with_c"
]

[requires]
build = ["pkgconfig(libpanel-1)"]
lib = ["pkgconfig(libpanel-1)"]

I'll review it

Looks good. There is a new version (0.5.0) released recently. Consider building it instead of this 0.4.0 but this is not a blocker. Also I'd love to see %check section passing all the tests (not a blocker).

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license (MIT).
[x]: License file installed when any subpackage combination is installed.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format (%autochangelog).
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[?]: I didn't test if the package functions as described.
[!]: Latest version is packaged. See my comment above.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are not verified with gpgverify first in %prep.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: All tests should passe in %check section. See my comment above.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rust-libpanel-sys-devel-0.4.0-1.fc41.noarch.rpm
          rust-libpanel-sys+default-devel-0.4.0-1.fc41.noarch.rpm
          rust-libpanel-sys+v1_2-devel-0.4.0-1.fc41.noarch.rpm
          rust-libpanel-sys+v1_4-devel-0.4.0-1.fc41.noarch.rpm
          rust-libpanel-sys-0.4.0-1.fc41.src.rpm
=========================================================================================================================================== rpmlint session starts ==========================================================================================================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpmbvpc_eo')]
checks: 32, packages: 5

rust-libpanel-sys+default-devel.noarch: W: no-documentation
rust-libpanel-sys+v1_2-devel.noarch: W: no-documentation
rust-libpanel-sys+v1_4-devel.noarch: W: no-documentation
rust-libpanel-sys-devel.noarch: W: no-documentation
===================================================================================================== 5 packages and 0 specfiles checked; 0 errors, 4 warnings, 22 filtered, 0 badness; has taken 1.3 s =====================================================================================================




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 4

rust-libpanel-sys+v1_2-devel.noarch: W: no-documentation
rust-libpanel-sys-devel.noarch: W: no-documentation
rust-libpanel-sys+v1_4-devel.noarch: W: no-documentation
rust-libpanel-sys+default-devel.noarch: W: no-documentation
 4 packages and 0 specfiles checked; 0 errors, 4 warnings, 18 filtered, 0 badness; has taken 0.9 s 



Source checksums
----------------
https://crates.io/api/v1/crates/libpanel-sys/0.4.0/download#/libpanel-sys-0.4.0.crate :
  CHECKSUM(SHA256) this package     : 556284d9ee0a6c0d79b992d4a3bc332a1f009172cb4212ad3ca2db227a09e29d
  CHECKSUM(SHA256) upstream package : 556284d9ee0a6c0d79b992d4a3bc332a1f009172cb4212ad3ca2db227a09e29d


Requires
--------
rust-libpanel-sys-devel (rpmlib, GLIBC filtered):
    (crate(gio-sys/default) >= 0.19.0 with crate(gio-sys/default) < 0.20.0~)
    (crate(glib-sys/default) >= 0.19.0 with crate(glib-sys/default) < 0.20.0~)
    (crate(gobject-sys/default) >= 0.19.0 with crate(gobject-sys/default) < 0.20.0~)
    (crate(gtk4-sys/default) >= 0.8.0 with crate(gtk4-sys/default) < 0.9.0~)
    (crate(libadwaita-sys/default) >= 0.6.0 with crate(libadwaita-sys/default) < 0.7.0~)
    (crate(libc/default) >= 0.2.0 with crate(libc/default) < 0.3.0~)
    (crate(system-deps/default) >= 6.0.0 with crate(system-deps/default) < 7.0.0~)
    cargo
    pkgconfig(libpanel-1)

rust-libpanel-sys+default-devel (rpmlib, GLIBC filtered):
    cargo
    crate(libpanel-sys)

rust-libpanel-sys+v1_2-devel (rpmlib, GLIBC filtered):
    cargo
    crate(libpanel-sys)

rust-libpanel-sys+v1_4-devel (rpmlib, GLIBC filtered):
    cargo
    crate(libpanel-sys)
    crate(libpanel-sys/v1_2)



Provides
--------
rust-libpanel-sys-devel:
    crate(libpanel-sys)
    rust-libpanel-sys-devel

rust-libpanel-sys+default-devel:
    crate(libpanel-sys/default)
    rust-libpanel-sys+default-devel

rust-libpanel-sys+v1_2-devel:
    crate(libpanel-sys/v1_2)
    rust-libpanel-sys+v1_2-devel

rust-libpanel-sys+v1_4-devel:
    crate(libpanel-sys/v1_4)
    rust-libpanel-sys+v1_4-devel



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2297994
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: SugarActivity, Java, Ocaml, R, Python, PHP, Haskell, fonts, Perl
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH


I don't see any critical issues so this package is 

================
=== APPROVED ===
================

The new version will require many dependencies to be upgraded and is a large stack. We'll need to do that in a coordinated way. The version packaged is compatible with the current rust gtk stack.

The tests being disabled are related to a mismatch with GIR and that will need to be solved by the rust SIG. There have been a few discussion about how best to approach this.

Thanks for the review. I'll import this when SCM requests are able to be processed again.

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libpanel-sys

FEDORA-2024-392c96462a (rust-libpanel-sys-0.4.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-392c96462a

FEDORA-2024-392c96462a (rust-libpanel-sys-0.4.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.