Bug 2298838
| Summary: | Review Request: web-eid - Web eID browser extension helper application | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Germano Massullo <germano.massullo> | ||||
| Component: | Package Review | Assignee: | Tomasz Torcz <tomek> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 40 | CC: | package-review, tomek | ||||
| Target Milestone: | --- | Flags: | tomek:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Linux | ||||||
| URL: | https://github.com/web-eid/web-eid-app | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2024-09-25 02:53:22 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2283640 | ||||||
| Attachments: |
|
||||||
|
Description
Germano Massullo
2024-07-19 11:40:31 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7763904 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2298838-web-eid/fedora-rawhide-x86_64/07763904-web-eid/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/7764643 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2298838-web-eid/fedora-rawhide-x86_64/07764643-web-eid/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. New release, where I added obsoletes/provides for the old webextension-token-signing-1.1.5. The transition has been successfully tested SPEC: https://germano.fedorapeople.org/package_reviews/web-eid/web-eid.spec SRPM: https://germano.fedorapeople.org/package_reviews/web-eid/web-eid-2.5.0-2.src.rpm BUILD: https://copr.fedorainfracloud.org/coprs/germano/web-eid/build/7767377/ # dnf install web-eid Copr repo for web-eid owned by germano 2.2 kB/s | 1.4 kB 00:00 Dipendenze risolte. ============================================================================================================================================================================================= Package Architecture Version Repository Size ============================================================================================================================================================================================= Installing: web-eid x86_64 2.5.0-2 copr:copr.fedorainfracloud.org:germano:web-eid 1.0 M sostituisce webextension-token-signing.x86_64 1.1.5-6.fc40 Riepilogo della transazione ============================================================================================================================================================================================= Installati 1 pacchetto Dimensione totale dello scaricamento: 1.0 M Procedere [s/N]: s Scaricamento dei pacchetti: web-eid-2.5.0-2.x86_64.rpm 1.0 MB/s | 1.0 MB 00:00 --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Totale 1.0 MB/s | 1.0 MB 00:00 Copr repo for web-eid owned by germano 3.0 kB/s | 1.0 kB 00:00 Importazione della chiave GPG 0x36C1B62C in corso: Userid : "germano_web-eid (None) <germano#web-eid.org>" Fingerprint: FAB5 9D96 194D B8DA 68E3 6137 D9BE 4570 36C1 B62C Da : https://download.copr.fedorainfracloud.org/results/germano/web-eid/pubkey.gpg Procedere [s/N]: s Chiave importata correttamente Esecuzione del controllo di transazione Controllo di transazione eseguito con successo. Test di transazione in corso Test di transazione eseguito con successo Transazione in corso Preparazione in corso : 1/1 Installing : web-eid-2.5.0-2.x86_64 1/2 Esecuzione scriptlet in corso: web-eid-2.5.0-2.x86_64 1/2 Obsoleto : webextension-token-signing-1.1.5-6.fc40.x86_64 2/2 Esecuzione scriptlet in corso: web-eid-2.5.0-2.x86_64 2/2 Esecuzione scriptlet in corso: webextension-token-signing-1.1.5-6.fc40.x86_64 2/2 Installati: web-eid-2.5.0-2.x86_64 Fatto! Created attachment 2040068 [details]
The .spec file difference from Copr build 7764643 to 7767706
Copr build: https://copr.fedorainfracloud.org/coprs/build/7767706 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2298838-web-eid/fedora-rawhide-x86_64/07767706-web-eid/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Hello, I added in CC various people previously involved in open-eid bugreports/package maintaining. I need a volunteer to review this review request for web-eid, the webextension-token-signing replacement (see https://bugzilla.redhat.com/show_bug.cgi?id=2283640 ) Thank you Hi, some changes are needed: 1. Source: should be an URL, see https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ 2. LICENSE file should be included as %license, see https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text 3. See below for dependencies. % rpmlint web-eid.spec ============================================================== rpmlint session starts ============================================================== web-eid.spec: W: invalid-url Source0: web-eid-2.5.0.tar.gz % rpmlint web-eid-2.5.0-2.x86_64.rpm ============================================================== rpmlint session starts ============================================================== web-eid.x86_64: W: unstripped-binary-or-object /usr/bin/web-eid web-eid.x86_64: E: unknown-key 36c1b62c # ignorable web-eid.x86_64: W: non-conffile-in-etc /etc/chromium/native-messaging-hosts/eu.webeid.json web-eid.x86_64: W: non-conffile-in-etc /etc/opt/chrome/native-messaging-hosts/eu.webeid.json web-eid.x86_64: W: no-manual-page-for-binary web-eid web-eid.x86_64: W: no-documentation web-eid.x86_64: E: explicit-lib-dependency libstdc++ web-eid.x86_64: E: explicit-lib-dependency openssl-libs web-eid.x86_64: E: explicit-lib-dependency pcsc-lite-libs web-eid.x86_64: E: description-line-too-long The Web eID application performs cryptographic digital signing and authentication (E)rrors have to be corrected. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. - gtk-update-icon-cache must not be invoked in %post and %posttrans for Fedora 26 and later. Note: icons in web-eid See: ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License", "*No copyright* Microsoft Reciprocal License", "*No copyright* Apache License 2.0". 212 files have unknown license. Detailed output of licensecheck in /tmp/2298838-web- eid/licensecheck.txt [-]: Package must own all directories that it creates. Note: Directories without known owners: /etc/chromium, /usr/share/google-chrome, /etc/opt/chrome [-]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /etc/chromium/native- messaging-hosts(gnome-browser-connector, webextension-gsconnect), /etc/opt/chrome/native-messaging-hosts(gnome-browser-connector, webextension-gsconnect), /usr/lib64/mozilla/native-messaging- hosts(gnome-browser-connector, webextension-gsconnect, mozilla- filesystem, textern), /usr/share/google-chrome/extensions(fedora- chromium-config-gnome, fedora-chromium-config-kde) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [!]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [?]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define debug_package %{nil} [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: web-eid-2.5.0-2.x86_64.rpm web-eid-2.5.0-2.src.rpm ============================================================== rpmlint session starts ============================================================== web-eid.x86_64: W: unstripped-binary-or-object /usr/bin/web-eid web-eid.x86_64: W: non-conffile-in-etc /etc/chromium/native-messaging-hosts/eu.webeid.json web-eid.x86_64: W: non-conffile-in-etc /etc/opt/chrome/native-messaging-hosts/eu.webeid.json web-eid.x86_64: W: no-manual-page-for-binary web-eid web-eid.x86_64: W: no-documentation web-eid.spec: W: invalid-url Source0: web-eid-2.5.0.tar.gz web-eid.x86_64: E: explicit-lib-dependency libstdc++ web-eid.x86_64: E: explicit-lib-dependency openssl-libs web-eid.x86_64: E: explicit-lib-dependency pcsc-lite-libs web-eid.src: E: description-line-too-long The Web eID application performs cryptographic digital signing and authentication web-eid.x86_64: E: description-line-too-long The Web eID application performs cryptographic digital signing and authentication ======================== 2 packages and 0 specfiles checked; 5 errors, 6 warnings, 11 filtered, 5 badness; has taken 1.2 s ========================= Rpmlint (installed packages) ============================ rpmlint session starts ============================ checks: 32, packages: 1 web-eid.x86_64: W: unstripped-binary-or-object /usr/bin/web-eid web-eid.x86_64: W: non-conffile-in-etc /etc/chromium/native-messaging-hosts/eu.webeid.json web-eid.x86_64: W: non-conffile-in-etc /etc/opt/chrome/native-messaging-hosts/eu.webeid.json web-eid.x86_64: W: no-manual-page-for-binary web-eid web-eid.x86_64: W: no-documentation web-eid.x86_64: E: explicit-lib-dependency libstdc++ web-eid.x86_64: E: explicit-lib-dependency openssl-libs web-eid.x86_64: E: explicit-lib-dependency pcsc-lite-libs web-eid.x86_64: E: description-line-too-long The Web eID application performs cryptographic digital signing and authentication 1 packages and 0 specfiles checked; 4 errors, 5 warnings, 5 filtered, 4 badness; has taken 0.2 s Requires -------- web-eid (rpmlib, GLIBC filtered): /bin/sh hicolor-icon-theme libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Svg.so.5()(64bit) libQt5Svg.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libpcsclite.so.1()(64bit) libstdc++ libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) mozilla-filesystem openssl-libs pcsc-lite-libs qt5-qtbase qt5-qtsvg rtld(GNU_HASH) Provides -------- web-eid: application() application(web-eid.desktop) web-eid web-eid(x86-64) webextension-token-signing Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2298838 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: fonts, Java, PHP, SugarActivity, Ocaml, Perl, R, Haskell, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Hello thank you for your work! I will be back from holidays the 31th August, and I will take care of this and of about your package I am reviewing. See you soon! Applied requested changes SPEC: https://germano.fedorapeople.org/package_reviews/web-eid/2.5.0-3/web-eid.spec SRPM: https://germano.fedorapeople.org/package_reviews/web-eid/2.5.0-3/web-eid-2.5.0-3.src.rpm Looks good to me. The Pagure repository was created at https://src.fedoraproject.org/rpms/web-eid FEDORA-2024-e5fced58b5 (web-eid-2.5.0-4.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-e5fced58b5 FEDORA-2024-cad852c697 (web-eid-2.5.0-4.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-cad852c697 Can anybody please login and leave a karma feedback? https://bodhi.fedoraproject.org/updates/?packages=web-eid (In reply to Germano Massullo from comment #14) > Can anybody please login and leave a karma feedback? > https://bodhi.fedoraproject.org/updates/?packages=web-eid Wrong bugzilla number, the message was meant to be sent to https://bugzilla.redhat.com/show_bug.cgi?id=2283640 FEDORA-2024-e5fced58b5 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-e5fced58b5 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-e5fced58b5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-cad852c697 (web-eid-2.5.0-4.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-f309b53411 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f309b53411` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f309b53411 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-f309b53411 (web-eid-2.5.0-5.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |