Bug 2299038

Summary:	Review Request: python-flatbencode - Fast, safe and non-recursive implementation of Bittorrent bencoding
Product:	[Fedora] Fedora	Reporter:	Daniel Moerner <dmoerner>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fschwarz, package-review
Target Milestone:	---	Keywords:	AutomationTriaged
Target Release:	---
Hardware:	All
OS:	Linux
URL:	https://github.com/acatton/flatbencode
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-10-18 12:44:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Daniel Moerner 2024-07-20 19:06:30 UTC

Spec URL: https://moerner.com/fedora/python-flatbencode.spec
SRPM URL: https://moerner.com/fedora/python-flatbencode-0.2.1-1.fc41.src.rpm
Description: Fast, safe and thoroughly tested implementation of bencode in pure Python 3, without any C extension. This is called flatbencode because the algorithm for decoding a bencode structure is non-recursive, thus preventing RuntimeException.
Fedora Account System Username: dmoerner

Further comments: This is my first Python package (and my first submission for review for a while); any feedback is welcome. I would like to add this to Fedora because it's a requirement for torf, a Python module for creating, parsing, and editing torrent files, which I intend to package along with the torf-cli and torf-gui applications. (https://github.com/rndusr/torf)

Comment 1 Fedora Review Service 2024-07-21 15:51:30 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7767607
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2299038-python-flatbencode/fedora-rawhide-x86_64/07767607-python-flatbencode/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Felix Schwarz 2024-08-08 18:08:40 UTC

Daniel, the spec file looks good at a first glance. I noticed that the last change in the upstream repo was 8 years ago. Are you sure you need that library? Maybe this library is just "done" for what it is supposed to do but just a quick confirmation would be nice before I start reviewing this in detail.

Comment 3 Daniel Moerner 2024-10-18 12:44:39 UTC

(In reply to Felix Schwarz from comment #2)
> Daniel, the spec file looks good at a first glance. I noticed that the last
> change in the upstream repo was 8 years ago. Are you sure you need that
> library? Maybe this library is just "done" for what it is supposed to do but
> just a quick confirmation would be nice before I start reviewing this in
> detail.

Hi Felix, Thanks for taking a look at this! I spent some time looking into what I was planning to use this for, and I think you're right that it's better to try to find a more modern solution. I'm going to go ahead and withdraw this request and close the bug.