Bug 2299054

Summary:	Fedora-Review on F39 and F40 No Longer Able to Build in Rawhide Mock Config
Product:	[Fedora] Fedora	Reporter:	Jonathan Steffan <jonathansteffan>
Component:	fedora-review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	39	CC:	admiller, jkadlcik, leamas.alec, michel, ngompa13, pingou
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-08-19 08:50:53 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jonathan Steffan 2024-07-21 00:25:37 UTC

Please update fedora-review to 0.10.0-7+ to include the patches from https://pagure.io/FedoraReview/pull-request/513. These are required for being able to review packages in a rawhide mock configuration which is the default.




Reproducible: Always

Steps to Reproduce:
1. dnf install fedora-review
2. fedora-review -n -r some.src.rpm
Actual Results:  
ERROR: Exception down the road...

07-20 18:12 root         DEBUG    Running: mock -r fedora-rawhide-x86_64 --no-cleanup-after --no-clean -qn --enable-network shell -- dnf-3 repoquery -C -l filesystem
07-20 18:12 root         DEBUG    Exception down the road...
Traceback (most recent call last):
  File "/usr/lib/python3.12/site-packages/FedoraReview/review_helper.py", line 236, in run
    self._do_run(outfile)
  File "/usr/lib/python3.12/site-packages/FedoraReview/review_helper.py", line 226, in _do_run
    self._do_report(outfile)
  File "/usr/lib/python3.12/site-packages/FedoraReview/review_helper.py", line 99, in _do_report
    self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile)
  File "/usr/lib/python3.12/site-packages/FedoraReview/review_helper.py", line 117, in _run_checks
    self.checks.run_checks(output=output, writedown=not Settings.no_report)
  File "/usr/lib/python3.12/site-packages/FedoraReview/checks.py", line 389, in run_checks
    run_check(name)
  File "/usr/lib/python3.12/site-packages/FedoraReview/checks.py", line 364, in run_check
    check.run()
  File "/usr/lib/python3.12/site-packages/FedoraReview/check_base.py", line 266, in run
    self.run_on_applicable()
  File "/usr/lib/python3.12/site-packages/FedoraReview/plugins/generic.py", line 477, in run_on_applicable
    filesys_dirs = set(deps.list_paths("filesystem"))
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/FedoraReview/deps.py", line 304, in list_paths
    paths = check_output(cmd, universal_newlines=True)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/subprocess.py", line 466, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['mock', '-r', 'fedora-rawhide-x86_64', '--no-cleanup-after', '--no-clean', '-qn', '--enable-network', 'shell', '--', 'dnf-3 repoquery -C -l filesystem']' returned non-zero exit status 1.



Expected Results:  
Review is completed.

Rebuilding fedora-review-0.10.0-8.fc41.src.rpm for F39/F40 and installing it resolves this issue.

Comment 1 Jakub Kadlčík 2024-08-14 10:40:45 UTC

Hello Jonathan,
thank you for the report.

Can you please try these?

https://bodhi.fedoraproject.org/updates/FEDORA-2024-3d05e7a82e
https://bodhi.fedoraproject.org/updates/FEDORA-2024-297ab4c63e

I forgot to tag this ticket when creating the updates.

Comment 2 Jonathan Steffan 2024-08-14 15:37:54 UTC

Yes, both work for me.

Comment 3 Jakub Kadlčík 2024-08-19 08:50:53 UTC

Thank you very much for testing.
The updates are in the sable repositories now.