Bug 2299111
| Summary: | Review Request: rust-keyframe - A simple library for animation in Rust | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ryan <errornointernet> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/keyframe | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-09-14 11:26:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ryan
2024-07-21 10:22:11 UTC
Generated by rust2rpm, but I added ``` # Remove failing test in doc comment Patch: keyframe-remove-test.diff ``` to prevent `cargo test` from running one test in lib.rs' doc comments, and ``` # Remove examples/ since those aren't going to be used, # and they include an extra `ggez` dependency. rm -rf examples ``` To remove the examples, since they contain a massive `ggez` dependency. Copr build: https://copr.fedorainfracloud.org/coprs/build/7767708 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2299111-rust-keyframe/fedora-rawhide-x86_64/07767708-rust-keyframe/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. The uploaded spec file doesn't match the one inside the SRPM - can you make sure they're both for the same revision? Oops, updated now. Spec URL: https://errornointernet.fedorapeople.org/review-requests/rust-keyframe/rust-keyframe.spec SRPM URL: https://errornointernet.fedorapeople.org/review-requests/rust-keyframe/rust-keyframe-1.1.1-1.fc40.src.rpm Hum, the failing test that you ignored seems to just be failing to compile because the crate is missing a dev-dependency on keyframe_derive. But disabling the test is an acceptable workaround too. Package looks good to me! === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass (one test disabled) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) Thank you for the review! The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-keyframe FEDORA-2024-d6736d84b9 (rust-keyframe-1.1.1-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-d6736d84b9 FEDORA-2024-d6736d84b9 (rust-keyframe-1.1.1-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |