Bug 2299450

Perhaps docs/env.md should also be packaged?

Spec URL: https://solopasha.fedorapeople.org/reviews/aquamarine/aquamarine.spec
SRPM URL: https://solopasha.fedorapeople.org/reviews/aquamarine/aquamarine-0.1.1-1.fc40.src.rpm

added docs/env.md to %doc

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=120960339

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7783932
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2299450-aquamarine/fedora-rawhide-x86_64/07783932-aquamarine/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/aquamarine
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package approved.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
=======
- Package does not use a name that already exists.
  Note: The existing package has been retired & orphaned more than a decade ago.

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 1164 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: aquamarine-0.1.1-1.fc41.x86_64.rpm
          aquamarine-devel-0.1.1-1.fc41.x86_64.rpm
          aquamarine-debuginfo-0.1.1-1.fc41.x86_64.rpm
          aquamarine-debugsource-0.1.1-1.fc41.x86_64.rpm
          aquamarine-0.1.1-1.fc41.src.rpm
=========================================================================================================================== rpmlint session starts ==========================================================================================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp8l5h8g5v')]
checks: 32, packages: 5

aquamarine-devel.x86_64: W: no-documentation
===================================================================================== 5 packages and 0 specfiles checked; 0 errors, 1 warnings, 39 filtered, 0 badness; has taken 0.8 s =====================================================================================




Rpmlint (debuginfo)
-------------------
Checking: aquamarine-debuginfo-0.1.1-1.fc41.x86_64.rpm
=========================================================================================================================== rpmlint session starts ==========================================================================================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp9f7h8dg1')]
checks: 32, packages: 1

====================================================================================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.7 s =====================================================================================





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 4

aquamarine-devel.x86_64: W: no-documentation
 4 packages and 0 specfiles checked; 0 errors, 1 warnings, 31 filtered, 0 badness; has taken 1.8 s 



Source checksums
----------------
https://github.com/hyprwm/aquamarine/archive/v0.1.1/aquamarine-0.1.1.tar.gz :
  CHECKSUM(SHA256) this package     : b07983c748208a64b85816c9988cb2550343a933964ae9f785942c05a3e92fb4
  CHECKSUM(SHA256) upstream package : b07983c748208a64b85816c9988cb2550343a933964ae9f785942c05a3e92fb4


Requires
--------
aquamarine (rpmlib, GLIBC filtered):
    libEGL.so.1()(64bit)
    libGLESv2.so.2()(64bit)
    libc.so.6()(64bit)
    libdisplay-info.so.2()(64bit)
    libdrm.so.2()(64bit)
    libgbm.so.1()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libhyprutils.so.1()(64bit)
    libinput.so.10()(64bit)
    libinput.so.10(LIBINPUT_0.12.0)(64bit)
    libinput.so.10(LIBINPUT_0.20.0)(64bit)
    libinput.so.10(LIBINPUT_0.21.0)(64bit)
    libinput.so.10(LIBINPUT_1.19)(64bit)
    libinput.so.10(LIBINPUT_1.2)(64bit)
    libinput.so.10(LIBINPUT_1.26)(64bit)
    libinput.so.10(LIBINPUT_1.3)(64bit)
    libinput.so.10(LIBINPUT_1.4)(64bit)
    libinput.so.10(LIBINPUT_1.7)(64bit)
    libm.so.6()(64bit)
    libseat.so.1()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.5)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libudev.so.1()(64bit)
    libudev.so.1(LIBUDEV_183)(64bit)
    libwayland-client.so.0()(64bit)
    rtld(GNU_HASH)

aquamarine-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    aquamarine(x86-64)
    libaquamarine.so.0()(64bit)

aquamarine-debuginfo (rpmlib, GLIBC filtered):

aquamarine-debugsource (rpmlib, GLIBC filtered):



Provides
--------
aquamarine:
    aquamarine
    aquamarine(x86-64)
    libaquamarine.so.0()(64bit)

aquamarine-devel:
    aquamarine-devel
    aquamarine-devel(x86-64)
    pkgconfig(aquamarine)

aquamarine-debuginfo:
    aquamarine-debuginfo
    aquamarine-debuginfo(x86-64)
    debuginfo(build-id)
    libaquamarine.so.0.1.1-0.1.1-1.fc41.x86_64.debug()(64bit)

aquamarine-debugsource:
    aquamarine-debugsource
    aquamarine-debugsource(x86-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2299450
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Haskell, SugarActivity, fonts, Java, R, Ocaml, Python, PHP, Perl
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Thank you for the review!

FEDORA-2024-b4ff386c17 (aquamarine-0.1.1-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-b4ff386c17

FEDORA-2024-b4ff386c17 (aquamarine-0.1.1-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.