Bug 2299614

Summary: Review Request: golang-github-selectel-selvpcclient3 - A Go library for the Selectel VPC API
Product: [Fedora] Fedora Reporter: Mikel Olasagasti Uranga <mikel>
Component: Package ReviewAssignee: Alejandro Sáez Morollón <asm>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: asm, package-review
Target Milestone: ---Flags: asm: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-07-29 15:00:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2009869    

Description Mikel Olasagasti Uranga 2024-07-23 22:17:24 UTC
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-selectel-selvpcclient3.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-selectel-selvpcclient3-3.1.1-1.fc40.src.rpm
Description: A Go library for the Selectel VPC API.
Fedora Account System Username: mikelo2

Comment 1 Fedora Review Service 2024-07-23 22:45:37 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7778484
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2299614-golang-github-selectel-selvpcclient3/fedora-rawhide-x86_64/07778484-golang-github-selectel-selvpcclient3/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Alejandro Sáez Morollón 2024-07-26 11:31:52 UTC
[fedora-review-service-build]

Comment 5 Alejandro Sáez Morollón 2024-07-29 11:20:52 UTC
The review service seems to be down. The package builds, and it looks fine to me: https://copr.fedorainfracloud.org/coprs/mikelo2/lego/build/7795643/

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

Comment 6 Fedora Admin user for bugzilla script actions 2024-07-29 13:15:08 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-selectel-selvpcclient3

Comment 7 Fedora Update System 2024-07-29 13:27:26 UTC
FEDORA-2024-e686b7aca2 (golang-github-selectel-selvpcclient3-3.1.1-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-e686b7aca2

Comment 8 Fedora Update System 2024-07-29 15:00:32 UTC
FEDORA-2024-e686b7aca2 (golang-github-selectel-selvpcclient3-3.1.1-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.