Bug 2299655

Spec file LGTM
I tried a local build and it builds correctly.

I can't do an official review yet since this Package is dependent on virtio-vsock which is still in the process of being packaged, `Problem: nothing provides requested (crate(virtio-vsock/default) >= 0.6.0 with crate(virtio-vsock/default) < 0.7.0~)
`

I just noticed that it's missing a man page. it might be worth considering adding a patch on the man page and opening an issues about it upstream.

(In reply to Dorinda from comment #2)
> I just noticed that it's missing a man page. it might be worth considering
> adding a patch on the man page and opening an issues about it upstream.

Opened a PR there: https://github.com/rust-vmm/vhost-device/pull/698
I will add the same patch in the rpm once approved upstream.

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7783889
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2299655-rust-vhost-device-vsock/fedora-rawhide-x86_64/07783889-rust-vhost-device-vsock/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

PR got accepted, pushing an update

Spec URL: https://download.copr.fedorainfracloud.org/results/sbonazzo/rust-vhost-device-vsock/fedora-rawhide-x86_64/07784098-rust-vhost-device-vsock/rust-vhost-device-vsock.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/sbonazzo/rust-vhost-device-vsock/fedora-rawhide-x86_64/07784098-rust-vhost-device-vsock/rust-vhost-device-vsock-0.2.0-1.fc41.src.rpm

COPR build: https://copr.fedorainfracloud.org/coprs/sbonazzo/rust-vhost-device-vsock/build/7784098/
Review template: https://download.copr.fedorainfracloud.org/results/sbonazzo/rust-vhost-device-vsock/fedora-rawhide-x86_64/07784098-rust-vhost-device-vsock/fedora-review/review.txt
fedora-review directory: https://download.copr.fedorainfracloud.org/results/sbonazzo/rust-vhost-device-vsock/fedora-rawhide-x86_64/07784098-rust-vhost-device-vsock/fedora-review/

Automated COPR rebuild will fail until rust-virtio-vsock will get into Rawhide (bug #2299173)

Note for reviewers about:

[ ]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/doc, /usr/share/man,
     /usr/src/debug, /usr, /usr/src, /usr/share, /usr/lib, /usr/bin,
     /usr/share/licenses
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/doc,
     /usr/share/man, /usr/lib, /usr/src/debug, /usr, /usr/src, /usr/share,
     /usr/bin, /usr/share/licenses

In this case it's a false positive as `repoquery --requires vhost-device-vsock-0.2.0-1.fc41.x86_64.rpm --tree`
shows:

```
vhost-device-vsock-0:0.2.0-1.fc41.x86_64
 \_ glibc-0:2.39.9000-35.fc41.x86_64 [5: basesystem, libgcc(x86-64), glibc-common = 2.39.9000-35.fc41, glibc-langpack = 2.39.9000-35.fc41, (glibc-gconv-extra(x86-64) = 2.39.9000-35.fc41 if redhat-rpm-config)]
 |   \_ basesystem-0:11-21.fc41.noarch [2: filesystem, setup]
 |   |   \_ filesystem-0:3.18-23.fc41.x86_64 [1: setup]
...
```

and filesystem package owns above listed directories. I think there's a bug in how debug packages are generated as vhost-device-vsock-debuginfo and rust-vhost-device-vsock-debugsource have no requirements at all and I think they should at least require filesystem package. I'll file bug report for both the issues.

The false positive is already known: https://pagure.io/FedoraReview/issue/515
The missing dep on filesystem for debuginfo and debugsource reported on bug #2299813

Pushed a fix for the false positive stuff here: https://pagure.io/FedoraReview/pull-request/521
Running it with the fix detected an issue with the man1 directory ownership, fixing.

Spec URL: https://download.copr.fedorainfracloud.org/results/sbonazzo/rust-vhost-device-vsock/fedora-rawhide-x86_64/07789476-rust-vhost-device-vsock/rust-vhost-device-vsock.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/sbonazzo/rust-vhost-device-vsock/fedora-rawhide-x86_64/07789476-rust-vhost-device-vsock/rust-vhost-device-vsock-0.2.0-1.fc41.src.rpm

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ licenses of statically linked dependencies are correctly taken into account
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-vhost-device-vsock

FEDORA-2024-1fd1123596 (rust-vhost-device-vsock-0.2.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-1fd1123596

FEDORA-2024-1fd1123596 (rust-vhost-device-vsock-0.2.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.