Bug 2299691

Summary: Review Request: golang-github-azure-sdk-resourcemanager-dns-armdns - Azure SDK for Go - resourcemanager/dns/armdns library
Product: [Fedora] Fedora Reporter: Mikel Olasagasti Uranga <mikel>
Component: Package ReviewAssignee: Alejandro Sáez Morollón <asm>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: asm, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: asm: fedora-review+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-07-26 14:21:40 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2009869    

Description Mikel Olasagasti Uranga 2024-07-24 15:01:20 UTC
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-azure-sdk-resourcemanager-dns-armdns.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-azure-sdk-resourcemanager-dns-armdns-1.1.0-1.fc40~bootstrap.src.rpm
Description: Azure SDK for Go - resourcemanager/dns/armdns library.
Fedora Account System Username: mikelo2

Comment 1 Fedora Review Service 2024-07-25 04:45:45 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7783997
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2299691-golang-github-azure-sdk-resourcemanager-dns-armdns/fedora-rawhide-x86_64/07783997-golang-github-azure-sdk-resourcemanager-dns-armdns/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Alejandro Sáez Morollón 2024-07-26 11:27:51 UTC
This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

Comment 3 Fedora Admin user for bugzilla script actions 2024-07-26 13:26:30 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-azure-sdk-resourcemanager-dns-armdns

Comment 4 Fedora Update System 2024-07-26 13:37:11 UTC
FEDORA-2024-7a6584b647 (golang-github-azure-sdk-resourcemanager-dns-armdns-1.1.0-1.fc41~bootstrap) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-7a6584b647

Comment 5 Fedora Update System 2024-07-26 14:21:40 UTC
FEDORA-2024-7a6584b647 (golang-github-azure-sdk-resourcemanager-dns-armdns-1.1.0-1.fc41~bootstrap) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.