Bug 2299704

Summary: [regression] error: implicit declaration of function ‘BLI_endian_switch_uint32’
Product: [Fedora] Fedora Reporter: Luya Tshimbalanga <luya_tfz>
Component: blenderAssignee: Luya Tshimbalanga <luya_tfz>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 40CC: code, dan, design-devel, epel-packagers-sig, kwizart, luya_tfz, negativo17
Target Milestone: ---Keywords: Regression, TestBlocker
Target Release: ---   
Hardware: s390x   
OS: Linux   
URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=120955251
Whiteboard:
Fixed In Version: blender-4.2.1-3.fc40 blender-3.3.21-1.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-09-04 02:22:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 467765, 485231    

Description Luya Tshimbalanga 2024-07-24 15:38:56 UTC 
On Blender 4.2.0, the build failed due to implicit declaration of function ‘BLI_endian_switch_uint32’ from 'blender-4.2.0/source/blender/blenlib/intern/filereader_zstd.c'. It seems like a regression compared to the previous version 4.1.x.

Reproducible: Always

Steps to Reproduce:
1.Build Blender 4.2.0 on s390x architecture
2.
3.
Actual Results:  
FAILED: source/blender/blenlib/CMakeFiles/bf_blenlib.dir/intern/filereader_zstd.c.o 
/usr/bin/ccache /usr/lib64/ccache/gcc -DHAVE_EXECINFO_H -DNDEBUG -DWITH_ASSERT_ABORT -DWITH_FFTW3 -DWITH_FFTW3_THREADS_F_SUPPORT -DWITH_GHOST_WAYLAND_LIBDECOR -DWITH_GMP -DWITH_TBB -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -D__BIG_ENDIAN__ -I/builddir/build/BUILD/blender-4.2.0-build/blender-4.2.0/source/blender/blenlib -I/builddir/build/BUILD/blender-4.2.0-build/blender-4.2.0/intern/eigen -I/builddir/build/BUILD/blender-4.2.0-build/blender-4.2.0/source/blender/makesdna -I/builddir/build/BUILD/blender-4.2.0-build/blender-4.2.0/redhat-linux-build/source/blender/makesdna/intern -I/builddir/build/BUILD/blender-4.2.0-build/blender-4.2.0/extern/fmtlib/include -I/builddir/build/BUILD/blender-4.2.0-build/blender-4.2.0/extern/xxhash -I/builddir/build/BUILD/blender-4.2.0-build/blender-4.2.0/intern/guardedalloc -I/builddir/build/BUILD/blender-4.2.0-build/blender-4.2.0/intern/atomic/. -isystem /builddir/build/BUILD/blender-4.2.0-build/blender-4.2.0/extern/wcwidth -isystem /builddir/build/BUILD/blender-4.2.0-build/blender-4.2.0/extern/json/include -isystem /usr/include/eigen3 -Wall -Werror=implicit-function-declaration -Wstrict-prototypes -Werror=return-type -Werror=vla -Wmissing-prototypes -Wno-char-subscripts -Wno-unknown-pragmas -Wpointer-arith -Wunused-parameter -Wwrite-strings -Wlogical-op -Wundef -Winit-self -Wmissing-include-dirs -Wno-div-by-zero -Wtype-limits -Wformat-signedness -Wrestrict -Wno-stringop-overread -Wno-stringop-overflow -Wnonnull -Wabsolute-value -Wuninitialized -Wredundant-decls -Wshadow -Wimplicit-fallthrough=5 -Wno-error=unused-but-set-variable -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Wno-complain-wrong-lang -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=z13 -mtune=z14 -fasynchronous-unwind-tables -fstack-clash-protection -Wl,--as-needed -fopenmp -std=gnu11 -pipe -fPIC -funsigned-char -fno-strict-aliasing -ffp-contract=off -fmacro-prefix-map="/builddir/build/BUILD/blender-4.2.0-build/blender-4.2.0/"="" -fmacro-prefix-map="/builddir/build/BUILD/blender-4.2.0-build/blender-4.2.0/redhat-linux-build/"="" -Wno-maybe-uninitialized -DNDEBUG -MD -MT source/blender/blenlib/CMakeFiles/bf_blenlib.dir/intern/filereader_zstd.c.o -MF source/blender/blenlib/CMakeFiles/bf_blenlib.dir/intern/filereader_zstd.c.o.d -o source/blender/blenlib/CMakeFiles/bf_blenlib.dir/intern/filereader_zstd.c.o -c /builddir/build/BUILD/blender-4.2.0-build/blender-4.2.0/source/blender/blenlib/intern/filereader_zstd.c
/builddir/build/BUILD/blender-4.2.0-build/blender-4.2.0/source/blender/blenlib/intern/filereader_zstd.c: In function ‘zstd_read_u32’:
/builddir/build/BUILD/blender-4.2.0-build/blender-4.2.0/source/blender/blenlib/intern/filereader_zstd.c:42:3: error: implicit declaration of function ‘BLI_endian_switch_uint32’ [-Wimplicit-function-declaration]
   42 |   BLI_endian_switch_uint32(val);

Expected Results:  
Build should be successful.
Comment 1 Dan Horák 2024-07-24 15:53:15 UTC 
I am pretty sure this upstream change is the culprit - https://github.com/blender/blender/commit/de18b629f0a62323c305b48ef9c100ec43cbb59e#diff-d6c2eed3ebc690d334f3c4710f2c6b5cbfb2c52265a61afe8f5ce63d05ec0c27
Comment 2 Luya Tshimbalanga 2024-07-25 02:35:54 UTC 
Bug filed upstream. https://projects.blender.org/blender/blender/issues/125395
Comment 3 Luya Tshimbalanga 2024-07-26 23:45:42 UTC 
Upstream restored support for s390x. Once the update is set, we can close the issue as solved.
Comment 4 Fedora Update System 2024-08-26 03:15:35 UTC 
FEDORA-EPEL-2024-de8ded0e40 (blender-3.3.21-1.el9) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-de8ded0e40
Comment 5 Fedora Update System 2024-08-26 03:15:36 UTC 
FEDORA-2024-0d769e844b (blender-4.2.1-3.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0d769e844b
Comment 6 Fedora Update System 2024-08-27 03:49:01 UTC 
FEDORA-EPEL-2024-de8ded0e40 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-de8ded0e40

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 7 Fedora Update System 2024-08-27 16:46:35 UTC 
FEDORA-2024-0d769e844b has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0d769e844b`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0d769e844b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 8 Fedora Update System 2024-09-04 02:22:52 UTC 
FEDORA-2024-0d769e844b (blender-4.2.1-3.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 9 Fedora Update System 2024-09-04 04:03:17 UTC 
FEDORA-EPEL-2024-de8ded0e40 (blender-3.3.21-1.el9) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.