Bug 2300030

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=121080208

hmm... the fedora-create-review did not upload the files... looking into it.

Created attachment 2040522 [details]
SRPM, since fedorapeople.org broken

Accessing personal space at fedorapeople.org looks to be broken, uploading files as attachments...

Bug https://pagure.io/fedora-infrastructure/issue/12084

Created attachment 2040523 [details]
SPEC file

Review:

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Apache License 2.0 and/or GNU General
     Public License, Version 2", "FSF All Permissive License", "*No
     copyright* Apache License 2.0", "Apache License 2.0", "FSF Unlimited
     License (with License Retention) and/or GNU General Public License
     v2.0 or later [generated file]", "GNU General Public License v2.0 or
     later [generated file]", "GNU General Public License v3.0 or later",
     "FSF Unlimited License (with License Retention)", "FSF Unlimited
     License [generated file]", "X11 License [generated file]", "GNU
     General Public License v2.0 or later", "FSF Unlimited License (with
     License Retention) and/or GNU General Public License and/or GNU Lesser
     General Public License", "FSF Unlimited License (with License
     Retention) and/or GNU General Public License, Version 2". 12 files
     have unknown license. Detailed output of licensecheck in /root/pappl-
     retrofit/review-pappl-retrofit/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/man, /usr/lib/systemd, /usr/sbin,
     /usr/share/man/man1, /usr/include, /usr, /usr/share/doc, /usr/lib64,
     /usr/share/licenses, /usr/lib, /usr/share, /usr/lib64/pkgconfig,
     /usr/lib/systemd/system
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr, /usr/lib, /usr/share,
     /usr/share/doc, /usr/lib64/pkgconfig, /usr/lib/systemd, /usr/sbin,
     /usr/share/man, /usr/lib64, /usr/share/man/man1,
     /usr/lib/systemd/system, /usr/share/licenses, /usr/include
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 34313 bytes in 4 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: systemd_post is invoked in %post, systemd_preun in %preun, and
     systemd_postun in %postun for Systemd service files.
     Note: Systemd service file(s) in legacy-printer-app
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: Scriptlets must be sane, if used.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Package should not use obsolete m4 macros
     Note: Some obsoleted macros found, see the attachment.
     See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: pappl-retrofit-1.0b2-2.fc41.x86_64.rpm
          pappl-retrofit-devel-1.0b2-2.fc41.x86_64.rpm
          legacy-printer-app-1.0b2-2.fc41.x86_64.rpm
          pappl-retrofit-1.0b2-2.fc41.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmptuzpawt5')]
checks: 32, packages: 4

legacy-printer-app.x86_64: W: dangling-symlink /usr/lib64/legacy-printer-app /usr/lib/cups
 4 packages and 0 specfiles checked; 0 errors, 1 warnings, 30 filtered, 0 badness; has taken 0.4 s

Rpmlint (debuginfo)
-------------------
Checking: pappl-retrofit-debuginfo-1.0b2-2.fc41.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmprlzf1f15')]
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 10 filtered, 0 badness; has taken 0.1 s

Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "pappl-retrofit-devel".
(none): E: there is no installed rpm "pappl-retrofit-debuginfo".
(none): E: there is no installed rpm "legacy-printer-app".
(none): E: there is no installed rpm "pappl-retrofit".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 4

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s



Source checksums
----------------
https://github.com/OpenPrinting/pappl-retrofit//releases/download/1.0b2/pappl-retrofit-1.0b2.tar.gz :
  CHECKSUM(SHA256) this package     : 752e2c54c730d33e1fe10069bb20cb11c324594c051a2beeb2822b63534a588c
  CHECKSUM(SHA256) upstream package : 752e2c54c730d33e1fe10069bb20cb11c324594c051a2beeb2822b63534a588c

Requires
--------
pappl-retrofit (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libcups.so.2()(64bit)
    libcupsfilters.so.2()(64bit)
    libpappl.so.1()(64bit)
    libppd.so.2()(64bit)
    rtld(GNU_HASH)

pappl-retrofit-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libpappl-retrofit.so.1()(64bit)
    pappl-retrofit(x86-64)

legacy-printer-app (rpmlib, GLIBC filtered):
    /bin/sh
    libc.so.6()(64bit)
    libcups.so.2()(64bit)
    libcupsfilters.so.2()(64bit)
    libpappl-retrofit.so.1()(64bit)
    libppd.so.2()(64bit)
    pappl-retrofit(x86-64)
    rtld(GNU_HASH)
    systemd



Provides
--------
pappl-retrofit:
    libpappl-retrofit.so.1()(64bit)
    pappl-retrofit
    pappl-retrofit(x86-64)

pappl-retrofit-devel:
    pappl-retrofit-devel
    pappl-retrofit-devel(x86-64)
    pkgconfig(libpappl-retrofit)

legacy-printer-app:
    /usr/bin/legacy-printer-app
    legacy-printer-app
    legacy-printer-app(x86-64)

AutoTools: Obsoleted m4s found
------------------------------
  AC_PROG_LIBTOOL found in: pappl-retrofit-1.0b2-build/pappl-
  retrofit-1.0b2/configure.ac:60

Notes about the above review:

The dangling symlink should be solved by the Recommends: cups line in the spec.

Also the comment about the AC_PROG_LIBTOOL is weird, pappl-retrofit uses LC_INIT instead and that should be the correct macro that deprecates AC_PROG_LIBTOOL.

Otherwise I did not find anything that needs correcting in the new package.

Created attachment 2040675 [details]
SRPM, since fedorapeople.org broken

Created attachment 2040676 [details]
SPEC file

The Pagure repository was created at https://src.fedoraproject.org/rpms/pappl-retrofit

Package is now in repositories, closing review.