Bug 2300421

Summary: Review Request: ghc-crypton-x509-store - X.509 collection accessing and storing methods
Product: [Fedora] Fedora Reporter: Jens Petersen <petersen>
Component: Package ReviewAssignee: Zbigniew Jędrzejewski-Szmek <zbyszek>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: package-review, zbyszek
Target Milestone: ---Flags: zbyszek: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://hackage.haskell.org/package/crypton-x509-store
Whiteboard:
Fixed In Version: ghc-crypton-x509-store-1.6.9-2.fc41 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-08-13 16:34:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2300420    
Bug Blocks: 2300441, 2300470    

Description Jens Petersen 2024-07-29 15:39:37 UTC
Spec URL: https://petersen.fedorapeople.org/reviews/ghc-crypton-x509-store/ghc-crypton-x509-store.spec
SRPM URL: https://petersen.fedorapeople.org/reviews/ghc-crypton-x509-store/ghc-crypton-x509-store-1.6.9-1.fc41.src.rpm

Description:
X.509 collection accessing and storing methods for certificate, crl, exception
list.

Comment 1 Jens Petersen 2024-07-29 15:42:24 UTC
This is a package rename (new upstream) of the ghc-x509-store package.

Comment 3 Fedora Review Service 2024-07-31 18:13:16 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7809909
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2300421-ghc-crypton-x509-store/fedora-rawhide-x86_64/07809909-ghc-crypton-x509-store/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Zbigniew Jędrzejewski-Szmek 2024-08-04 10:00:19 UTC
+ package follows Haskell packaging guidelines and the standard template
+ package name is OK (Lib)
+ license is acceptable for Fedora (BSD*)
+ license is specified correctly in SPDX format
+ package should build and install correctly when the deps are available

Package is APPROVED.

Comment 5 Jens Petersen 2024-08-05 08:44:33 UTC
Thank you for the review, Zbigniew

Comment 6 Fedora Admin user for bugzilla script actions 2024-08-05 08:44:35 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-crypton-x509-store