Bug 230140
Summary: | Review Request: SILLY - Simple and easy to use library for image loading | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ian Chapman <packages> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | mtasaka:
fedora-review+
wtogami: fedora-cvs+ |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-03-14 01:47:26 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Ian Chapman
2007-02-26 20:35:18 UTC
Well, almost okay. For 0.1.0-1: * Timestamps - This package tries to install * some text files such as header files (in -devel) and keeping timestamps on these files are recommended. Perhaps ------------------------------------------------ make install DESTDIR=%{buildroot} INSTALL="%{__install} -p" ------------------------------------------------ will work * Provides - By the way, why do you want the following? ------------------------------------------------ Provides: silly = %{version}-%{release} ------------------------------------------------ * Source - Please check: http://fedoraproject.org/wiki/Packaging/SourceURL * Warning - Unless they are _very_ noisy, please don't suppress warnings. * sed usage - Perhaps ------------------------------------------------- %{__sed} -i 's|\(GENERATE_MAN[ \t][ \t]*= \)NO|\1YES|' Doxyfile ------------------------------------------------- would be better. You don't have to count the number of spaces. * Encodings - Please change the encoding of the following to UTF-8. ------------------------------------------------- ./AUTHORS ISO-8859-1 ------------------------------------------------- (In reply to comment #1) > * Timestamps Fixed. > * Provides > - By the way, why do you want the following? > ------------------------------------------------ > Provides: silly = %{version}-%{release} > ------------------------------------------------ A while back there was some discussion over using upper case characters and it was suggested that a policy should be made where packages that use uppercase characters should have lowercase provides "alias". I think this isn't ever going to happen now, so I've removed that from the SPEC. > * Source Fixed. > * Warning > - Unless they are _very_ noisy, please don't suppress warnings. I'd rather leave these surpressed for generating the documentation, to me it's a lot of largely useless noise. > * sed usage Thanks for the improved sed replacements, I've changed it. > * Encodings Fixed. Spec URL: http://dribble.org.uk/reviews/SILLY.spec SRPM URL: http://dribble.org.uk/reviews/SILLY-0.1.0-2.src.rpm Okay. -------------------------------------------- This package (SILLY) is APPROVED by me. -------------------------------------------- Thanks you very much for the review. New Package CVS Request ======================= Package Name: SILLY Short Description: Simple and easy to use library for image loading Owners: packages Branches: FC-5 FC-6 InitialCC: Successfully built, closing. |