Bug 230161
| Summary: | Review Request: rt61pci-firmware - Firmware for Ralink® RT2561/RT2661 A/B/G network adaptors | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicolas Chauvet (kwizart) <kwizart> | ||||
| Component: | Package Review | Assignee: | Bill Nottingham <notting> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | gnomeuser, ivdoorn, linville, notting, opensource, rvokal | ||||
| Target Milestone: | --- | Flags: | notting:
fedora-review+
kevin: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-09-20 00:10:08 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Nicolas Chauvet (kwizart)
2007-02-26 22:33:13 UTC
Hardcoded library path shouldn't be use
use "%{_lib}/firmware" instead of "/lib/firmware"
for this lib macros, check if you have an build error OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License is Distributable OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum OK - BuildRequires isn't required OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. + - rpmlint output: SRPM: E: hardcoded-library-path -> can be ignored RPM : E: hardcoded-library-path -> can be ignored OK - build in mock (FC-6 and FC-devel). OK - Should function as described. OK - Should have dist tag OK - Should package latest version Typo : - OK - License file included in package + + - licences and Doc are requesting Source download link is invalid, at least for today. Updated link (changes from .com to .com.tw ) Fixed licence field Spec URL: http://kwizart.free.fr/fedora/6/testing/rt2x00-firmware/rt61-firmware.spec SRPM URL: http://kwizart.free.fr/fedora/6/testing/rt2x00-firmware/rt61-firmware-1.2-3.kwizart.fc6.src.rpm Description: Firmware for RT61 802.11 wireless devices (removing needsponsor blocker here, as submitter was sponsored in https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167147 ) Do we actually have legal clearance here? I don't see that this ticket ever blocked FE-Legal. (Yes, it's case-sensitive.) And, perhaps more importantly, was there ever any response from Ralink? (In reply to comment #8) > Do we actually have legal clearance here? No, becasue... > And, perhaps more importantly, was there ever any response from Ralink? Not to the best of my knowledge. Blocking FE-Legal, but without *something* from Ralink, we're stuck. I have send a new mail to Ralink to ask them for legacl clearance for shipping the RT61 and RT73 firmware together with FC. I have CC'ed Nicolas Chauvet, Bill Nottingham and John Linville. Hopefully this new request will get more response. ;) Created attachment 161738 [details]
LICENSE.ralink-firmware.txt
License received in email dated Thu, 16 Aug 2007 14:18:00 +0800 from Paul Lin
<Paul_Lin.tw>.
$ curl -I http://www.ralinktech.com.tw/ralink/data/RT61_Firmware_V1.2.zip HTTP/1.1 404 Object Not Found The zip has vanished. Do you know the new location? it is: (the ralink directory was removed) http://www.ralinktech.com.tw/data/RT61_Firmware_V1.2.zip Well yes! I need to update the new path then! thx for have noticed that! But unfortunatily we cannot have somewhere to download the Ralin's license file... Usually, we need to have the license from within the firmware archive or at least from a public place (website). I will ask again... I can't lift FE-Legal here until I see the updated license text either: - Included with the firmware in the zip/tarball (this is strongly preferred) - On the ralink website somewhere As to the license text itself, as attached to bugzilla, it meets the firmware exception criteria. I just downloaded the firmware zip from #13 and that contained both the firmware and a license equal to that found in #11. SRPM: http://kwizart.free.fr/fedora/6/testing/rt2x00-firmware/rt61pci-firmware-1.2-4.src.rpm SPEC: http://kwizart.free.fr/fedora/6/testing/rt2x00-firmware/rt61pci-firmware.spec Description: Firmware for Ralink® RT2561/RT2661 A/B/G network adaptor %changelog - Disable dist tag - Preserve timestamp - Add license from Ralink - Improved summary and description (taken from iwl4965-firmware scheme ) We can remove FE-Legal as the bundled firmware was provided! I need someone to review the package... MUST items:
- Package meets naming and packaging guidelines - OK
- Spec file matches base package name - OK
- Spec has consistant macro usage. - OK
- Meets Packaging Guidelines. - OK
- License - OK
- License field in spec matches - OK
- License file included in package - OK
- Spec in American English - OK
- Spec is legible. - OK
- Sources match upstream md5sum: - OK
- Package needs ExcludeArch - OK
- BuildRequires correct - OK
- Spec handles locales/find_lang - N/A
- Package is relocatable and has a reason to be. - N/A
- Package has %defattr and permissions on files is good. - OK
- Package has a correct %clean section. - OK
- Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - OK
- Package is code or permissible content. - OK, firmware
- Doc subpackage needed/used. - N/A
- Packages %doc files don't affect runtime. - OK
- Headers/static libs in -devel subpackage. - N/A
- Spec has needed ldconfig in post and postun - N/A
- .pc files in -devel subpackage/requires pkgconfig - N/A
- .so files in -devel subpackage. - N/A
- -devel package Requires: %{name} = %{version}-%{release} - N/A
- .la files are removed. - N/A
- Package is a GUI app and has a .desktop file - N/A
- Package compiles and builds on at least one arch. - OK
- Package has no duplicate files in %files. - OK
- Package doesn't own any directories other packages own. - OK
- Package owns all the directories it creates. - OK
- No rpmlint output. - OK
- final provides and requires are sane: - OK (none)
SHOULD Items:
- Should build in mock. - OK
- Should build on all supported archs - noarch, so.. sure.
- Should function as described. - no hardware, can't test
- Should have sane scriptlets. - N/A
- Should have subpackages require base package with fully versioned depend. - N/A
- Should have dist tag - not needed. Hopefully won't need to rebuild this.
- Should package latest version - OK
Works for me. APPROVED.
New Package CVS Request ======================= Package Name: rt61pci-firmware Short Description: Firmware for Ralink® RT2561/RT2661 A/B/G network adaptor Owners: kwizart Branches: F-7 InitialCC: <empty> Commits by cvsextras: yes cvs done. |