Bug 2301873
| Summary: | Review Request: qtilitools - Scripts/commands used with qtilities apps | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steve Cossette <farchord> | ||||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | ngompa13, package-review | ||||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||||
| Target Release: | --- | Flags: | ngompa13:
fedora-review+
|
||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://github.com/qtilities/%{name} | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2024-07-31 15:12:24 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 2302190 | ||||||||
| Attachments: |
|
||||||||
|
Description
Steve Cossette
2024-07-31 01:52:02 UTC
Spec review: > Source0: %{url}/archive/refs/tags/%{version}.tar.gz Thie needs to be in the form of "%{url}/archive/%{version}/%{name}-%{version}.tar.gz" > BuildRequires: gcc-c++ This needs a fix upstream to declare that the CMake doesn't need a compiler. Basically, the project() stanza needs to change to this: > project(Qtilitools > VERSION 0.1.1 > LANGUAGES NONE > ) Copr build: https://copr.fedorainfracloud.org/coprs/build/7807135 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2301873-qtilitools/fedora-rawhide-x86_64/07807135-qtilitools/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Sent in a PR (Though I don't expect much will happen but we'll see). Updated the spec as well with the suggestion for the source. Spec URL: https://farchord.fedorapeople.org/reviews/qtilitools/qtilitools.spec SRPM URL: https://farchord.fedorapeople.org/reviews/qtilitools/qtilitools-0.1.2-1.fc41.src.rpm Description: Scripts/commands used with qtilities apps. Fedora Account System Username: farchord Can you add the patch to the package too? That way you can drop the gcc-c++ build dependency. Created attachment 2043135 [details]
The .spec file difference from Copr build 7807135 to 7808443
Copr build: https://copr.fedorainfracloud.org/coprs/build/7808443 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2301873-qtilitools/fedora-rawhide-x86_64/07808443-qtilitools/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Done Spec URL: https://farchord.fedorapeople.org/reviews/qtilitools/qtilitools.spec SRPM URL: https://farchord.fedorapeople.org/reviews/qtilitools/qtilitools-0.1.2-1.fc41.src.rpm Description: Scripts/commands used with qtilities apps. Fedora Account System Username: farchord Created attachment 2043137 [details]
The .spec file difference from Copr build 7808443 to 7808944
Copr build: https://copr.fedorainfracloud.org/coprs/build/7808944 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2301873-qtilitools/fedora-rawhide-x86_64/07808944-qtilitools/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Review notes: * Package complies with packaging guidelines * Package builds and installs * No serious issues from rpmlint PACKAGE APPROVED. Thank you for the review, Neal The Pagure repository was created at https://src.fedoraproject.org/rpms/qtilitools |