Bug 2302439

Summary: Review Request: rust-num-modular - A generic implementation of integer division and modular arithmetics
Product: [Fedora] Fedora Reporter: Michel Lind <michel>
Component: Package ReviewAssignee: Davide Cavalca <davide>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: davide, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: davide: fedora-review+
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/num-modular
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-08-11 04:48:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2302440    

Description Michel Lind 2024-08-02 03:25:29 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust-num-modular.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-num-modular-0.5.1-1.fc40.src.rpm

Description:
Implementation of efficient integer division and modular arithmetic
operations with generic number types. Supports various backends
including num-bigint, etc..

Fedora Account System Username: salimma

Comment 1 Fedora Review Service 2024-08-02 03:32:50 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7818158
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2302439-rust-num-modular/fedora-rawhide-x86_64/07818158-rust-num-modular/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Davide Cavalca 2024-08-02 17:17:36 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 3 Fedora Admin user for bugzilla script actions 2024-08-02 18:01:08 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-num-modular

Comment 4 Fedora Update System 2024-08-02 19:11:44 UTC
FEDORA-2024-364af59355 (rust-num-modular-0.5.1-2.fc41 and rust-num-prime-0.4.4-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-364af59355

Comment 5 Fedora Update System 2024-08-02 19:24:03 UTC
FEDORA-2024-364af59355 (rust-num-modular-0.5.1-2.fc41 and rust-num-prime-0.4.4-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2024-08-02 20:49:03 UTC
FEDORA-2024-491a6b222a (rust-num-modular-0.5.1-2.fc40 and rust-num-prime-0.4.4-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-491a6b222a

Comment 7 Fedora Update System 2024-08-03 02:20:39 UTC
FEDORA-2024-491a6b222a has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-491a6b222a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-491a6b222a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2024-08-11 04:48:53 UTC
FEDORA-2024-491a6b222a (rust-num-modular-0.5.1-2.fc40 and rust-num-prime-0.4.4-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.