Bug 2302683

Summary: Review Request: rust-redlib - Alternative private front-end to Reddit
Product: [Fedora] Fedora Reporter: Davide Cavalca <davide>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-08-28 20:50:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2302682    
Bug Blocks:    

Description Davide Cavalca 2024-08-04 01:48:30 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-redlib/rust-redlib.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-redlib/rust-redlib-0.35.1-1.fc41.src.rpm

Description:
Redlib is alternative private front-end to Reddit, with its origins in
Libreddit. Redlib hopes to provide an easier way to browse Reddit, without the
ads, trackers, and bloat.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-08-04 01:48:54 UTC
$ cat rust2rpm.toml 
[package]
description = """Redlib is alternative private front-end to Reddit, with its origins in
Libreddit. Redlib hopes to provide an easier way to browse Reddit, without the
ads, trackers, and bloat."""
cargo-toml-patch-comments = [
  "Bump cached to 0.53",
  "Temporarily downgrade brotli to 3.5",
]
extra-files = [
  "%doc CREDITS",
  "%config(noreplace) %{_sysconfdir}/redlib.conf",
  "%{_unitdir}/redlib.service",
]

[scripts]
install.post = [
  "install -Dpm0644 -t %{buildroot}%{_sysconfdir} contrib/redlib.conf",
  "install -Dpm0644 -t %{buildroot}%{_unitdir} contrib/redlib.service",
]

[requires]
build = ["systemd-rpm-macros"]

[tests]
skip = [
  "client::test_localization_popular",
  "client::test_obfuscated_share_link",
  "client::test_share_link_strip_json",
  "oauth::test_oauth_client",
  "oauth::test_oauth_token_exists",
  "subreddit::test_fetching_subreddit",
  "user::test_fetching_user",
  "utils::test_fetching_nsfw_subreddit",
  "utils::test_fetching_subreddit_quarantined",
  "utils::test_fetching_ws",
]
skip-exact = true
comments = [
  "skip tests requiring Internet access",
]

Comment 2 Michel Lind 2024-08-05 16:59:55 UTC
License should be fixed to AGPL-3.0-only (please send a PR so upstream fix it too)

https://spdx.org/licenses/

AGPL-3.0 without qualifier is deprecated as of SPDX 3

Comment 4 Michel Lind 2024-08-28 20:08:43 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (AGPL-3.0-only) and is acceptable for Fedora
- licenses of statically linked dependencies are correctly taken into account
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Fedora Admin user for bugzilla script actions 2024-08-28 20:10:24 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-redlib

Comment 6 Fedora Update System 2024-08-28 20:46:34 UTC
FEDORA-2024-2b879e613d (rust-redlib-0.35.1-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-2b879e613d

Comment 7 Fedora Update System 2024-08-28 20:50:01 UTC
FEDORA-2024-2b879e613d (rust-redlib-0.35.1-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2024-08-28 23:59:47 UTC
FEDORA-2024-f5d00d75c8 (rust-redlib-0.35.1-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-f5d00d75c8

Comment 9 Fedora Update System 2024-08-29 01:59:56 UTC
FEDORA-2024-f5d00d75c8 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f5d00d75c8 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f5d00d75c8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-09-13 20:45:52 UTC
FEDORA-2024-f5d00d75c8 (rust-redlib-0.35.1-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.