Bug 2302910

Summary: tor-0.4.8.12-1.fc40 systemd unit constantly restarts due to timeout even though it successfully started
Product: [Fedora] Fedora Reporter: Tad <tad>
Component: torAssignee: Marcel Haerry <mh>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 40CC: mh, pablo, paul.wouters, rh-bugzilla
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: tor-0.4.8.12-2.el9 tor-0.4.8.12-2.el8 tor-0.4.8.12-2.fc39 tor-0.4.8.12-2.fc40 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-08-16 00:41:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Tad 2024-08-05 15:33:35 UTC
tor-0.4.8.12-1.fc40 changed how the unit is handled

https://src.fedoraproject.org/rpms/tor/c/9568c5dc1f4a8ddcf55b5bf53adb9b761dad1716?branch=rawhide

however it ends up constantly restarting due to service timeout even though tor bootstraps to 100% successfully

this is broken

Reproducible: Always

Steps to Reproduce:
1. update to tor-0.4.8.12-1.fc40
2. have tor enabled/running
Actual Results:  
it constantly gets killed and restarted

Expected Results:  
for it to keep running like previously

flagging as high instead of urgent, because it is still in updates-testing, however this breaks the whole functionality of it

Comment 1 Tad 2024-08-05 15:35:23 UTC
for extra context across 3 of my servers, tor has restarted 4615 times in the past 18 hours

Comment 2 Marcel Haerry 2024-08-06 09:25:12 UTC
Can you provide logs, the unit itself was not changed so I am not sure why it now behaves like that.

Comment 3 Marcel Haerry 2024-08-06 09:46:56 UTC
I can confirm the issue, but there is not difference in the unit file, if you compare the one from tor-0.4.8.11 and tor-0.4.8.12 - so the problem must be somewhere else...

Comment 4 Marcel Haerry 2024-08-06 10:10:25 UTC
I guess I found the issue - the logic how to handle the different systemd versions was not always in one direction and thus the tor-0.4.8.12-1 didn't include systemd-devel as a build dependency and thus the daemon doesn't know how to notify systemd, which is what systemd was waiting for and since the notification never arrived it restarted the daemon after the timeout.

Comment 5 Fedora Update System 2024-08-06 11:56:54 UTC
FEDORA-2024-3f9eb3c86c (tor-0.4.8.12-2.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-3f9eb3c86c

Comment 6 Fedora Update System 2024-08-06 11:58:00 UTC
FEDORA-2024-c2da7f4de7 (tor-0.4.8.12-2.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c2da7f4de7

Comment 7 Fedora Update System 2024-08-06 11:59:05 UTC
FEDORA-EPEL-2024-4188096f1c (tor-0.4.8.12-2.el9) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-4188096f1c

Comment 8 Fedora Update System 2024-08-06 11:59:23 UTC
FEDORA-EPEL-2024-2d8a766d53 (tor-0.4.8.12-2.el8) has been submitted as an update to Fedora EPEL 8.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-2d8a766d53

Comment 9 Fedora Update System 2024-08-08 00:20:52 UTC
FEDORA-EPEL-2024-4188096f1c has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-4188096f1c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-08-08 00:31:01 UTC
FEDORA-EPEL-2024-2d8a766d53 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-2d8a766d53

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-08-08 03:36:40 UTC
FEDORA-2024-c2da7f4de7 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-c2da7f4de7`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-c2da7f4de7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-08-08 04:46:05 UTC
FEDORA-2024-3f9eb3c86c has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-3f9eb3c86c`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-3f9eb3c86c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-08-16 00:41:52 UTC
FEDORA-EPEL-2024-4188096f1c (tor-0.4.8.12-2.el9) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2024-08-16 01:03:50 UTC
FEDORA-EPEL-2024-2d8a766d53 (tor-0.4.8.12-2.el8) has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2024-08-16 01:21:03 UTC
FEDORA-2024-c2da7f4de7 (tor-0.4.8.12-2.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2024-08-16 13:07:06 UTC
FEDORA-2024-3f9eb3c86c (tor-0.4.8.12-2.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.