Bug 2303404

Created attachment 2043622 [details]
Srpm

Created attachment 2043623 [details]
spec

Spec URL: https://bugzilla.redhat.com/attachment.cgi?id=2043623
SRPM URL: https://bugzilla.redhat.com/attachment.cgi?id=2043622
Description: A cargo subcommand to see license of dependencies.
Fedora Account System Username: solomoncyj

cargo-license subpackage clearly does have FIXME instead of its license. That should include License of the project and its dependencies combined. That seems to be what License of main package contains now. I think that belongs only to %{crate} subpackage, the rest should have just MIT license used by the project itself.

I expect that is a blocker for the review, but I am not rust expert.

(In reply to Petr Menšík from comment #4)
> cargo-license subpackage clearly does have FIXME instead of its license.
> That should include License of the project and its dependencies combined.
> That seems to be what License of main package contains now. I think that
> belongs only to %{crate} subpackage, the rest should have just MIT license
> used by the project itself.
> 
> I expect that is a blocker for the review, but I am not rust expert.

The main licenses is inherited by all subpackages

Petr is correct.

This is a normal Rust crate, you should not use SourceLicense at all. The way it's set up by rust2rpm is correct.

Make SourceLicense the License, and move the License to the subpackage instead of the FIXME.

Created attachment 2044727 [details]
spec-2

Created attachment 2044728 [details]
srpm-2

Spec URL: https://bugzilla.redhat.com/attachment.cgi?id=2044727
SRPM URL: https://bugzilla.redhat.com/attachment.cgi?id=2044728
Description: A cargo subcommand to see license of dependencies.
Fedora Account System Username: solomoncyj

SPEC URL: https://github.com/solomoncyj/cargo-license/releases/download/1/rust-cargo-license.spec
SRPM URL: https://github.com/solomoncyj/cargo-license/releases/download/1/rust-cargo-license-0.6.1-1.fc40.src.rpm
Description: A cargo subcommand to see license of dependencies.
Fedora Account System Username: solomoncyj

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7988879
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2303404-rust-cargo-license/fedora-rawhide-x86_64/07988879-rust-cargo-license/fedora-review/review.txt

Found issues:

- License file cargo-license is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Replace this:

```
SourceLicense:        MIT
License:        %{shrink:
((MIT OR Apache-2.0) AND Unicode-DFS-2016) AND
(Apache-2.0 OR BSL-1.0) AND
(Apache-2.0 OR MIT) AND
MIT
}
```

With just this:

```
License:        MIT
```

And you should be good.

Setting the SourceLicense/License tag in the "main" package the way you did is wrong - it would cause the -devel subpackage have the "binary" license too, even if it should just be covered by the "Source" license.

I don't know where you got the idea for using the "SourceLicense" tag? It's not used at all by rust2rpm for this type of package (for good reasons).