Bug 2304023

Summary: Review Request: rust-boxcar - Concurrent, append-only vector
Product: [Fedora] Fedora Reporter: Ben Beasley <code>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard: Trivial
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-08-22 18:49:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Configuration file for rust2rpm
none
Updated configuration for rust2rpm none

Description Ben Beasley 2024-08-11 17:04:23 UTC
Spec URL: https://music.fedorapeople.org/rust-boxcar.spec
SRPM URL: https://music.fedorapeople.org/rust-boxcar-0.2.5-1.fc40.src.rpm

Description:

A concurrent, append-only vector.

Fedora Account System Username: music

This package built in Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=121803892

The spec file is the unmodified output of rust2rpm, with a rust2rpm.toml configuration file to be attached.

Comment 1 Ben Beasley 2024-08-11 17:05:30 UTC
This is a dependency for uv 0.2.35.

Comment 2 Ben Beasley 2024-08-11 17:06:05 UTC
Created attachment 2043932 [details]
Configuration file for rust2rpm

Removes the benchmark-only dev-dependency on criterion.

Comment 3 Ben Beasley 2024-08-15 12:46:57 UTC
Updated with https://github.com/ibraheemdev/boxcar/pull/8, which fixes bench.rs license text issues.

New Spec URL: https://music.fedorapeople.org/20240815/rust-boxcar.spec
New SRPM URL: https://music.fedorapeople.org/20240815/rust-boxcar-0.2.5-1.fc40.src.rpm

Comment 4 Ben Beasley 2024-08-15 12:48:17 UTC
Created attachment 2044243 [details]
Updated configuration for rust2rpm

Comment 5 Michel Lind 2024-08-22 18:18:52 UTC
nit: consider making the patch filename more readable

instead of https://github.com/ibraheemdev/boxcar/pull/8/commits/74c3f316c23d419bc97054c017b94d07bec21b34.patch

you can do https://github.com/ibraheemdev/boxcar/pull/8/commits/74c3f316c23d419bc97054c017b94d07bec21b34.patch#/boxcar-sharded-slab-license.diff (or another name, your choice)

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 6 Ben Beasley 2024-08-22 18:26:50 UTC
Thank you for the review!

(In reply to Michel Lind from comment #5)
> nit: consider making the patch filename more readable
> 
> instead of
> https://github.com/ibraheemdev/boxcar/pull/8/commits/
> 74c3f316c23d419bc97054c017b94d07bec21b34.patch
> 
> you can do
> https://github.com/ibraheemdev/boxcar/pull/8/commits/
> 74c3f316c23d419bc97054c017b94d07bec21b34.patch#/boxcar-sharded-slab-license.
> diff (or another name, your choice)

A reasonable suggestion. I can adjust this on import.

https://release-monitoring.org/project/374001/

Comment 7 Fedora Admin user for bugzilla script actions 2024-08-22 18:27:21 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-boxcar

Comment 8 Fedora Update System 2024-08-22 18:47:02 UTC
FEDORA-2024-ad289b03b5 (rust-boxcar-0.2.5-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-ad289b03b5

Comment 9 Fedora Update System 2024-08-22 18:49:44 UTC
FEDORA-2024-ad289b03b5 (rust-boxcar-0.2.5-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2024-08-22 18:54:05 UTC
FEDORA-2024-cc2ad04ff2 (rust-boxcar-0.2.5-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-cc2ad04ff2

Comment 11 Fedora Update System 2024-08-22 19:01:43 UTC
FEDORA-2024-cc2ad04ff2 (rust-boxcar-0.2.5-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2024-08-23 00:51:44 UTC
FEDORA-2024-27d418ad87 (rust-boxcar-0.2.5-1.fc40 and uv-0.2.37-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-27d418ad87

Comment 13 Fedora Update System 2024-08-23 00:51:46 UTC
FEDORA-2024-9aa5028210 (rust-boxcar-0.2.5-1.fc39 and uv-0.2.37-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-9aa5028210

Comment 14 Fedora Update System 2024-08-24 01:52:14 UTC
FEDORA-2024-9aa5028210 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9aa5028210`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9aa5028210

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2024-08-24 02:58:12 UTC
FEDORA-2024-27d418ad87 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-27d418ad87`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-27d418ad87

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2024-09-01 01:45:41 UTC
FEDORA-2024-9aa5028210 (rust-boxcar-0.2.5-1.fc39 and uv-0.2.37-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2024-09-01 02:43:22 UTC
FEDORA-2024-27d418ad87 (rust-boxcar-0.2.5-1.fc40 and uv-0.2.37-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.