Bug 2304160

Summary:	Please branch and build hiredis in epel10
Product:	[Fedora] Fedora EPEL	Reporter:	Michel Lind <michel>
Component:	hiredis	Assignee:	Michel Lind <michel>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	epel10	CC:	davide, gary.buhrmaster, igor.raits, kevin, nathans, orion, pasik
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	hiredis-1.2.0-5.el10_0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-09-05 04:07:27 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2304161
Bug Blocks:	1914423, 2303877

Description Michel Lind 2024-08-12 15:03:11 UTC

Please branch and build hiredis in epel10.

If you do not wish to maintain hiredis in epel10,
or do not think you will be able to do this in a timely manner,
the EPEL Packagers SIG would be happy to be a co-maintainer of the package;
please add the epel-packagers-sig group through
https://src.fedoraproject.org/rpms/hiredis/addgroup
and grant it commit access, or collaborator access on epel* branches.

I would also be happy to be a co-maintainer (FAS: salimma);
please add me through https://src.fedoraproject.org/rpms/hiredis/adduser

Comment 1 Michel Lind 2024-08-12 15:07:58 UTC

Do we know if this works with valkey as is, and we should depend on it directly? It currently depends on redis, which is provided by a compat package by valkey but that is not shipped to CRB. Probably should remove the crutch if we don't need it

Comment 2 Davide Cavalca 2024-08-23 17:06:30 UTC

Will you be able to branch and build hiredis in epel10?
The EPEL Packagers SIG would be happy to be a co-maintainer
if you do not wish to build it on epel10.

Comment 3 Kevin Fenzi 2024-08-24 23:26:39 UTC

So, yeah, I don't object to adding this to epel10, but yeah, it currently depends on redis. 

If we want to move it to valkey, it would be nice if we could convince upstream to support both or just move to valkey?
and we should move fedora probibly first before we go and push a version into epel.

Happy to have help moving this forward/co-maintainers.

Comment 4 Orion Poplawski 2024-08-25 01:26:55 UTC

I've filed a PR to switch hiredis to valkey directly.

Comment 5 Orion Poplawski 2024-08-31 19:45:13 UTC

I've merged the change to move to valkey for tests.  It would be nice to get this into EPEL10 now.  I can't request that branch though.

Comment 6 Michel Lind 2024-09-03 23:36:20 UTC

Kevin granted epel-packagers-sig access (and Orion co-admin) so I'm building this now. We're still blocked on one more dep, which can be escalated to releng this Friday

Comment 7 Fedora Update System 2024-09-03 23:36:52 UTC

FEDORA-EPEL-2024-dfb9da53fb (hiredis-1.2.0-5.el10_0) has been submitted as an update to Fedora EPEL 10.0.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-dfb9da53fb

Comment 8 Fedora Update System 2024-09-04 04:29:04 UTC

FEDORA-EPEL-2024-dfb9da53fb has been pushed to the Fedora EPEL 10.0 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-dfb9da53fb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2024-09-05 04:07:27 UTC

FEDORA-EPEL-2024-dfb9da53fb (hiredis-1.2.0-5.el10_0) has been pushed to the Fedora EPEL 10.0 stable repository.
If problem still persists, please make note of it in this bug report.