Bug 2304222

Summary: Review Request: rust-openxr-sys - OpenXR FFI bindings
Product: [Fedora] Fedora Reporter: Jonathan Steffan <jonathansteffan>
Component: Package ReviewAssignee: Davide Cavalca <davide>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: davide, package-review
Target Milestone: ---Flags: davide: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-09-08 16:56:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2304223    

Description Jonathan Steffan 2024-08-13 01:10:44 UTC
Spec URL: https://jsteffan.fedorapeople.org/envision/rust-openxr-sys.spec
SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-openxr-sys-0.11.0-1.fc39/rust-openxr-sys-0.11.0-1.fc40.src.rpm
Description: OpenXR FFI bindings
Fedora Account System Username: jsteffan

Comment 1 Jonathan Steffan 2024-08-13 01:18:44 UTC
[requires]
build = ["pkgconfig(openxr)"]
lib = ["pkgconfig(openxr)"]

Comment 2 Davide Cavalca 2024-09-08 15:59:56 UTC
> # Remove bundled OpenXR-SDK
> rm -rf OpenXR-SDK

FYI you can use the [scripts] section in rust2rpm.toml to automate this bit as well

Comment 3 Davide Cavalca 2024-09-08 16:09:53 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 4 Jonathan Steffan 2024-09-08 16:16:09 UTC
This will be added to the checked in rust2rpm.toml.

[requires]
build = ["pkgconfig(openxr)"]
lib = ["pkgconfig(openxr)"]

[scripts.prep]
post = [
    "# Remove bundled OpenXR-SDK",
    "rm -rf OpenXR-SDK"
]

Comment 5 Fedora Admin user for bugzilla script actions 2024-09-08 16:23:37 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-openxr-sys

Comment 6 Fedora Update System 2024-09-08 16:54:09 UTC
FEDORA-2024-6af25dec6b (rust-openxr-sys-0.11.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6af25dec6b

Comment 7 Fedora Update System 2024-09-08 16:56:45 UTC
FEDORA-2024-6af25dec6b (rust-openxr-sys-0.11.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.