Bug 2305343

Hi Felix, short answer is yes. I'll review this for you. I'll run fedora-review as soon as I can.

Some preliminary notes:

Minor spellcheck in libimagevisualresult-data subpackage description: dat -> data

You probably know, but this only builds on rawhide due to a couple dependencies that are missing in the other distros.

Have you spent any time with the tests?
For giggles, I made the following changes to build the package with tests turned on:
https://github.com/knight-of-ni/specfiles/commit/f69342330eb8cc87d31d0e3eadcdf3a657d9b367

That's when I realized that the tests don't seem to be configured properly to actually run during the build. That's where I stopped.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/


===== MUST items =====

C/C++:
[ ]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* GNU General Public
     License, Version 3", "Creative Commons Attribution 4.0 and/or Creative
     Commons CC0 1.0 and/or GNU General Public License, Version 3",
     "Creative Commons Attribution 4.0", "*No copyright* Creative Commons
     CC0 1.0", "GNU General Public License, Version 3", "libtiff License".
     338 files have unknown license. Detailed output of licensecheck in
     /home/abauer/2305343-deepin-image-editor/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/libimageviewer,
     /usr/share/libimageviewer/translations
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/libimageviewer/translations, /usr/share/libimageviewer
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 5332 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     libimageviewer , libimageviewer-devel , libimagevisualresult ,
     libimagevisualresult-devel , libimagevisualresult-data
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: https://docs.fedoraproject.org/en-US/packaging-
     guidelines/#_use_rpmlint
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 5.6 starting (python version = 3.12.4, NVR = mock-5.6-1.fc40), args: /usr/libexec/mock/mock -r fedora-rawhide-x86_64 --no-cleanup-after --no-clean --plugin-option=tmpfs:keep_mounted=True --resultdir=/home/abauer/2305343-deepin-image-editor/results install /home/abauer/2305343-deepin-image-editor/results/libimagevisualresult-debuginfo-1.0.44-1.fc42.x86_64.rpm /home/abauer/2305343-deepin-image-editor/results/libimagevisualresult-1.0.44-1.fc42.x86_64.rpm /home/abauer/2305343-deepin-image-editor/results/deepin-image-editor-debuginfo-1.0.44-1.fc42.x86_64.rpm /home/abauer/2305343-deepin-image-editor/results/libimageviewer-1.0.44-1.fc42.x86_64.rpm /home/abauer/2305343-deepin-image-editor/results/libimagevisualresult-devel-1.0.44-1.fc42.x86_64.rpm /home/abauer/2305343-deepin-image-editor/results/libimagevisualresult-data-1.0.44-1.fc42.noarch.rpm /home/abauer/2305343-deepin-image-editor/results/libimageviewer-devel-1.0.44-1.fc42.x86_64.rpm /home/abauer/2305343-deepin-image-editor/results/deepin-image-editor-debugsource-1.0.44-1.fc42.x86_64.rpm /home/abauer/2305343-deepin-image-editor/results/libimageviewer-debuginfo-1.0.44-1.fc42.x86_64.rpm
Start(bootstrap): init plugins
INFO: selinux disabled
Finish(bootstrap): init plugins
Start: init plugins
INFO: selinux disabled
Finish: init plugins
INFO: Signal handler active
Start: run
Mock Version: 5.6
INFO: Mock Version: 5.6
Start(bootstrap): chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start(bootstrap): cleaning package manager metadata
Finish(bootstrap): cleaning package manager metadata
INFO: Package manager dnf5 detected and used (fallback)
Finish(bootstrap): chroot init
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start: cleaning package manager metadata
Finish: cleaning package manager metadata
INFO: enabled HW Info plugin
INFO: Package manager dnf5 detected and used (direct choice)
Finish: chroot init
INFO: installing package(s): /builddir/libimagevisualresult-debuginfo-1.0.44-1.fc42.x86_64.rpm /builddir/libimagevisualresult-1.0.44-1.fc42.x86_64.rpm /builddir/deepin-image-editor-debuginfo-1.0.44-1.fc42.x86_64.rpm /builddir/libimageviewer-1.0.44-1.fc42.x86_64.rpm /builddir/libimagevisualresult-devel-1.0.44-1.fc42.x86_64.rpm /builddir/libimagevisualresult-data-1.0.44-1.fc42.noarch.rpm /builddir/libimageviewer-devel-1.0.44-1.fc42.x86_64.rpm /builddir/deepin-image-editor-debugsource-1.0.44-1.fc42.x86_64.rpm /builddir/libimageviewer-debuginfo-1.0.44-1.fc42.x86_64.rpm
ERROR: Command failed: 
 # /usr/bin/systemd-nspawn -q -M a0c2c2615e4441248868c514e3a66b43 -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.oeih2iwv:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin '--setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007"' '--setenv=PS1=<mock-chroot> \s-\v\$ ' --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf5 --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 42 install /builddir/libimagevisualresult-debuginfo-1.0.44-1.fc42.x86_64.rpm /builddir/libimagevisualresult-1.0.44-1.fc42.x86_64.rpm /builddir/deepin-image-editor-debuginfo-1.0.44-1.fc42.x86_64.rpm /builddir/libimageviewer-1.0.44-1.fc42.x86_64.rpm /builddir/libimagevisualresult-devel-1.0.44-1.fc42.x86_64.rpm /builddir/libimagevisualresult-data-1.0.44-1.fc42.noarch.rpm /builddir/libimageviewer-devel-1.0.44-1.fc42.x86_64.rpm /builddir/deepin-image-editor-debugsource-1.0.44-1.fc42.x86_64.rpm /builddir/libimageviewer-debuginfo-1.0.44-1.fc42.x86_64.rpm --setopt=deltarpm=False --setopt=allow_vendor_change=yes --allowerasing



Rpmlint
-------
Checking: libimageviewer-1.0.44-1.fc42.x86_64.rpm
          libimageviewer-devel-1.0.44-1.fc42.x86_64.rpm
          libimagevisualresult-1.0.44-1.fc42.x86_64.rpm
          libimagevisualresult-devel-1.0.44-1.fc42.x86_64.rpm
          libimagevisualresult-data-1.0.44-1.fc42.noarch.rpm
          deepin-image-editor-debuginfo-1.0.44-1.fc42.x86_64.rpm
          deepin-image-editor-debugsource-1.0.44-1.fc42.x86_64.rpm
          deepin-image-editor-1.0.44-1.fc42.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp6nf5treb')]
checks: 32, packages: 8

libimagevisualresult-data.noarch: E: zero-length /usr/share/libimagevisualresult/filter_cube/null.dat
libimageviewer.x86_64: W: name-repeated-in-summary libimageviewer
libimagevisualresult.x86_64: W: name-repeated-in-summary libimagevisualresult
 8 packages and 0 specfiles checked; 1 errors, 2 warnings, 93 filtered, 1 badness; has taken 1.8 s 




Source checksums
----------------
https://github.com/linuxdeepin/image-editor/archive/1.0.44/image-editor-1.0.44.tar.gz :
  CHECKSUM(SHA256) this package     : eab933ef3c7577d22facb1b82f44e51eb851508db0bca4dd9a649c2fc740f679
  CHECKSUM(SHA256) upstream package : eab933ef3c7577d22facb1b82f44e51eb851508db0bca4dd9a649c2fc740f679


Requires
--------
libimageviewer (rpmlib, GLIBC filtered):
    ld-linux-x86-64.so.2()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.15)(64bit)
    libQt5DBus.so.5()(64bit)
    libQt5DBus.so.5(Qt_5)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5PrintSupport.so.5()(64bit)
    libQt5PrintSupport.so.5(Qt_5)(64bit)
    libQt5Svg.so.5()(64bit)
    libQt5Svg.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libdfm-io.so.0()(64bit)
    libdtkcore.so.5()(64bit)
    libdtkgui.so.5()(64bit)
    libdtkwidget.so.5()(64bit)
    libfreeimage.so.3()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.13)(64bit)
    libstdc++.so.6(CXXABI_1.3.15)(64bit)
    libstdc++.so.6(CXXABI_1.3.2)(64bit)
    libstdc++.so.6(CXXABI_1.3.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libtiff.so.6()(64bit)
    libtiff.so.6(LIBTIFF_4.0)(64bit)
    rtld(GNU_HASH)

libimageviewer-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libimageviewer(x86-64)
    libimageviewer.so.0.1()(64bit)
    pkgconfig(Qt5Concurrent)
    pkgconfig(Qt5Core)
    pkgconfig(Qt5DBus)
    pkgconfig(Qt5Gui)
    pkgconfig(Qt5PrintSupport)
    pkgconfig(Qt5Svg)
    pkgconfig(Qt5Widgets)
    pkgconfig(dtkcore)
    pkgconfig(dtkwidget)

libimagevisualresult (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libimagevisualresult-data(x86-64)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    rtld(GNU_HASH)

libimagevisualresult-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libimagevisualresult(x86-64)
    libimagevisualresult.so.0.1()(64bit)

libimagevisualresult-data (rpmlib, GLIBC filtered):
    libimagevisualresult(x86-64)

deepin-image-editor-debuginfo (rpmlib, GLIBC filtered):

deepin-image-editor-debugsource (rpmlib, GLIBC filtered):



Provides
--------
libimageviewer:
    libimageviewer
    libimageviewer(x86-64)
    libimageviewer.so.0.1()(64bit)

libimageviewer-devel:
    libimageviewer-devel
    libimageviewer-devel(x86-64)
    pkgconfig(libimageviewer)

libimagevisualresult:
    libimagevisualresult
    libimagevisualresult(x86-64)
    libimagevisualresult.so.0.1()(64bit)

libimagevisualresult-devel:
    libimagevisualresult-devel
    libimagevisualresult-devel(x86-64)
    pkgconfig(libimagevisualresult)

libimagevisualresult-data:
    libimagevisualresult-data

deepin-image-editor-debuginfo:
    deepin-image-editor-debuginfo
    deepin-image-editor-debuginfo(x86-64)

deepin-image-editor-debugsource:
    deepin-image-editor-debugsource
    deepin-image-editor-debugsource(x86-64)

libimagevisualresult and libimagevisualresult-data are currently uninstallable.  libimagevisualresult-data is noarch but libimagevisualresult is not. 
Since the Requires on each package has %{?_isa}, they never match. I think the solution here would be to remove noarch from libimagevisualresult-data.

I believe this is the cause of the mock error in Fedora Review.

------------------------------

These folders should be owned by libimageviewer subpackage:
/usr/share/libimageviewer
/usr/share/libimageviewer/translations

------------------------------

The zero length file can probably be ignored, but do we know what this file is for?
/usr/share/libimagevisualresult/filter_cube/null.dat


--------------------------------

I thought the LICENSES subfolder in the upstream project was a bit odd, but I think we can ignore this since LICENSE.txt clearly says GPL-3.0

Spec URL: https://topazus.fedorapeople.org/deepin-image-editor.spec
SRPM URL: https://topazus.fedorapeople.org/deepin-image-editor-1.0.46-1.fc42.src.rpm

Thanks for your review work. I did the following modifications:
removed %{?isa} in Requires of libimagevisualresult-data, so the installation will be good.
fixed to own the directory of /usr/share/libimageviewer and /usr/share/libimageviewer/translations.
enabled the tests.
updated to the latest release.

I tested in copr: https://copr.fedorainfracloud.org/coprs/topazus/test/build/8094623/

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8095209
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2305343-deepin-image-editor/fedora-rawhide-x86_64/08095209-deepin-image-editor/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

hi Felix - Welcome back. I hope your graduation went well.

package APPROVED.

I am thankful for your concern to this matter about my graduation. It is going smoothly.
The creation of repository failed because you did not assign this bugzilla, https://pagure.io/releng/fedora-scm-requests/issue/68519. You needs to take Assignee.

Sorry about that. Just got back from vacation. Should be fixed now.

The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-image-editor

FEDORA-2024-1b4da28de4 (deepin-image-editor-1.0.46-2.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-1b4da28de4

FEDORA-2024-1b4da28de4 (deepin-image-editor-1.0.46-2.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.