Bug 230571

Summary: libart_lgpl: art_alloc declaration causes c++ compilations (including kdelibs) to fail
Product: [Fedora] Fedora Reporter: Rex Dieter <rdieter>
Component: libart_lgplAssignee: Behdad Esfahbod <behdad>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-03-01 21:33:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Rex Dieter 2007-03-01 16:32:08 UTC
Recent versions of libart_lgpl changed the declarations of art_alloc, art_free,
art_realloc from #defines to real functions, but didn't wrap these with with 
extern "C", which can/will cause c++ apps that use libart to fail linking. The
following patch addresses that:

- libart_lgpl-2.3.19/art_misc.h.extern-c      2007-01-02 00:59:22.000000000 
+0100
+++ libart_lgpl-2.3.19/art_misc.h       2007-03-01 09:19:06.000000000 +0100
@@ -34,9 +34,15 @@
 #include <libart_lgpl/art_config.h>
 #endif

+#ifdef __cplusplus
+extern "C" {
+#endif
 void *art_alloc(size_t size);
 void art_free(void *ptr);
 void *art_realloc(void *ptr, size_t size);
+#ifdef __cplusplus
+}
+#endif /* __cplusplus */

Comment 1 Rex Dieter 2007-03-01 16:53:10 UTC
FYI, Just read on the kde-packager ml that this fix has already been applied
upstream, and will (presumably) be included in the next release.  Dunno how long
a new release will take though, so fixing this asap would be appreciated (since
it blocks kdelibs (re)builds).

Comment 2 Behdad Esfahbod 2007-03-01 21:33:04 UTC
Building 2.3.19-2.