Bug 2306164
| Summary: | Review Request: fyi - Command line utility to send desktop notifications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Neel Chauhan <neel> |
| Component: | Package Review | Assignee: | Onuralp Sezer <thunderbirdtr> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | neel, package-review, thunderbirdtr |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | thunderbirdtr:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://codeberg.org/dnkl/fyi | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-08-26 02:58:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
Neel Chauhan
2024-08-20 18:23:59 UTC
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=122369719 I am taking the review [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/7941920 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2306164-fyi/fedora-rawhide-x86_64/07941920-fyi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Hello Neel for start please remove duplicate LICENSE entry and use license macro entry only and secondly use %doc macro like this Example : %doc README.rst docs/readme.rst Thank you. I updated it. Does it look good? Spec URL: https://neelc.org/fedora/fyi/r2/fyi.spec SRPM URL: https://neelc.org/fedora/fyi/r2/fyi-1.0.3-1.fc42.src.rpm [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/7941974 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2306164-fyi/fedora-rawhide-x86_64/07941974-fyi/fedora-review/review.txt Found issues: - License file LICENSE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/7941975 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2306164-fyi/fedora-rawhide-x86_64/07941975-fyi/fedora-review/review.txt Found issues: - License file LICENSE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Actually, try these (based on Comment 8's errors): Spec URL: https://neelc.org/fedora/fyi/r3/fyi.spec SRPM URL: https://neelc.org/fedora/fyi/r3/fyi-1.0.3-1.fc42.src.rpm Created attachment 2044836 [details]
The .spec file difference from Copr build 7941975 to 7941976
Copr build: https://copr.fedorainfracloud.org/coprs/build/7941976 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2306164-fyi/fedora-rawhide-x86_64/07941976-fyi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Hello Just use %license LICENSE and you could remove path behind it and add CHANGELOG as doc next to README file as well. No need to type full path just add next to README with space %license LICENSE %doc README.md CHANGELOG.md When doing "%license LICENSE" on it's own, I get this: error: Installed (but unpackaged) file(s) found: /usr/share/doc/fyi/LICENSE One way is to fix this is to do "%doc CHANGELOG.md LICENSE README.md" If that's okay, here's my updated files: Spec URL: https://neelc.org/fedora/fyi/r4/fyi.spec SRPM URL: https://neelc.org/fedora/fyi/r4/fyi-1.0.3-1.fc42.src.rpm Created attachment 2044838 [details]
The .spec file difference from Copr build 7941976 to 7942089
Copr build: https://copr.fedorainfracloud.org/coprs/build/7942089 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2306164-fyi/fedora-rawhide-x86_64/07942089-fyi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. okay remove doc folder
%install
%meson_install
rm -r %{buildroot}/%{_datadir}/doc/%{name}/
%files
%license LICENSE
%doc CHANGELOG.md LICENSE README.md
%{_bindir}/%{name}
%{_mandir}/man1/%{name}.1.gz
%files bash-completion
%{_datadir}/bash-completion/completions/%{name}
%files fish-completion
%{_datadir}/fish/vendor_completions.d/%{name}.fish
And It should be fine and we need to split bash and fish and for example reference check out here
https://src.fedoraproject.org/rpms/fastfetch/blob/rawhide/f/fastfetch.spec
You can see how bash and fish split also write desc and other parts you need I only write files section
I like it. My new ones are: Spec URL: https://neelc.org/fedora/fyi/r4/fyi.spec SRPM URL: https://neelc.org/fedora/fyi/r4/fyi-1.0.3-1.fc42.src.rpm I'm new-ish to RPM packaging, I came from the FreeBSD world where subpackages were never used. Is this good? Sorry for the back and forth. Copr build: https://copr.fedorainfracloud.org/coprs/build/7942176 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2306164-fyi/fedora-rawhide-x86_64/07942176-fyi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. I believe this spec file I need to check https://neelc.org/fedora/fyi/r5/fyi.spec Please post your new ones again so bot can check properly Oops, is this good: Spec URL: https://neelc.org/fedora/fyi/r5/fyi.spec SRPM URL: https://neelc.org/fedora/fyi/r5/fyi-1.0.3-1.fc42.src.rpm It is no problem to be new welcome :) and
We should also use autosetup with p1 means if any patch added it will automatically use it.
%prep
%autosetup-p1 -n %{name}
And then rest should be good
Created attachment 2044840 [details]
The .spec file difference from Copr build 7942176 to 7942188
Copr build: https://copr.fedorainfracloud.org/coprs/build/7942188 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2306164-fyi/fedora-rawhide-x86_64/07942188-fyi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Done! Please approve when you can. Spec URL: https://neelc.org/fedora/fyi/r6/fyi.spec SRPM URL: https://neelc.org/fedora/fyi/r6/fyi-1.0.3-1.fc42.src.rpm Created attachment 2044841 [details]
The .spec file difference from Copr build 7942188 to 7942190
Copr build: https://copr.fedorainfracloud.org/coprs/build/7942190 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2306164-fyi/fedora-rawhide-x86_64/07942190-fyi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Review notes: * Package follows Fedora packaging guidelines * Package builds and installs * Package licensing looks correct * No serious issues in rpmlint PACKAGE APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/fyi FEDORA-2024-873f0bd65d (fyi-1.0.3-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-873f0bd65d FEDORA-2024-1911accbec (fyi-1.0.3-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-1911accbec FEDORA-2024-873f0bd65d (fyi-1.0.3-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-1911accbec (fyi-1.0.3-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |