Bug 2306378

Summary: Review Request: rust-debug-helper - Declarative macros to help you implement the Debug trait manually
Product: [Fedora] Fedora Reporter: Orion Poplawski <orion>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/debug-helper
Whiteboard:
Fixed In Version: rust-debug-helper-0.3.13-3.fc42 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-09-14 02:44:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2306379    

Description Orion Poplawski 2024-08-21 02:35:51 UTC
Spec URL: https://orion.fedorapeople.org/rust-debug-helper.spec
SRPM URL: https://orion.fedorapeople.org/rust-debug-helper-0.3.13-1.fc42.src.rpm
Description:

This crate provides declarative macros to help you implement the `Debug`
trait manually.

Fedora Account System Username: orion

https://koji.fedoraproject.org/koji/taskinfo?taskID=122243999

Comment 1 Fedora Review Service 2024-08-21 19:32:54 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7932207
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2306378-rust-debug-helper/fedora-rawhide-x86_64/07932207-rust-debug-helper/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-debug-helper
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Orion Poplawski 2024-08-22 03:18:10 UTC
Current package has been retired for a long time, needs a re-review.

Comment 3 Fabio Valentini 2024-09-08 12:26:33 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks: (skip those that don't apply to un-retirements)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Orion Poplawski 2024-09-14 02:44:16 UTC
Checked in and built.  Thanks for the review.