Bug 2306379

Summary:	Review Request: rust-crc-any - To compute CRC values
Product:	[Fedora] Fedora	Reporter:	Orion Poplawski <orion>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	https://crates.io/crates/crc-any
Whiteboard:
Fixed In Version:	rust-crc-any-2.5.0-1.fc42	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-09-26 01:43:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2306378
Bug Blocks:	2306380

Description Orion Poplawski 2024-08-21 02:42:05 UTC

Spec URL: https://orion.fedorapeople.org/rust-crc-any.spec
SRPM URL: https://orion.fedorapeople.org/rust-crc-any-2.5.0-1.fc42.src.rpm
Description:
To compute CRC values by providing the length of bits, expression,
reflection, an initial value and a final xor value. It has many built-in
CRC functions.

Fedora Account System Username: orion

Comment 1 Fedora Review Service 2024-08-21 19:33:25 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7932208
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2306379-rust-crc-any/fedora-rawhide-x86_64/07932208-rust-crc-any/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Orion Poplawski 2024-08-22 03:18:33 UTC

Current package has been retired for a long time, needs a re-review.

Comment 3 Fabio Valentini 2024-09-21 13:55:08 UTC

Looks good to me, though the Summary could be a bit less yoda-talk-y :)

===

Package was generated with rust2rpm, simplifying the review.

✅❌❓🫤

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

-> skip those that don't make sense for package un-retirements

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Orion Poplawski 2024-09-26 01:43:32 UTC

Thanks for the review.  Checked in and built.