Bug 2306513

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7932218
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2306513-php-smarty4/srpm-builds/07932218/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Bad perms on the srpm, fixed now
[fedora-review-service-build]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7932266
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2306513-php-smarty4/fedora-rawhide-x86_64/07932266-php-smarty4/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Spec URL: https://www.bachelot.org/fedora/SPECS/php-smarty4.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/php-smarty4-4.5.6-1.fc44.src.rpm

Created attachment 2104986 [details]
The .spec file difference from Copr build 7932266 to 9494728

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9494728
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2306513-php-smarty4/fedora-rawhide-x86_64/09494728-php-smarty4/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

As php-Smarty exists (v3), a review is not mandatory; you can open a SCM request with the exception flag

See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/#_package_review_process

    > The package is being created so that multiple versions of the same package can coexist in the distribution...


I'm used to do this, ex https://pagure.io/releng/fedora-scm-requests/issue/72031

From a quick look:

Notice from recently updated PHP Guidelines:  https://docs.fedoraproject.org/en-US/packaging-guidelines/PHP/

     > Can be ignored as always present: core, date, filter, hash, pcre, random, reflection, session, spl, standard.

Perhaps apcu, memcache and Memcached could be weak dependencies (Recommends)

Spec URL: https://www.bachelot.org/fedora/SPECS/php-smarty4.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/php-smarty4-4.5.6-2.fc44.src.rpm

Thanks for the comment Remi !
I've removed the needless Requires and turned the apcu, memcache and memcached to Recommends.
Also, I've synch'ed the version test from php-Smarty, as at least this one can run even on EL.

I'm not perfectly happy with not using the tarball from github and would like to look at providing a tarball that just adds the missing phpunit.xml and tests subdir.
What do you think ?

Created attachment 2106437 [details]
The .spec file difference from Copr build 9494728 to 9551268

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9551268
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2306513-php-smarty4/fedora-rawhide-x86_64/09551268-php-smarty4/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> I'm not perfectly happy with not using the tarball from github ...


I have fought a lot against this .gitattributes file
which is a workaround to the missing installer for PHP library
(composer is NOT an installer, only a dependency resolver)

Now, I gave up.
Using a git snapshot is OK.

Nearly all PHP libraries have this .gitattributes

Ok, I've filed https://pagure.io/releng/fedora-scm-requests/issue/78319

Imported and built, thank you Remi !