Bug 2307257

Summary: Review Request: python-ndeflib - Python package for parsing and generating NFC Data Exchange Format messages.
Product: [Fedora] Fedora Reporter: Matthieu Saulnier <msaulnier>
Component: Package ReviewAssignee: Neel Chauhan <neel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: neel, package-review
Target Milestone: ---Flags: neel: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-08-25 16:10:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2307253    

Description Matthieu Saulnier 2024-08-22 11:31:58 UTC
Spec URL: https://fantom.fedorapeople.org/python-ndeflib.spec
SRPM URL: https://fantom.fedorapeople.org/python-ndeflib-0.3.3-1.fc39.src.rpm
Description: The ndeflib is an ISC-licensed Python package for parsing and
generating NFC Data Exchange Format (NDEF) messages.

NDEF (NFC Data Exchange Format), specified by the NFC Forum, is a
binary message format used to encapsulate application-defined payloads
exchanged between NFC Devices and Tags. Each payload is encoded as an
NDEF Record with fields that specify the payload size, payload type,
an optional payload identifier, and flags for indicating the first and
last record of an NDEF Message or tagging record chunks. An NDEF
Message is simply a sequence of one or more NDEF Records where the
first and last record are marked by the Message Begin and End flags.

Fedora Account System Username: fantom

Comment 1 Matthieu Saulnier 2024-08-22 11:36:03 UTC
Scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=122253120

Comment 2 Matthieu Saulnier 2024-08-22 11:39:16 UTC
In the spec file, the tests suite is disabled because some tests are failing.

A ticket has been opened for upstream: https://github.com/nfcpy/ndeflib/issues/10

Comment 3 Fedora Review Service 2024-08-22 12:44:08 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7934620
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307257-python-ndeflib/fedora-rawhide-x86_64/07934620-python-ndeflib/fedora-review/review.txt

Found issues:

- python3-pytest7 is deprecated, you must not depend on it.
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Neel Chauhan 2024-08-24 18:57:20 UTC
I'll take this for review.

Comment 5 Neel Chauhan 2024-08-24 19:01:31 UTC
LGTM, it's good.

Comment 6 Fedora Admin user for bugzilla script actions 2024-08-25 08:06:45 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-ndeflib

Comment 7 Fedora Update System 2024-08-25 16:07:21 UTC
FEDORA-2024-614f5adffc (python-ndeflib-0.3.3-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-614f5adffc

Comment 8 Fedora Update System 2024-08-25 16:10:25 UTC
FEDORA-2024-f1a96e16c2 (python-ndeflib-0.3.3-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-f1a96e16c2

Comment 9 Fedora Update System 2024-08-25 16:10:44 UTC
FEDORA-2024-614f5adffc (python-ndeflib-0.3.3-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2024-08-25 16:13:49 UTC
FEDORA-2024-f1a96e16c2 (python-ndeflib-0.3.3-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2024-08-25 16:48:01 UTC
FEDORA-2024-bd225df246 (python-ndeflib-0.3.3-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-bd225df246

Comment 12 Fedora Update System 2024-08-25 16:48:05 UTC
FEDORA-2024-8581ac3015 (python-ndeflib-0.3.3-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-8581ac3015

Comment 13 Fedora Update System 2024-08-26 02:23:50 UTC
FEDORA-2024-8581ac3015 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-8581ac3015 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-8581ac3015

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2024-08-26 02:28:29 UTC
FEDORA-2024-bd225df246 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-bd225df246 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-bd225df246

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2024-09-03 03:40:57 UTC
FEDORA-2024-8581ac3015 (python-ndeflib-0.3.3-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2024-09-03 05:50:01 UTC
FEDORA-2024-bd225df246 (python-ndeflib-0.3.3-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.