Bug 2307663

Spec URL: https://ankursinha.fedorapeople.org/reviews/rust-google-cloud-auth/rust-google-cloud-auth.spec
SRPM URL: https://ankursinha.fedorapeople.org/reviews/rust-google-cloud-auth/rust-google-cloud-auth-0.16.0-7.fc42.src.rpm

- fix: license listing typo

Spec URL: https://ankursinha.fedorapeople.org/reviews/rust-google-cloud-auth/rust-google-cloud-auth.spec
SRPM URL: https://ankursinha.fedorapeople.org/reviews/rust-google-cloud-auth/rust-google-cloud-auth-0.16.0-10.fc42.src.rpm

- fix: ignore failing tests

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7939813
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307663-rust-google-cloud-auth/fedora-rawhide-x86_64/07939813-rust-google-cloud-auth/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7939814
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307663-rust-google-cloud-auth/fedora-rawhide-x86_64/07939814-rust-google-cloud-auth/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Created attachment 2044735 [details]
The .spec file difference from Copr build 7939814 to 7939815

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7939815
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307663-rust-google-cloud-auth/fedora-rawhide-x86_64/07939815-rust-google-cloud-auth/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[fedora-review-service-build]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8027017
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307663-rust-google-cloud-auth/fedora-rawhide-x86_64/08027017-rust-google-cloud-auth/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package looks good to me, but this looks strange:

```
%cargo_test -- --lib -- --skip token_source::tests::test_oauth2_token_source --skip token_source::tests::test_jwt_token_source
%cargo_test -- --doc
%cargo_test -- --tests -- --skip token_source::tests::test_oauth2_token_source --skip token_source::tests::test_jwt_token_source
```

What are you trying to do here? It looks unnecessarily complicated.

I was debugging tests failures to see if there were any tests that were failing only in individual tests stages. I can replace this with this if it's better?

%cargo_test -- -- --skip token_source::tests::test_oauth2_token_source --skip token_source::tests::test_jwt_token_source

Yes, that's the usual way to handle this case.

But please document *why* you need to skip these tests.
Common reasons include

- they require internet access
- they require files that are not included in published .crate files

Spec URL: https://ankursinha.fedorapeople.org/reviews/rust-google-cloud-auth/rust-google-cloud-auth.spec
SRPM URL: https://ankursinha.fedorapeople.org/reviews/rust-google-cloud-auth/rust-google-cloud-auth-0.16.0-11.fc42.src.rpm

- feat: simplify tests, note why skipped (fixes rh#2307663)

Created attachment 2047257 [details]
The .spec file difference from Copr build 8027017 to 8027253

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8027253
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307663-rust-google-cloud-auth/fedora-rawhide-x86_64/08027253-rust-google-cloud-auth/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Hi Fabio,

I think this one is ready for another round of review. I've simplified the test command and added a comment as to why we skip a few.

Cheers,

Looks good to me. Just add a link to the upstream PR / issue about including the LICENSE file in published crates.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass (some skipped with justification)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
🫤 license file is included with %license in %files (temporarily manually included from upstream)
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-google-cloud-auth

Thank you for the review, Fabio, I'll add a link to the upstream ticket when I import.

FEDORA-2024-42a63eebd1 (rust-google-cloud-auth-0.16.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-42a63eebd1

FEDORA-2024-42a63eebd1 (rust-google-cloud-auth-0.16.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-6808aa7d23 (rust-google-cloud-auth-0.16.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6808aa7d23

FEDORA-2024-7af514aa92 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7af514aa92 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7af514aa92

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-7af514aa92 (rust-google-cloud-auth-0.17.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.