Bug 2307695
| Summary: | Review Request: aribb25 - Basic implementation of the ARIB STD-B25 public standard | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Simone Caronni <negativo17> |
| Component: | Package Review | Assignee: | Yaakov Selkowitz <yselkowi> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, yselkowi |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | yselkowi:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://www.videolan.org/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-10-12 00:19:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2218117 | ||
| Attachments: | |||
|
Description
Simone Caronni
2024-08-24 07:12:16 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7939921 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307695-aribb25/fedora-rawhide-x86_64/07939921-aribb25/fedora-review/review.txt Found issues: - /sbin/ldconfig called in aribb25 Read more: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets - Not a valid SPDX expression 'ISC Licence'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://slaanesh.fedorapeople.org/aribb25.spec SRPM URL: https://slaanesh.fedorapeople.org/aribb25-0.2.7-3.fc40.src.rpm Fixed license identifier. Created attachment 2045032 [details]
The .spec file difference from Copr build 7939921 to 7953283
Copr build: https://copr.fedorainfracloud.org/coprs/build/7953283 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307695-aribb25/fedora-rawhide-x86_64/07953283-aribb25/fedora-review/review.txt Found issues: - /sbin/ldconfig called in aribb25 Read more: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Changes needed: * Consider adding BuildRequires: autoconf automake libtool and running autoreconf -fiv * Missing BuildRequires: make * One spelling error in %description (the other is a false positive) * Remove the ldconfig scripts * Make %files more specific, and compliant with https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files Sorry for the late reply, have been swamped at work. Spec URL: https://slaanesh.fedorapeople.org/aribb25.spec SRPM URL: https://slaanesh.fedorapeople.org/aribb25-0.2.7-4.fc40.src.rpm I think I fixed all the issues. Haven't touched this package in a very long time. Thanks. Created attachment 2048775 [details]
The .spec file difference from Copr build 7953283 to 8072892
Copr build: https://copr.fedorainfracloud.org/coprs/build/8072892 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307695-aribb25/fedora-rawhide-x86_64/08072892-aribb25/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. There is still a misspelling in %description. https://code.videolan.org/videolan/aribb25 may make more sense as the URL. Note that revbumps are not needed for changes during review, since they haven't landed in koji yet. Looks good otherwise. Spec URL: https://slaanesh.fedorapeople.org/aribb25.spec SRPM URL: https://slaanesh.fedorapeople.org/aribb25-0.2.7-4.fc40.src.rpm Updated the URL, fixed the license (it was actually not correct, I think ISC came from an earlier version) and hopefully fixed the spelling error (had to check with a spellchecker). I'm leaving the revision as in my repository it's currently sitting at 3 and I want to just get rid of that copy with an update from the official Fedora rpeositories. Created attachment 2049116 [details]
The .spec file difference from Copr build 8072892 to 8083956
Copr build: https://copr.fedorainfracloud.org/coprs/build/8083956 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307695-aribb25/fedora-rawhide-x86_64/08083956-aribb25/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. ISC is the correct license; why do you think otherwise? Here reports BSD Zero Clause: https://code.videolan.org/videolan/aribb25 To be honest I can't tell which one is it by looking at the file: https://code.videolan.org/videolan/aribb25/-/blob/master/LICENCE?ref_type=heads First off, it says right there (and in all the source code that I noticed): "This software is released under the ISC Licence terms". But if you don't want to take their word for it, the difference between ISC and 0BSD can be seen with a careful comparison of their respective texts: https://spdx.org/licenses/0BSD.html https://spdx.org/licenses/ISC.html Specifically, ISC says "provided that the above copyright notice and this permission notice appear in all copies" where 0BSD does not. aribb25's license contains the clause, therefore it is ISC. licensecheck will return the same result. ok, thank you. Will change to ISC when importing. Please provide a spec and SRPM with all issues resolved for final review. Spec URL: https://slaanesh.fedorapeople.org/aribb25.spec SRPM URL: https://slaanesh.fedorapeople.org/aribb25-0.2.7-4.fc40.src.rpm Created attachment 2049831 [details]
The .spec file difference from Copr build 8083956 to 8096820
Copr build: https://copr.fedorainfracloud.org/coprs/build/8096820 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307695-aribb25/fedora-rawhide-x86_64/08096820-aribb25/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Thanks, APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/aribb25 FEDORA-2024-7ff4625351 (aribb25-0.2.7-4.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7ff4625351 FEDORA-EPEL-2024-f0c367c659 (aribb25-0.2.7-4.el8) has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-f0c367c659 FEDORA-EPEL-2024-08d3b4fc35 (aribb25-0.2.7-4.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-08d3b4fc35 FEDORA-2024-870e8fffa2 (aribb25-0.2.7-4.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-870e8fffa2 FEDORA-2024-849f323b16 (aribb25-0.2.7-4.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-849f323b16 FEDORA-2024-7ff4625351 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7ff4625351 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7ff4625351 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-849f323b16 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-849f323b16 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-849f323b16 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-f0c367c659 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-f0c367c659 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-08d3b4fc35 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-08d3b4fc35 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-870e8fffa2 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-870e8fffa2 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-870e8fffa2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-870e8fffa2 (aribb25-0.2.7-4.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-7ff4625351 (aribb25-0.2.7-4.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-849f323b16 (aribb25-0.2.7-4.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2024-f0c367c659 (aribb25-0.2.7-4.el8) has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2024-08d3b4fc35 (aribb25-0.2.7-4.el9) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. |