Bug 2307698

Summary: Review Request: openjph - Open-source implementation of JPEG2000 Part-15 (or JPH or HTJ2K)
Product: [Fedora] Fedora Reporter: Simone Caronni <negativo17>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: nerijus, ngompa13, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: ngompa13: fedora-review+
Hardware: All   
OS: Linux   
URL: https://openjph.org/
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-09-13 00:35:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Simone Caronni 2024-08-24 07:19:47 UTC
Spec URL: https://slaanesh.fedorapeople.org/openjph.spec
SRPM URL: https://slaanesh.fedorapeople.org/openjph-0.15.0-1.fc40.src.rpm
Description:
Open source implementation of High-throughput JPEG2000 (HTJ2K), also known as
JPH, JPEG2000 Part 15, ISO/IEC 15444-15, and ITU-T T.814. Here, we are
interested in implementing the HTJ2K only, supporting features that are defined
in JPEG2000 Part 1. For example, for wavelet transform, only reversible 5/3 and
irreversible 9/7 are supported.
Fedora Account System Username: slaanesh

Comment 1 Fedora Review Service 2024-08-24 07:26:43 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7939925
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307698-openjph/fedora-rawhide-x86_64/07939925-openjph/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2024-08-24 10:18:36 UTC
Review notes:

* Package follows Fedora packaging guidelines
* Package builds and installs
* No serious rpmlint issues

Note, I saw one typo that you should fix on import:

> Summary:        JPEG-2000 Parth-15 library

That "Parth" should be "Part".

Otherwise...

PACKAGE APPROVED.

Comment 3 Simone Caronni 2024-08-24 11:02:20 UTC
> That "Parth" should be "Part".

Fixed, thanks for the review!

Comment 4 Fedora Admin user for bugzilla script actions 2024-08-24 11:04:15 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/openjph

Comment 5 Fedora Update System 2024-08-25 07:52:17 UTC
FEDORA-EPEL-2024-267e5cb0ed (openjph-0.15.0-2.el9) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-267e5cb0ed

Comment 6 Fedora Update System 2024-08-25 07:52:17 UTC
FEDORA-EPEL-2024-065c8adc68 (openjph-0.15.0-2.el8) has been submitted as an update to Fedora EPEL 8.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-065c8adc68

Comment 7 Fedora Update System 2024-08-25 07:52:17 UTC
FEDORA-2024-1aa64448c9 (openjph-0.15.0-2.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-1aa64448c9

Comment 8 Fedora Update System 2024-08-26 02:15:39 UTC
FEDORA-EPEL-2024-267e5cb0ed has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-267e5cb0ed

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2024-08-26 02:22:30 UTC
FEDORA-EPEL-2024-065c8adc68 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-065c8adc68

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-08-26 02:23:28 UTC
FEDORA-2024-57240f07d9 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-57240f07d9 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-57240f07d9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-08-26 02:28:08 UTC
FEDORA-2024-1aa64448c9 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-1aa64448c9 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-1aa64448c9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-08-31 02:13:31 UTC
FEDORA-2024-1aa64448c9 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-1aa64448c9 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-1aa64448c9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-08-31 02:55:11 UTC
FEDORA-2024-57240f07d9 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-57240f07d9 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-57240f07d9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2024-08-31 03:17:18 UTC
FEDORA-EPEL-2024-065c8adc68 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-065c8adc68

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2024-08-31 03:17:37 UTC
FEDORA-EPEL-2024-267e5cb0ed has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-267e5cb0ed

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2024-09-05 00:23:47 UTC
FEDORA-EPEL-2024-267e5cb0ed has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-267e5cb0ed

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2024-09-05 01:49:02 UTC
FEDORA-2024-57240f07d9 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-57240f07d9 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-57240f07d9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2024-09-05 03:28:24 UTC
FEDORA-2024-1aa64448c9 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-1aa64448c9 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-1aa64448c9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 19 Fedora Update System 2024-09-05 04:17:24 UTC
FEDORA-EPEL-2024-065c8adc68 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-065c8adc68

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 20 Nerijus Baliūnas 2024-09-09 13:09:23 UTC
This package uses instructions supported by some newer cpus only. After installing it (I had libopenjph-0.15.0-1.fc40.x86_64 from fedora-multimedia repo before) telegram-desktop from rpmfusion-free-updates repo does not start with Illegal instruction (core dumped):
gdb telegram-desktop
(gdb) r
Thread 1 "telegram-deskto" received signal SIGILL, Illegal instruction.
(gdb) bt
#0  0x00007fffc645228b in _sub_I_65535_0.0 () at /lib64/libopenjph.so.0.15
#1  0x00007ffff7fcd437 in call_init (l=<optimized out>, argc=1, argv=0x7fffffffd8e8, env=0x7fffdaf24c80) at dl-init.c:74
#2  call_init (l=<optimized out>, argc=1, argv=0x7fffffffd8e8, env=0x7fffdaf24c80) at dl-init.c:26
#3  0x00007ffff7fcd52d in _dl_init (main_map=0x7fffa4554a00, argc=1, argv=0x7fffffffd8e8, env=0x7fffdaf24c80) at dl-init.c:121
#4  0x00007ffff7fc95c2 in __GI__dl_catch_exception (exception=exception@entry=0x0, operate=operate@entry=0x7ffff7fd4560 <call_dl_init>, args=args@entry=0x7fffffffbb60)
    at dl-catch.c:211
#5  0x00007ffff7fd44fc in dl_open_worker (a=a@entry=0x7fffffffbd10) at dl-open.c:829
#6  0x00007ffff7fc9523 in __GI__dl_catch_exception
    (exception=exception@entry=0x7fffffffbcf0, operate=operate@entry=0x7ffff7fd4460 <dl_open_worker>, args=args@entry=0x7fffffffbd10) at dl-catch.c:237
#7  0x00007ffff7fd4904 in _dl_open
    (file=0x7fffbbc64530 "/usr/lib64/libheif/libheif-jphenc.so", mode=<optimized out>, caller_dlopen=0x7fffc7dc27bd <PluginLibrary_Unix::load_from_file(char const*)+29>, nsid=<optimized out>, argc=1, argv=0x7fffffffd8e8, env=0x7fffdaf24c80) at dl-open.c:905
#8  0x00007ffff06a22b4 in dlopen_doit (a=a@entry=0x7fffffffbfc0) at dlopen.c:56
#9  0x00007ffff7fc9523 in __GI__dl_catch_exception (exception=exception@entry=0x7fffffffbf00, operate=0x7ffff06a2250 <dlopen_doit>, args=0x7fffffffbfc0) at dl-catch.c:237
#10 0x00007ffff7fc9679 in _dl_catch_error (objname=0x7fffffffbf68, errstring=0x7fffffffbf70, mallocedp=0x7fffffffbf67, operate=<optimized out>, args=<optimized out>)
    at dl-catch.c:256
#11 0x00007ffff06a1da3 in _dlerror_run (operate=operate@entry=0x7ffff06a2250 <dlopen_doit>, args=args@entry=0x7fffffffbfc0) at dlerror.c:138
#12 0x00007ffff06a236f in dlopen_implementation (file=<optimized out>, mode=<optimized out>, dl_caller=<optimized out>) at dlopen.c:71
#13 ___dlopen (file=<optimized out>, mode=<optimized out>) at dlopen.c:81
#14 0x00007fffc7dc27bd in PluginLibrary_Unix::load_from_file(char const*) () at /lib64/libheif.so.1

Downgrading back from libopenjph-0.15.0-6.fc40.x86_64 to libopenjph-0.15.0-1.fc40.x86_64 from fedora-multimedia repo makes telegram start again.

Comment 21 Nerijus Baliūnas 2024-09-09 15:07:06 UTC
I see there is already discussion happening in #2307795, I will continue there.

Comment 22 Nerijus Baliūnas 2024-09-10 17:49:12 UTC
After downgrading from libheif-1:1.18.2-2.fc40.x86_64 from fedora-multimedia to libheif-1.17.6-1.fc40.x86_64 from updates telegram starts OK. So libopenjph has no problems.

Comment 23 Fedora Update System 2024-09-13 00:35:58 UTC
FEDORA-EPEL-2024-267e5cb0ed (openjph-0.15.0-6.el9) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 24 Fedora Update System 2024-09-13 01:36:09 UTC
FEDORA-2024-57240f07d9 (openjph-0.15.0-6.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 25 Fedora Update System 2024-09-13 01:52:12 UTC
FEDORA-2024-1aa64448c9 (openjph-0.15.0-6.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 26 Fedora Update System 2024-09-13 03:05:37 UTC
FEDORA-EPEL-2024-065c8adc68 (openjph-0.15.0-6.el8) has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.