Bug 230802 (perl-Callback)

I need a sponsor.

MUSTFIX:
...
License:        CHECK(GPL or Artistic)
...

The license of this package isn't clear to me:

All I can find inside of the sources is this:

   Copyright (C) 1994, 2000, 2002 David Muir Sharnoff. All rights reserved.
    License hearby granted for anyone to use this module at their own risk.
    Please feed useful changes back to muir.

This is not the standard Perl "GPL or Artistic" license, but something
different. In particular, this only covers usage ("use"), but doesn't cover
"modification".

I'd suggest you to contact the author.

David Muir has updated the package.
The new license is as follows:

<snip>
COPYRIGHT
    Copyright (C) 1994, 2000, 2002 David Muir Sharnoff. All rights reserved.
    This module may be licensed on the same terms as Perl itself.
</snip>

The new spec file is at http://people.redhat.com/mkpai/.SPEC/perl-Callback.spec
The new srpm is at http://people.redhat.com/mkpai/.SRPM/perl-Callback-1.07-1.src.rpm

While cpanspec does an excellent job creating a base specfile, it still needs
some tweaks:

* the license tag should be corrected
* due to the impending perl/perl-devel split, you should buildrequires
perl(ExtUtils::MakeMaker)

Anything happening here?  It's a always a good idea to respond to reviewer
comments as quickly as possible, but it's especially important if you require
sponsorship.

Well, it's been more than another week.  I'll close this bug soon if there's no
further response.

I am terribly sorry for not updating this BZ earlier. This won't happen again.

I have made the suggested modifications to the spec file and created a new
source rpm. The revised files are at the available at the above locations.

A clarification is in order here.

The spec file is at http://people.redhat.com/mkpai/.SPEC/perl-Callback.spec 
The souce rpm is at
http://people.redhat.com/mkpai/.SRPM/perl-Callback-1.07-1.src.rpm .

Usually we use "GPL or Artistic" to indicate the regular license of Perl
modules.  Looking through my CVS tree, I don't see any using a slash as you've
done, but I suppose it's not really incorrect.

I think you should have a build requirement on perl(Storable), so that you'll
still get complete test coverage in case it gets split out of the main perl package.

Review:
* source files match upstream:
   8d430c74986862f4ea5e7121aaf40be72437fa2df5242c57671f35871a0d7a4d  
   Callback-1.07.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
? BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Callback) = 1.07
   perl-Callback = 1.07-1.fc8
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Exporter)
   perl(UNIVERSAL)
   perl(strict)
* %check is present and all tests pass:
   All tests successful.
   Files=4, Tests=19,  0 wallclock secs ( 0.09 cusr +  0.06 csys =  0.15 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

>I think you should have a build requirement on perl(Storable), so that you'll
>still get complete test coverage in case it gets split out of the main perl
>package.

I have changed the spec file as per this suggestion.

The spec file is at http://people.redhat.com/mkpai/.SPEC/perl-Callback.spec
The source rpm is http://people.redhat.com/mkpai/.SRPM/perl-Callback-1.07-1.src.rpm

OK, looks good to me.

APPROVED

Note that you're currently up to the "Get a Fedora Account" step of
http://fedoraproject.org/wiki/PackageMaintainers/Join

Ping?

I have joined PackageMaintainers
Thank you

I've already approved this package, so you're currently either at the "Install
the Build-System Client Tools" or maybe "Add Package to CVS and Set Owner" step
of http://fedoraproject.org/wiki/PackageMaintainers/Join

Hi Jason,

I am having some trouble with my privileges. I am working on it at the moment.

Thanks and regards,
-- Pai

New Package CVS Request
=======================
Package Name: perl-Callback
Short Description: Object interface for function callbacks
Owners: M.K.Pai, David Muir
Branches: FC-6 FC-7
InitialCC: muir

Can you resubmit your request with email addresses in the Owners: field?
Thats the format the cvs scripts expect. 

New Package CVS Request
=======================
Package Name: perl-Callback
Short Description: Object interface for function callbacks
Owners: mkpai,muir
Branches: FC-6 FC-7
InitialCC: 

Any reason this hasn't been built yet?

Hi Jason, 

I have successfully built the package for devel. But I have some problems with
the  FC-6 and F-7 branches. Its the same error. I have attached the session below.

[mkpai@mkpai FC-6]$ make upload FILES=Callback-1.07.tar.gz 

Checking : Callback-1.07.tar.gz on
https://cvs.fedoraproject.org/repo/pkgs/upload.cgi...
This file (270e8cde126409c45294886d34b17408  Callback-1.07.tar.gz) is already
uploaded

Source upload succeeded. Don't forget to commit the new ./sources file
M sources
M .cvsignore
[mkpai@mkpai FC-6]$ make upload FILES=perl-Callback.spec 

Checking : perl-Callback.spec on
https://cvs.fedoraproject.org/repo/pkgs/upload.cgi...
This file (74d114962ff13c080befd96c74a543b9  perl-Callback.spec) is already uploaded

Source upload succeeded. Don't forget to commit the new ./sources file
M sources
M .cvsignore
[mkpai@mkpai FC-6]$ cvs commit
cvs commit: Examining .
**** Access allowed: mkpai is in ACL for rpms/perl-Callback/FC-6.
Checking in .cvsignore;
/cvs/pkgs/rpms/perl-Callback/FC-6/.cvsignore,v  <--  .cvsignore
new revision: 1.2; previous revision: 1.1
done
Checking in sources;
/cvs/pkgs/rpms/perl-Callback/FC-6/sources,v  <--  sources
new revision: 1.2; previous revision: 1.1
done
Running syncmail...
Mailing cvsextras.com mkpai...
...syncmail done.
cvs diff: [11:47:33] waiting for mkpai's lock in /cvs/pkgs/rpms/perl-Callback/FC-6
Running syncmail...
Mailing relnotes...
...syncmail done.
cvs diff: [11:48:03] obtained lock in /cvs/pkgs/rpms/perl-Callback/FC-6
[mkpai@mkpai FC-6]$ make tag
cvs tag  -c perl-Callback-1_07-1_fc6
cvs tag: Tagging .
T .cvsignore
T Makefile
T branch
T sources
Tagged with: perl-Callback-1_07-1_fc6

[mkpai@mkpai FC-6]$ make build
perl-Callback.spec not tagged with tag perl-Callback-1_07-1_fc6
make: *** [build-check] Error 1

The error with the F-7 branch is the same. What should I do ?

Thanks for your patience,
-- Pai

It doesn't look to me like you've even imported your sources to the F-7 and FC-6
branches.  A checkout doesn't show spec files there.  How did you import your
package?

I followed the procedure at
http://fedoraproject.org/wiki/PackageMaintainers/NewPackageProcess
and successfully imported for the devel branch.

If I am required to do something else for FC-6 and F-7, please tell me what it
is. I will update the wiki accordingly.

Thanks,
-- Pai

Well, all you're required to do for the release branches is described in step 11
of that document; I see nothing incorrect there that would need to be updated.

I had omitted to cvs add the spec file after copying. That was the problem. The
packages have been built now.

Please let me know if I should now close this BZ.

Thanks a lot again.
-- Pai

You should close this ticket once the package is built and pushed to the repos.
 Bodhi will do this for you if you reference the ticket number when you create
the push request.

So it's been another month; this package is in rawhide and was built for but
never pushed to F7.  Do you need help getting your package released?  Or can you
close this ticket?

I am surprised this has not been pushed yet. I got the following mail from
updates on 30th July.

...

mkpai has submitted a new update for Fedora 7

================================================================================
  perl-Callback-1.07-1.fc7
================================================================================
    Release: Fedora 7
     Status: pending
       Type: bugfix
      Notes: Object interface for function callbacks
  Submitter: mkpai
  Submitted: 2007-07-30 05:58:33

The package has now been pushed to F7.  This ticket should be closed by the
submitter, but I see no reason why it should stay open and in the interests of
expediency and keeping my overly long open ticket list down I'll go ahead and
close this myself.