Bug 230812

A comment (well, I am currently reviewing more than 10 bugs,
so I hope someone else will review this report).

* hardcoded path 
  - The path of DEFAULT_CONFIG_FILE is hardcoded, which should be
    avoided generally.
  * If it cannot be avoided to use hardcoded path, so don't use
    %{_sysconfdir} and use hardcoded path in spec file to make
    them consistent
  * Generally, the method like
----------------------------------------------------------
%{__sed} -i.path -e '/DEFAULT_CONFIG_FILE/s|/usr/local/etc|%{_sysconfdir}||'
tcpxtract.c
----------------------------------------------------------
     is used to pass macro correctly.

* Timestamps
  - Keep timestamps on man file and conf file. Perhaps
----------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT install="%{_install} -c -p"
----------------------------------------------------------
    will do the trick.

... correct one is 
-e '/DEFAULT_CONFIG_FILE/s|/usr/local/etc|%{_sysconfdir}|'

Thank you for your comments, Mamoru

I hope you have noticed that exactly because of the hard coded path of
DEFAULT_CONFIG_FILE I have included a patch (in release -2). However, because
your method seems cleaner (will work even if sometime in the future the
sysconfdir is modified), I have removed the patch and used your method (release -3)
Since the man page is compressed during build, the timestamp of the file which
is included in the binary rpm will be the time of the rpm build, not the one of
the original man page, so no real reason for using "install -p" for it. However
I have added "install -p" for the sake of compliance with the general accepted
usage and for the config file.

New versions are available at
http://wdl.lug.ro/linux/rpms/tcpxtract/tcpxtract.spec
http://wdl.lug.ro/linux/rpms/tcpxtract/tcpxtract-1.0.1-3.src.rpm

> Since the man page is compressed during build, the timestamp of the
> file which is included in the binary rpm will be the time of the rpm
> build, not the one of the original man page, so no real reason for
> using "install -p" for it

Just for the record, this is not right if gzip is used correctly.
gzip does by default not change the timestamp on a file after it
is compressed.

$ LANG=C date
Sat Mar  3 23:44:52 CET 2007

$ ls -l foo
-rw-rw-r-- 1 ingvar ingvar 860866 feb 20 20:51 foo

$ gzip foo; ls -l foo.gz 
-rw-rw-r-- 1 ingvar ingvar 146748 feb 20 20:51 foo.gz

Ingvar

New version of spec and src.rpm uploaded at
http://wdl.lug.ro/linux/rpms/tcpxtract/tcpxtract.spec
http://wdl.lug.ro/linux/rpms/tcpxtract/tcpxtract-1.0.1-4.src.rpm

This time it really keeps the timestamps. A couple of errors were present in the
timestamp preservation part of the spec.

Well, for -4:

(Well, %{_install} was my typo, it should actually be
 %{__install}... sorry)

* macro
--------------------------------------
%configure --sysconfdir=/etc --prefix=/
--------------------------------------
  Perhaps this "sysconfdir" is used to direct where tcpxtract.conf
  is installed (according to "install-sysconfDATA" of Makefile.in)
  So this should be %configure --sysconfdir=%{_sysconfdir}
  as you use
-------------------------------------
%{__sed} -i.path -e '/DEFAULT_CONFIG_FILE/s#/usr/local/etc#%{_sysconfdir}#'
tcpxtract.c
-------------------------------------

  After this fix I will approve this package.

Goos catch, thank you Mamoru. Those were leftovers since the struggle to
convince make to place the config file in /etc, but before patching Makefile.
Removed.

New version available at 
http://wdl.lug.ro/linux/rpms/tcpxtract/tcpxtract.spec
http://wdl.lug.ro/linux/rpms/tcpxtract/tcpxtract-1.0.1-5.src.rpm

Okay.

-----------------------------------------------
  This package (tcpxtract) is APPROVED by me.
-----------------------------------------------

I've modified a bit the spec to make it build in EPEL-4 (conditional BR: .el4->
libpcap, anything else -> libpcap.devel).

The new version is available at 
http://wdl.lug.ro/linux/rpms/tcpxtract/tcpxtract.spec
http://wdl.lug.ro/linux/rpms/tcpxtract/tcpxtract-1.0.1-6.src.rpm

 New Package CVS Request
=======================
Package Name: tcpxtract
Short Description: tcpxtract is a tool for extracting files from network traffic
based on file signatures
Owners: wolfy
Branches: EPEL-4 FC-6
InitialCC: 

Branched

built.

thanks to Mamoru for review, thl, Gianlu and Xavier for the help in doing "yum
install brain"

closing.

Package Change Request
======================
Package Name: tcpxtract
New Branches: EL-5

cvs done.

Package Change Request
======================
Package Name: tcpxtract
New Branches: EPEL-7
Owners: wolfy
InitialCC: fab

Git done (by process-git-requests).

Corrected branch name.