Bug 230831

** Package should own %{_datadir}/desktop-directories directory since it will 
remain unowned if someone doesn't have gnome-menus nor kdebase installed

** rpmlint complains don't look important

** The much more important thing for me would be translating this package. In 
my opinion we should try to make translations as many as it's possible, because 
it doesn't look fine if I have some categories in Polish and the rest in 
English.

** Is there anything we shall do with URL tag? Maybe we could put your last 
fedora-games-list mail somewhere on the wiki and link to it, couldn't we?

(In reply to comment #1)
> ** Package should own %{_datadir}/desktop-directories directory since it will 
> remain unowned if someone doesn't have gnome-menus nor kdebase installed
> 

Good point, will fix.

> ** The much more important thing for me would be translating this package. In 
> my opinion we should try to make translations as many as it's possible, because 
> it doesn't look fine if I have some categories in Polish and the rest in 
> English.
> 

Agreed, feel free to send a patch with Polish translations, if all reading this
translate it into their native language, then others will have to follow over time.

> ** Is there anything we shall do with URL tag? Maybe we could put your last 
> fedora-games-list mail somewhere on the wiki and link to it, couldn't we?

Good idea, I could change the link to:
https://www.redhat.com/archives/fedora-games-list/2007-March/msg00003.html

For anyone interested in reviewing this, see:
https://www.redhat.com/archives/fedora-games-list/2007-March/msg00003.html

For a lot more info on this. So anyone interested in reviewing this?

Created attachment 149278 [details]
Polish translation patch

Polish translations of all untranslated categories.

(In reply to comment #3)
> For a lot more info on this. So anyone interested in reviewing this?
> 

I'm interested in reviewing if you fix things I mentioned above. Also I think 
that we can get rid of rpmlint no-documentation warning by including https://
www.redhat.com/archives/fedora-games-list/2007-March/msg00003.html as a README.

Is there a plan to get this integrated into the gnome-menus (redhat-menus?)
and/or kde-menus(?) packages?  In the long term that seems like the right place
to put these menus.

(In reply to comment #5)
> (In reply to comment #3)
> > For a lot more info on this. So anyone interested in reviewing this?
> > 
> 
> I'm interested in reviewing if you fix things I mentioned above. Also I think 
> that we can get rid of rpmlint no-documentation warning by including https://
> www.redhat.com/archives/fedora-games-list/2007-March/msg00003.html as a README.

Okay, I usually wait for a complete review (which most of the times turns up
more things to fix) and then fix everything in one go, but if you want a fixed
version first let me know and I'll create a version with the things mentioned
sofar fixed.

(In reply to comment #6)
> Is there a plan to get this integrated into the gnome-menus (redhat-menus?)
> and/or kde-menus(?) packages?  In the long term that seems like the right place
> to put these menus.

Well for people who do not install a gazillion games this isn't needed, and I
foresee huge resistance to making this a standard part of xxx-menus . So I'm not
going todo that, but if someone else wants to try I won't stop him :)

What about following this article for translations? Wouldn't it be easier to
maintain?

http://www.redhat.com/magazine/013nov05/features/freedesktop/

I hope it is still actual though.

Andrea.

The idea of translating .desktop files like this, is that you can then generate
one .po(t) file for your entire application, so for both translation of strings
in c-code and in other places. So that the translaters have a single po file to
work with.

Since all we have is a few .directory files I think this is overkill, just
straight editing is way easier IMHO.

Created attachment 149339 [details]
Italian translation

Here there is the Italian translation for the menus.

Andrea.

REVIEW
** Tarball contains license text so include it into package

** Package should require hicolor-icon-theme or own %{_datadir}/icons/hicolor

** rpmlint louds:
W: games-menus no-documentation
W: games-menus non-conffile-in-etc /etc/xdg/menus/applications-merged/games-
categories.menu

Apart from COPYING, you can also include one of your last fedora-games-list 
mails as a README (but only a license is MUST)
We can safely omit the second warning.

And the things I've written about before. Change URL tag, own %{_datadir}/
desktop-directories etc.
Also, if "sources" aren't available anywhere, add a comment that we're an 
upstream to clarify things.

All fixed, thanks for the translations!

Spec URL: http://people.atrpms.net/~hdegoede/games-menus.spec
SRPM URL: http://people.atrpms.net/~hdegoede/games-menus-0.2-1.fc7.src.rpm

Everything looks fine for me. Approved.

New Package CVS Request
=======================
Package Name:      games-menus
Short Description: Catagorized submenus for the GNOME/KDE Games menu
Owners:            j.w.r.degoede
Branches:          FC-6 devel
InitialCC:         <empty>

Thanks for the review!

Imported and build, closing.