Bug 2308329 (python-optking)

I'll review it

* The package cannot be built in Rawhide due to broken dependencies of psi4.
* The package does not pass the tests in Fedora 40 (python segfault).
* Missing BuildRequires - python3-pytest, python3-pint, psi4. Please add them.
* License field should be in SPDX format which is "BSD-3-Clause".

https://jussilehtola.fedorapeople.org/python-optking.spec
https://jussilehtola.fedorapeople.org/python-optking-0.3.0-1.fc40.src.rpm

Thanks for the review, Peter!
I've added the build deps and fixed the license field.

I've also filed a bug ticket for the segfault
https://github.com/psi-rking/optking/issues/101

but it looks to me that it is caused by a crash in the four-year old release of Psi4.

This package therefore needs to be treated as a bootstrap: python-optking needs to be included in the distro without tests so that I can update Psi4 so that I can get the python-optking tests to pass. I have commented out the test related lines. Once python-optking is in Fedora and I've successfully built psi4-1.9.2-1, I will enable the tests of python-optking. These circular dependencies are really annoying...

One small and almost cosmetic thing. You may drop all Requires - they are picked up automatically. 

OK, I don't see any other issues so here is my formal

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license (BSD-3-Clause).
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: The package does not contain desktop file (not a GUI application).
[-]: No development files.
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: The package is not a rename of another package.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package does not contain systemd file(s).
[x]: Package is not known to require an ExcludeArch tag.
[-]: No large documentation files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Binary eggs must be removed in %prep
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: I did not test if the pPackage functions as described.
[x]: Latest version is packaged (0.3.0).
[x]: Package does not include license text files separate from upstream.
[-]: Sources weren't verified with gpgverify since upstream does not publish
     signatures.
[?]: I did not test if the package compiles and builds into binary rpms on
     all supported architectures. Noarch package anyway.
[!]: %check is not present (see Susi's explanation above).
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: python3-optking-0.3.0-2.fc40.noarch.rpm
          python-optking-0.3.0-2.fc40.src.rpm
========================================================================================================================================= rpmlint session starts ========================================================================================================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpx79mjxui')]
checks: 32, packages: 2

python-optking.src: E: spelling-error ('pyoptking', '%description -l en_US pyoptking -> politicking')
python3-optking.noarch: E: spelling-error ('pyoptking', '%description -l en_US pyoptking -> politicking')
==================================================================================================== 2 packages and 0 specfiles checked; 2 errors, 0 warnings, 7 filtered, 2 badness; has taken 2.4 s ===================================================================================================


^^^ False positives.


Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-optking.noarch: E: spelling-error ('pyoptking', '%description -l en_US pyoptking -> politicking')
 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 3 filtered, 1 badness; has taken 1.0 s 


^^^ False positives.


Source checksums
----------------
https://github.com/psi-rking/optking/archive/0.3.0/python-optking-0.3.0.tar.gz :
  CHECKSUM(SHA256) this package     : 05aa6079f4cebef9fbe8cc36c7315123afeb53fb3feed959f98d963060e1085c
  CHECKSUM(SHA256) upstream package : 05aa6079f4cebef9fbe8cc36c7315123afeb53fb3feed959f98d963060e1085c


Requires
--------
python3-optking (rpmlib, GLIBC filtered):
    python(abi)
    python3-msgpack
    python3-numpy
    python3-qcelemental
    python3-qcengine
    python3.12dist(msgpack)
    python3.12dist(numpy)
    python3.12dist(qcelemental)
    python3.12dist(qcengine)


Provides
--------
python3-optking:
    python-optking
    python3-optking
    python3.12-optking
    python3.12dist(optking)
    python3dist(optking)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review --mock-config fedora-40-x86_64 --rpm-spec -n /home/petro/rpmbuild/SRPMS/python-optking-0.3.0-2.fc40.src.rpm
Buildroot used: fedora-40-x86_64
Active plugins: Shell-api, Python, Generic
Disabled plugins: Java, PHP, Ocaml, Perl, C/C++, Haskell, fonts, SugarActivity, R
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

This package is

================
=== APPROVED ===
================

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-optking

FEDORA-2024-9f44daba88 (python-optking-0.3.0-3.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-9f44daba88

FEDORA-2024-9f44daba88 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9f44daba88 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9f44daba88

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-9f44daba88 (python-optking-0.3.0-3.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.