Bug 2309263

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=122848018

Note: this is just sommelier for now, though other tools from the chromiumos platform could be added down the road.

Taking this review.

I've also just updated https://bugzilla.redhat.com/show_bug.cgi?id=2255751 for perfetto, which is needed to enable the tracing stuff.

Initial spec review:

> Version:        0^%{date}git%{shortcommit}

This should be a tilde instead of a carat as there is no tagged version so it's technically even a pre-release of v0

> %if %{with check}
> BuildRequires:  gmock-devel
> BuildRequires:  gtest-devel
> %endif
> BuildRequires:  libdrm-devel
> BuildRequires:  libevdev-devel
> BuildRequires:  libxcb-devel
> BuildRequires:  libxkbcommon-devel
> BuildRequires:  mesa-libgbm-devel
> BuildRequires:  pixman-devel
> BuildRequires:  protobuf-devel
> BuildRequires:  wayland-devel

It looks like from the meson files that it uses pkgconfig references for these, so please convert these to "pkgconfig()" dependencies accordingly.

> %build
> pushd vm_tools/sommelier
> %meson \
>   -Dgamepad=true \
>   -Dquirks=true \
> %if %{with tracing}
>   -Dtracing=true \
> %endif
> %if %{without check}
>   -Dwith_tests=false \
> %endif
>   %{nil}
> %meson_build
> 
> %install
> pushd vm_tools/sommelier
> %meson_install
> 
> %if %{with check}
> %check
> pushd vm_tools/sommelier
> %meson_test
> %endif

It looks like you're missing "popd" for each of these "pushd" stanzas.

(In reply to Davide Cavalca from comment #4)
> I've also just updated https://bugzilla.redhat.com/show_bug.cgi?id=2255751
> for perfetto, which is needed to enable the tracing stuff.


You are also missing a conditional dependency for perfetto in the spec.

Spec URL: https://dcavalca.fedorapeople.org/review/chromiumos-platform/chromiumos-platform.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/chromiumos-platform/chromiumos-platform-0~20240902git67bc17e-1.fc42.src.rpm

Changelog:
- fix version
- use pkgconfig for BRs
- add missing popd
- add conditional dep on perfetto

Review notes:

* Package follows packaging guidelines
* Package builds and installs
* Package licensing is correct
* No serious issues from rpmlint

PACKAGE APPROVED.

The Pagure repository was created at https://src.fedoraproject.org/rpms/chromiumos-platform

FEDORA-2024-31eb186400 (chromiumos-platform-0~20240902git67bc17e-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-31eb186400

FEDORA-2024-31eb186400 (chromiumos-platform-0~20240902git67bc17e-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-5fbb8ccaca (chromiumos-platform-0~20240902git67bc17e-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-5fbb8ccaca

FEDORA-2024-0bdd8c11fe (chromiumos-platform-0~20240902git67bc17e-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0bdd8c11fe

FEDORA-2024-6621d0bb3d (chromiumos-platform-0~20240902git67bc17e-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6621d0bb3d

FEDORA-2024-6621d0bb3d (chromiumos-platform-0~20240902git67bc17e-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-5fbb8ccaca has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-5fbb8ccaca \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-5fbb8ccaca

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-0bdd8c11fe (chromiumos-platform-0~20240902git67bc17e-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.