Bug 2309566

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7975446
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2309566-swaynotificationcenter/fedora-rawhide-x86_64/07975446-SwayNotificationCenter/fedora-review/review.txt

Found issues:

- Systemd user unit service file(s) in SwayNotificationCenter
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- systemd_user_post is invoked in %post and systemd_user_preun in %preun
  for Systemd user units service files.
  Note: Systemd user unit service file(s) in SwayNotificationCenter
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Scriptlets/#_user_units


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* GNU General Public
     License, Version 3". 87 files have unknown license. Detailed output of
     licensecheck in /tmp/2309566-SwayNotificationCenter/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
     Note: No known owner of /etc/xdg/swaync
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/dbus-1/services,
     /etc/xdg/swaync, /usr/share/dbus-1
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 12122 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     SwayNotificationCenter-bash-completion , SwayNotificationCenter-zsh-
     completion , SwayNotificationCenter-fish-completion
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: SwayNotificationCenter-0.10.1-1.fc42.aarch64.rpm
          SwayNotificationCenter-bash-completion-0.10.1-1.fc42.noarch.rpm
          SwayNotificationCenter-zsh-completion-0.10.1-1.fc42.noarch.rpm
          SwayNotificationCenter-fish-completion-0.10.1-1.fc42.noarch.rpm
          SwayNotificationCenter-debuginfo-0.10.1-1.fc42.aarch64.rpm
          SwayNotificationCenter-debugsource-0.10.1-1.fc42.aarch64.rpm
          SwayNotificationCenter-0.10.1-1.fc42.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmphhi5ntyr')]
checks: 32, packages: 7

SwayNotificationCenter.spec:34: W: unversioned-explicit-provides desktop-notification-daemon
SwayNotificationCenter-bash-completion.noarch: W: no-documentation
SwayNotificationCenter-fish-completion.noarch: W: no-documentation
SwayNotificationCenter-zsh-completion.noarch: W: no-documentation
SwayNotificationCenter.aarch64: E: explicit-lib-dependency libnotify
 7 packages and 0 specfiles checked; 1 errors, 4 warnings, 35 filtered, 1 badness; has taken 0.9 s 




Rpmlint (debuginfo)
-------------------
Checking: SwayNotificationCenter-debuginfo-0.10.1-1.fc42.aarch64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmppwb6uck3')]
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 11 filtered, 0 badness; has taken 0.2 s 





Rpmlint (installed packages)
----------------------------
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 6

SwayNotificationCenter-bash-completion.noarch: W: no-documentation
SwayNotificationCenter-fish-completion.noarch: W: no-documentation
SwayNotificationCenter-zsh-completion.noarch: W: no-documentation
SwayNotificationCenter.aarch64: E: explicit-lib-dependency libnotify
 6 packages and 0 specfiles checked; 1 errors, 3 warnings, 33 filtered, 1 badness; has taken 0.9 s 



Source checksums
----------------
https://github.com/ErikReider/SwayNotificationCenter/archive/v0.10.1/SwayNotificationCenter-0.10.1.tar.gz :
  CHECKSUM(SHA256) this package     : 5586d8a679dde5e530cb8b6f0c86abdd0d5e41362fc1c4e56e2211edea0f7a13
  CHECKSUM(SHA256) upstream package : 5586d8a679dde5e530cb8b6f0c86abdd0d5e41362fc1c4e56e2211edea0f7a13


Requires
--------
SwayNotificationCenter (rpmlib, GLIBC filtered):
    /bin/sh
    config(SwayNotificationCenter)
    dbus
    gvfs
    ld-linux-aarch64.so.1()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libgdk-3.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgee-0.8.so.2()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgranite.so.6()(64bit)
    libgtk-3.so.0()(64bit)
    libgtk-layer-shell.so.0()(64bit)
    libhandy-1.so.0()(64bit)
    libhandy-1.so.0(LIBHANDY_1_0)(64bit)
    libjson-glib-1.0.so.0()(64bit)
    libjson-glib-1.0.so.0(libjson-glib-1.0.so.0)(64bit)
    libm.so.6()(64bit)
    libnotify
    libpango-1.0.so.0()(64bit)
    libpulse-mainloop-glib.so.0()(64bit)
    libpulse-mainloop-glib.so.0(PULSE_0)(64bit)
    libpulse.so.0()(64bit)
    libpulse.so.0(PULSE_0)(64bit)
    rtld(GNU_HASH)

SwayNotificationCenter-bash-completion (rpmlib, GLIBC filtered):
    SwayNotificationCenter
    bash-completion

SwayNotificationCenter-zsh-completion (rpmlib, GLIBC filtered):
    SwayNotificationCenter
    zsh

SwayNotificationCenter-fish-completion (rpmlib, GLIBC filtered):
    SwayNotificationCenter
    fish

SwayNotificationCenter-debuginfo (rpmlib, GLIBC filtered):

SwayNotificationCenter-debugsource (rpmlib, GLIBC filtered):



Provides
--------
SwayNotificationCenter:
    SwayNotificationCenter
    SwayNotificationCenter(aarch-64)
    config(SwayNotificationCenter)
    desktop-notification-daemon
    sway-notification-center
    swaync

SwayNotificationCenter-bash-completion:
    SwayNotificationCenter-bash-completion
    swaync-bash-completion

SwayNotificationCenter-zsh-completion:
    SwayNotificationCenter-zsh-completion
    swaync-zsh-completion

SwayNotificationCenter-fish-completion:
    SwayNotificationCenter-fish-completion
    swaync-fish-completion

SwayNotificationCenter-debuginfo:
    SwayNotificationCenter-debuginfo
    SwayNotificationCenter-debuginfo(aarch-64)
    debuginfo(build-id)

SwayNotificationCenter-debugsource:
    SwayNotificationCenter-debugsource
    SwayNotificationCenter-debugsource(aarch-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2309566
Buildroot used: fedora-rawhide-aarch64
Active plugins: Generic, Shell-api
Disabled plugins: R, C/C++, Python, Java, fonts, SugarActivity, PHP, Ocaml, Perl, Haskell
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

[!]: Package requires other packages for directories it uses.
     Note: No known owner of /etc/xdg/swaync
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/dbus-1/services,
     /etc/xdg/swaync, /usr/share/dbus-1

You're missing Requires for these directories

- systemd_user_post is invoked in %post and systemd_user_preun in %preun
  for Systemd user units service files.
  Note: Systemd user unit service file(s) in SwayNotificationCenter
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Scriptlets/#_user_units

Not entirely sure what this is about but the systemd stuff lgtm

(In reply to Davide Cavalca from comment #3)
> [!]: Package requires other packages for directories it uses.
>      Note: No known owner of /etc/xdg/swaync
> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/share/dbus-1/services,
>      /etc/xdg/swaync, /usr/share/dbus-1
> 
> You're missing Requires for these directories
> 

Fixed these in place.

> - systemd_user_post is invoked in %post and systemd_user_preun in %preun
>   for Systemd user units service files.
>   Note: Systemd user unit service file(s) in SwayNotificationCenter
>   See: https://docs.fedoraproject.org/en-US/packaging-
>   guidelines/Scriptlets/#_user_units
> 
> Not entirely sure what this is about but the systemd stuff lgtm

Yeah, I dunno. I'm just going to ignore this since it's fine.

Approved, thanks!

The Pagure repository was created at https://src.fedoraproject.org/rpms/SwayNotificationCenter