Bug 2309684 (betterfetch)

Here is the finished RPM: https://github.com/sctech-tr/betterfetch/releases/download/1.5/betterfetch-1.5-1.fc40.noarch.rpm
Also, this is my package and I need a sponsor. Thanks!

betterfetch updated to 1.7. 
SRPM URL: https://raw.githubusercontent.com/sctech-tr/betterfetch/main/betterfetch-1.7-1.fc40.src.rpm
Spec URL: https://raw.githubusercontent.com/sctech-tr/betterfetch/main/betterfetch.spec
Description: betterfetch is a fetch script used to quickly show system information in terminal. it's a fork of zfetch (https://github.com/emilydaemon/zfetch)
Fedora Account System Username: sctech
Finished RPM: https://github.com/sctech-tr/betterfetch/releases/download/1.7/betterfetch-1.7-1.fc40.noarch.rpm

> Source0:        %{name}-%{version}.tar.gz
This should be a downloadable URL. Since the project is hosted on GitHub, you can use:
> URL:            https://github.com/sctech-tr/betterfetch
> Source0:        %{URL}/archive/v%{version}/%{name}-%{version}.tar.gz
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

> %files
> /usr/bin/betterfetch
> /usr/bin/betterfetchrc
> /etc/betterfetchrc
> /etc/betterfetch-version
Don't hardcode these paths. Replace /usr/bin with the %{_bindir} macro
and /etc/ with the %{_sysconfdir} macro.
This should be done in both the %files and %install sections.
https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#macros_installation

Also, please include the license text.
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

I'll have a look at them tomorrow, thanks for pointing out!

I think I corrected them. (I also uploaded it to COPR)
SRPM URL: https://raw.githubusercontent.com/sctech-tr/betterfetch/main/betterfetch-1.8-1.fc40.src.rpm
Spec URL: https://raw.githubusercontent.com/sctech-tr/betterfetch/main/betterfetch.spec
Description: betterfetch is a fetch script used to quickly show system information in terminal. it's a fork of zfetch (https://github.com/emilydaemon/zfetch)
Fedora Account System Username: sctech
Finished RPM: https://github.com/sctech-tr/betterfetch/releases/download/1.8/betterfetch-1.8-1.fc40.noarch.rpm

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Hello,
I do realize that this is possibly an old ticket. I am sorry that it hasn't been
reviewed yet. Let me trigger the Fedora Review Service to see if the package
builds successfully. Hopefully, a green check mark will attract some reviewer.

If I am resurrecting an old ticket that you are not interested in anymore, my
apologies, feel free to close it.

[fedora-review-service-build]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9819691
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2309684-betterfetch/fedora-rawhide-x86_64/09819691-betterfetch/fedora-review/review.txt

Found issues:

- Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/betterfetch/diff.txt
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.