Bug 2309684 (betterfetch)

Summary: Review Request: betterfetch - A simple fetch script that gets the system info quickly
Product: [Fedora] Fedora Reporter: gq2ic3wbe
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: NEW --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: fedora, gq2ic3wbe, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description gq2ic3wbe 2024-09-04 11:02:31 UTC
Spec URL: https://raw.githubusercontent.com/sctech-tr/betterfetch/main/betterfetch.spec
SRPM URL: https://raw.githubusercontent.com/sctech-tr/betterfetch/main/betterfetch-1.5-1.fc40.src.rpm
Description: betterfetch is a fetch script used to quickly show system information in terminal. it's a fork of zfetch (https://github.com/emilydaemon/zfetch)
Fedora Account System Username: sctech

Comment 1 gq2ic3wbe 2024-09-04 11:06:16 UTC
Here is the finished RPM: https://github.com/sctech-tr/betterfetch/releases/download/1.5/betterfetch-1.5-1.fc40.noarch.rpm
Also, this is my package and I need a sponsor. Thanks!

Comment 2 gq2ic3wbe 2024-09-07 09:12:41 UTC
betterfetch updated to 1.7. 
SRPM URL: https://raw.githubusercontent.com/sctech-tr/betterfetch/main/betterfetch-1.7-1.fc40.src.rpm
Spec URL: https://raw.githubusercontent.com/sctech-tr/betterfetch/main/betterfetch.spec
Description: betterfetch is a fetch script used to quickly show system information in terminal. it's a fork of zfetch (https://github.com/emilydaemon/zfetch)
Fedora Account System Username: sctech
Finished RPM: https://github.com/sctech-tr/betterfetch/releases/download/1.7/betterfetch-1.7-1.fc40.noarch.rpm

Comment 3 Artur Frenszek-Iwicki 2024-09-12 17:15:50 UTC
> Source0:        %{name}-%{version}.tar.gz
This should be a downloadable URL. Since the project is hosted on GitHub, you can use:
> URL:            https://github.com/sctech-tr/betterfetch
> Source0:        %{URL}/archive/v%{version}/%{name}-%{version}.tar.gz
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

> %files
> /usr/bin/betterfetch
> /usr/bin/betterfetchrc
> /etc/betterfetchrc
> /etc/betterfetch-version
Don't hardcode these paths. Replace /usr/bin with the %{_bindir} macro
and /etc/ with the %{_sysconfdir} macro.
This should be done in both the %files and %install sections.
https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#macros_installation

Also, please include the license text.
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

Comment 4 gq2ic3wbe 2024-09-12 18:32:31 UTC
I'll have a look at them tomorrow, thanks for pointing out!

Comment 5 gq2ic3wbe 2024-09-13 17:39:02 UTC
I think I corrected them. (I also uploaded it to COPR)
SRPM URL: https://raw.githubusercontent.com/sctech-tr/betterfetch/main/betterfetch-1.8-1.fc40.src.rpm
Spec URL: https://raw.githubusercontent.com/sctech-tr/betterfetch/main/betterfetch.spec
Description: betterfetch is a fetch script used to quickly show system information in terminal. it's a fork of zfetch (https://github.com/emilydaemon/zfetch)
Fedora Account System Username: sctech
Finished RPM: https://github.com/sctech-tr/betterfetch/releases/download/1.8/betterfetch-1.8-1.fc40.noarch.rpm