Bug 2311786

Summary: Review Request: rust-krata-tokio-tar - Rust implementation of an async TAR file reader and writer
Product: [Fedora] Fedora Reporter: Ben Beasley <code>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-09-11 20:08:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2311362    

Description Ben Beasley 2024-09-11 19:11:20 UTC
Spec URL: https://music.fedorapeople.org/rust-krata-tokio-tar.spec
SRPM URL: https://music.fedorapeople.org/rust-krata-tokio-tar-0.4.2-1.fc40.src.rpm

Description:

A Rust implementation of an async TAR file reader and writer. This
library does not currently handle compression, but it is abstract over
all I/O readers and writers. Additionally, great lengths are taken to
ensure that the entire contents are never required to be entirely
resident in memory all at once.

Fedora Account System Username: music

This is a maintained fork of rust-tokio-tar; see bug 2281965.

The uv project switched from tokio-tar to krata-tokio-tar in release 0.4.9; see https://github.com/astral-sh/uv/issues/3423 and https://github.com/astral-sh/uv/pull/7271.

Since only uv uses rust-tokio-tar, I will orphan that package once all branches have uv 0.4.9 or later, built with rust-krata-tokio-tar.

Regarding the skipped flaky tests, there might still be some occasional flaky tests, but I was able to get ten successful scratch builds, so they’re relatively rare.

Comment 1 Fabio Valentini 2024-09-11 19:26:03 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass (some tests skipped with explanation)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 2 Ben Beasley 2024-09-11 19:34:24 UTC
Thank you for the review!

https://release-monitoring.org/project/374345/

Comment 3 Fedora Admin user for bugzilla script actions 2024-09-11 19:35:29 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-krata-tokio-tar

Comment 4 Fedora Update System 2024-09-11 20:04:59 UTC
FEDORA-2024-fd5cdd990a (rust-krata-tokio-tar-0.4.2-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-fd5cdd990a

Comment 5 Fedora Update System 2024-09-11 20:08:46 UTC
FEDORA-2024-fd5cdd990a (rust-krata-tokio-tar-0.4.2-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2024-09-13 15:10:49 UTC
FEDORA-2024-986c837cb5 (rust-krata-tokio-tar-0.4.2-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-986c837cb5

Comment 7 Fedora Update System 2024-09-13 15:34:49 UTC
FEDORA-2024-105c726395 (rust-krata-tokio-tar-0.4.2-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-105c726395

Comment 8 Fedora Update System 2024-09-14 01:41:21 UTC
FEDORA-2024-105c726395 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-105c726395 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-105c726395

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2024-09-14 03:16:39 UTC
FEDORA-2024-986c837cb5 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-986c837cb5 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-986c837cb5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-09-19 02:23:09 UTC
FEDORA-2024-986c837cb5 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-986c837cb5`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-986c837cb5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-09-19 03:05:57 UTC
FEDORA-2024-105c726395 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-105c726395`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-105c726395

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-09-27 01:28:18 UTC
FEDORA-2024-986c837cb5 (rust-krata-tokio-tar-0.4.2-1.fc40 and uv-0.4.10-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2024-09-27 01:42:31 UTC
FEDORA-2024-105c726395 (rust-krata-tokio-tar-0.4.2-1.fc39 and uv-0.4.10-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.