Bug 2311958

Summary: Review Request: rust-yoke-derive - Custom derive for the yoke crate
Product: [Fedora] Fedora Reporter: Ben Beasley <code>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: decathorpe: fedora-review+
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/yoke-derive
Whiteboard: Trivial
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-09-13 14:14:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2311985    
Attachments:
Description Flags
Configuration file for rust2rpm
none
Configuration file for rust2rpm none

Description Ben Beasley 2024-09-12 15:21:08 UTC
Spec URL: https://music.fedorapeople.org/rust-yoke-derive.spec
SRPM URL: https://music.fedorapeople.org/rust-yoke-derive-0.7.4-1.fc40.src.rpm
Description: Custom derive for the yoke crate.
Fedora Account System Username: music

Yet another crate in the ICU4X stack, needed for idna 1.x.

Comment 1 Ben Beasley 2024-09-12 15:22:17 UTC
Created attachment 2046580 [details]
Configuration file for rust2rpm

Removes examples that would create circular dependencies on rust-yoke.

Comment 2 Ben Beasley 2024-09-12 15:23:21 UTC
Created attachment 2046581 [details]
Configuration file for rust2rpm

Removes examples that would create circular dependencies on rust-yoke.

Comment 3 Fedora Review Service 2024-09-12 15:27:05 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8014842
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2311958-rust-yoke-derive/fedora-rawhide-x86_64/08014842-rust-yoke-derive/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fabio Valentini 2024-09-12 22:28:54 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Ben Beasley 2024-09-13 13:54:40 UTC
Thank you for the review!

https://release-monitoring.org/project/374401/

Comment 6 Fedora Admin user for bugzilla script actions 2024-09-13 13:55:11 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-yoke-derive

Comment 7 Fedora Update System 2024-09-13 14:11:27 UTC
FEDORA-2024-7c338bfa83 (rust-yoke-derive-0.7.4-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-7c338bfa83

Comment 8 Fedora Update System 2024-09-13 14:14:46 UTC
FEDORA-2024-7c338bfa83 (rust-yoke-derive-0.7.4-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2024-09-13 15:18:32 UTC
FEDORA-2024-4cc51272bd (rust-utf8_iter-1.0.4-1.fc39, rust-yoke-derive-0.7.4-1.fc39, and 3 more) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-4cc51272bd

Comment 10 Fedora Update System 2024-09-13 15:18:34 UTC
FEDORA-2024-740e57ad2d (rust-utf8_iter-1.0.4-1.fc40, rust-yoke-derive-0.7.4-1.fc40, and 3 more) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-740e57ad2d

Comment 11 Fedora Update System 2024-09-13 15:18:37 UTC
FEDORA-2024-04ddf212c0 (rust-utf8_iter-1.0.4-1.fc41, rust-yoke-derive-0.7.4-1.fc41, and 3 more) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-04ddf212c0

Comment 12 Fedora Update System 2024-09-13 15:36:23 UTC
FEDORA-EPEL-2024-7f67248787 (rust-utf8_iter-1.0.4-1.el9, rust-yoke-derive-0.7.4-1.el9, and 3 more) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-7f67248787

Comment 13 Fedora Update System 2024-09-14 01:41:15 UTC
FEDORA-2024-4cc51272bd has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4cc51272bd \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4cc51272bd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2024-09-14 02:29:24 UTC
FEDORA-2024-04ddf212c0 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-04ddf212c0 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-04ddf212c0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2024-09-14 02:40:03 UTC
FEDORA-EPEL-2024-7f67248787 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-7f67248787

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2024-09-14 03:16:32 UTC
FEDORA-2024-740e57ad2d has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-740e57ad2d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-740e57ad2d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2024-09-22 00:15:15 UTC
FEDORA-2024-04ddf212c0 (rust-utf8_iter-1.0.4-1.fc41, rust-yoke-derive-0.7.4-1.fc41, and 3 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2024-09-22 00:45:42 UTC
FEDORA-EPEL-2024-7f67248787 (rust-utf8_iter-1.0.4-1.el9, rust-yoke-derive-0.7.4-1.el9, and 3 more) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2024-09-22 02:03:43 UTC
FEDORA-2024-4cc51272bd (rust-utf8_iter-1.0.4-1.fc39, rust-yoke-derive-0.7.4-1.fc39, and 3 more) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 20 Fedora Update System 2024-09-22 02:21:22 UTC
FEDORA-2024-740e57ad2d (rust-utf8_iter-1.0.4-1.fc40, rust-yoke-derive-0.7.4-1.fc40, and 3 more) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 21 Fedora Update System 2024-09-28 12:20:32 UTC
FEDORA-EPEL-2024-ea19be9ef4 (rust-databake-0.1.8-2.el10_0, rust-databake-derive-0.1.8-2.el10_0, and 12 more) has been submitted as an update to Fedora EPEL 10.0.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-ea19be9ef4

Comment 22 Fedora Update System 2024-09-28 12:23:46 UTC
FEDORA-EPEL-2024-ea19be9ef4 (rust-databake-0.1.8-2.el10_0, rust-databake-derive-0.1.8-2.el10_0, and 12 more) has been pushed to the Fedora EPEL 10.0 stable repository.
If problem still persists, please make note of it in this bug report.