Bug 2311966
| Summary: | Review Request: rust-krun-sys - Rust bindings for libkrun | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://crates.io/crates/krun-sys | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-09-13 18:53:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2311969 | ||
|
Description
Davide Cavalca
2024-09-12 16:28:28 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=123305550 $ cat rust2rpm.toml [requires] build = ["libkrun-devel"] lib = ["libkrun-devel"] Copr build: https://copr.fedorainfracloud.org/coprs/build/8015029 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2311966-rust-krun-sys/fedora-rawhide-x86_64/08015029-rust-krun-sys/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Bindings are already unconditionally regenerated with bindgen at build-time, which is great. Package looks good to me! === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-krun-sys FEDORA-2024-544c3b9c95 (rust-krun-sys-1.9.1-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-544c3b9c95 FEDORA-2024-544c3b9c95 (rust-krun-sys-1.9.1-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-d4f53c736e (rust-bpaf-0.9.13-1.fc41, rust-bpaf_derive-0.5.13-1.fc41, and 2 more) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-d4f53c736e FEDORA-2024-395f7c5247 (rust-bpaf-0.9.13-1.fc40, rust-bpaf_derive-0.5.13-1.fc40, and 2 more) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-395f7c5247 FEDORA-2024-2216623b67 (rust-bpaf-0.9.13-1.fc39, rust-bpaf_derive-0.5.13-1.fc39, and 2 more) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-2216623b67 FEDORA-2024-d4f53c736e (rust-bpaf-0.9.13-1.fc41, rust-bpaf_derive-0.5.13-1.fc41, and 2 more) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-2216623b67 (rust-bpaf-0.9.13-1.fc39, rust-bpaf_derive-0.5.13-1.fc39, and 2 more) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-395f7c5247 (rust-bpaf-0.9.13-1.fc40, rust-bpaf_derive-0.5.13-1.fc40, and 2 more) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |