Bug 2311968

Summary: Review Request: rust-bpaf - Simple Command Line Argument Parser with parser combinators
Product: [Fedora] Fedora Reporter: Davide Cavalca <davide>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Keywords: AutomationTriaged, Reopened
Target Release: ---Flags: ngompa13: fedora-review+
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/bpaf
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-09-14 14:56:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2311967    
Bug Blocks: 2311969    

Description Davide Cavalca 2024-09-12 16:51:34 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-bpaf/rust-bpaf.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-bpaf/rust-bpaf-0.9.13-1.fc42.src.rpm

Description:
A simple Command Line Argument Parser with parser combinators.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-09-12 16:52:00 UTC
$ cat rust2rpm.toml 
[package]
cargo-toml-patch-comments = [
  "Drop examples as they fail to build",
  "Include license files",
]
extra-sources = [
  { "number" = 2, "file" = "https://github.com/pacak/bpaf/raw/dd8e2772b7f6e17ffbcdcfdda1e55776615e25e0/LICENSE-APACHE", "comments" = ["https://github.com/pacak/bpaf/pull/388"] },
  { "number" = 3, "file" = "https://github.com/pacak/bpaf/raw/dd8e2772b7f6e17ffbcdcfdda1e55776615e25e0/LICENSE-MIT", "comments" = ["https://github.com/pacak/bpaf/pull/388"] },
]

[scripts]
prep.pre = [
  "cp -p %SOURCE2 %SOURCE3 ."
]

[tests]
comments = ["Tests fail to build"]
run = ["none"]

Comment 2 Fedora Review Service 2024-09-12 17:01:08 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8015055
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2311968-rust-bpaf/fedora-rawhide-x86_64/08015055-rust-bpaf/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Update System 2024-09-13 19:00:52 UTC
FEDORA-2024-3566b4bffe (rust-bpaf_derive-0.5.13-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-3566b4bffe

Comment 4 Fedora Update System 2024-09-13 19:05:46 UTC
FEDORA-2024-3566b4bffe (rust-bpaf_derive-0.5.13-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 5 Davide Cavalca 2024-09-14 03:08:27 UTC
Reopening as I attached the update to the wrong bug.

Comment 6 Neal Gompa 2024-09-14 10:02:33 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 7 Fedora Admin user for bugzilla script actions 2024-09-14 14:38:04 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-bpaf

Comment 8 Fedora Update System 2024-09-14 14:52:21 UTC
FEDORA-2024-6bdac91d03 (rust-bpaf-0.9.13-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6bdac91d03

Comment 9 Fedora Update System 2024-09-14 14:56:20 UTC
FEDORA-2024-6bdac91d03 (rust-bpaf-0.9.13-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2024-09-15 16:14:55 UTC
FEDORA-2024-d4f53c736e (rust-bpaf-0.9.13-1.fc41, rust-bpaf_derive-0.5.13-1.fc41, and 2 more) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-d4f53c736e

Comment 11 Fedora Update System 2024-09-15 20:14:22 UTC
FEDORA-2024-395f7c5247 (rust-bpaf-0.9.13-1.fc40, rust-bpaf_derive-0.5.13-1.fc40, and 2 more) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-395f7c5247

Comment 12 Fedora Update System 2024-09-15 21:01:38 UTC
FEDORA-2024-2216623b67 (rust-bpaf-0.9.13-1.fc39, rust-bpaf_derive-0.5.13-1.fc39, and 2 more) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-2216623b67

Comment 13 Fedora Update System 2024-09-16 00:15:41 UTC
FEDORA-2024-d4f53c736e (rust-bpaf-0.9.13-1.fc41, rust-bpaf_derive-0.5.13-1.fc41, and 2 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2024-09-16 01:41:19 UTC
FEDORA-2024-2216623b67 (rust-bpaf-0.9.13-1.fc39, rust-bpaf_derive-0.5.13-1.fc39, and 2 more) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2024-09-16 01:47:12 UTC
FEDORA-2024-395f7c5247 (rust-bpaf-0.9.13-1.fc40, rust-bpaf_derive-0.5.13-1.fc40, and 2 more) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.