Bug 2312217
| Summary: | Review Request: olive - A free non-linear video editor | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dominik 'Rathann' Mierzejewski <dominik> | ||||
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | mgansser, mtasaka, package-review, sergio | ||||
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://www.olivevideoeditor.org | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2024-12-30 02:11:53 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2218117 | ||||||
| Attachments: |
|
||||||
|
Description
Dominik 'Rathann' Mierzejewski
2024-09-13 14:58:27 UTC
Created attachment 2054628 [details]
proposal patch with ffmpeg 7
Proposal patch for olive with ffmpeg 7.
Looks like this seems to "work for me".
If you can verify my proposal patch and update your srpm, I can review this. ping? Thanks for the reminder, I'll try to tackle this in the next few days. Spec URL: https://rathann.fedorapeople.org/review/olive/olive.spec SRPM URL: https://rathann.fedorapeople.org/review/olive/olive-0.2.0%5e20240825git617ff87-2.fc42.src.rpm * Sat Dec 21 2024 Dominik Mierzejewski <dominik> - 0.2.0^20240825git617ff87-2 - Apply patch to fix build with FFmpeg 7.x (Mamoru Tasaka) Correct SRPM URL: Spec URL: https://rathann.fedorapeople.org/review/olive/olive.spec SRPM URL: https://rathann.fedorapeople.org/review/olive/olive-0.2.0^5e20240825git617ff87-2.fc42.src.rpm * Sat Dec 21 2024 Dominik Mierzejewski <dominik> - 0.2.0^20240825git617ff87-2 - Apply patch to fix build with FFmpeg 7.x (Mamoru Tasaka) Or actually the first one was correct. Sorry for the confusion. There seems to be some problem with the following file. SRPM URL: https://rathann.fedorapeople.org/review/olive/olive-0.2.0%5E5e20240825git617ff87-2.fc42.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/8439940 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2312217-olive/fedora-rawhide-x86_64/08439940-olive/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Assigning. Okay. MUST / SHOULD fix * BuildRequires: gcc-c++ is needed: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please fix above (when importing) Other things are okay * spec file clean * license tag actually correct (~3000 files) * build cleanly on f42 / f41 * installation works * binary launches normally Approving. ============================================= This package (olive) is APPROVED by mtasaka ============================================= The Pagure repository was created at https://src.fedoraproject.org/rpms/olive (In reply to Mamoru TASAKA from comment #11) > * BuildRequires: gcc-c++ is needed: > https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ > > Please fix above (when importing) > Other things are okay Thanks for the review (especially for the FFmpeg7 patch). BR: gcc-c++ added and builds done. FEDORA-2024-10d6bb0591 (olive-0.2.0^20240825git617ff87-3.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-10d6bb0591 FEDORA-2024-3096e89b7d (olive-0.2.0^20240825git617ff87-3.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-3096e89b7d FEDORA-2024-10d6bb0591 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-10d6bb0591 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-10d6bb0591 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-3096e89b7d has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-3096e89b7d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-3096e89b7d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-10d6bb0591 (olive-0.2.0^20240825git617ff87-3.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-3096e89b7d (olive-0.2.0^20240825git617ff87-3.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |