Bug 231249

Summary:	gnome-mount handling of nautilus-properties seriously broken
Product:	[Fedora] Fedora	Reporter:	Michal Jaegermann <michal>
Component:	gnome-mount	Assignee:	David Zeuthen <davidz>
Status:	CLOSED CANTFIX	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mclasen, steven-fcbugz, triage
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:	bzcl34nup
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-04-05 18:44:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michal Jaegermann 2007-03-06 23:18:44 UTC

Description of problem:

Here is a scenario.

With gnome-mount-nautilus-properties installed under
'Properties->Volume->Settings' for that volume icon a user now
can specify, among other things, a mount point.  It is perfectly
natural to type there something like "/media/my_mount" or
maybe try to have that mount point in some other place.   There is
no validation and such string is accepted.  On the next attempt
to mount a big surprise!  It turns out that there are various
"bad" characters for that string and gnome-mount simply bails
out.  No icon for a volume hence no way to change the offending
string; at least not by the same means it was set (yes, I know
that one can use gconftool-2 or gconf-editor but this is not
obvious to somebody who just typed the above).  There is also
a "broken" auto-mounting and time to panic.  Not good at all...

Likely the simplest way out would be to throw an alert with
complaints but, if a proposed string cannot be used, just to
ignore it and mount a volume the same way as before.  Automatically
opening a needed location in 'Properties' where a name needs to
be retyped would be of a great help.  Maybe asking for an
input validation is also not too much?

At least erasing everything in "Mount Point:" field works as expected.

Version-Release number of selected component (if applicable):
gnome-mount-0.5-3.fc7

How reproducible:
always

Comment 1 Steven Op de beeck 2007-04-13 08:01:06 UTC

Michal,

Normally, even when it fails to mount the device as you describe, it still shows
up in computer:///. Going into properties there allows you to correct the mount
point.
However, I agree it should do some input checking beforehand. And it should be
made clear that you can only change the mountpoint in a very limited way (within
/media), or allow to change it more extensively. I too made that mistake the
first time.

Comment 2 Michal Jaegermann 2007-04-14 17:57:20 UTC

> And it should be made clear that you can only change the mountpoint
> in a very limited way (within /media).

That was not even the main trouble.  Limiting new mount points to /media
does not help.  If some characters are deemed "bad", even if they were
accepted before, gnome_mount will simply barf on you.  Limiting mount
point to something withing /media does not help.

Like I said, at a minimum it should complain and ignore instead of bailing out.

Comment 3 Steven Op de beeck 2007-04-16 10:17:22 UTC

Sure, I completely agree. That's why that sentence started with _and_ :)

Comment 4 David Zeuthen 2007-04-16 16:01:31 UTC

And, hey, upstream (= me) agree it's broken too! I just haven't had time to make
this nicer but it's definitely on my list of things to do... if you want to work
on this, I'd be happy to give advice on what needs changing. Thanks!

Comment 5 Matthias Clasen 2007-04-17 19:06:47 UTC

This should probably be tracked upstream. David, whats the right bugzilla for
gnome-mount ?

Comment 6 David Zeuthen 2007-04-17 21:59:10 UTC

gnome-mount is tracked in the GNOME bugzilla.

Comment 7 Bug Zapper 2008-04-03 23:38:34 UTC

Based on the date this bug was created, it appears to have been reported
against rawhide during the development of a Fedora release that is no
longer maintained. In order to refocus our efforts as a project we are
flagging all of the open bugs for releases which are no longer
maintained. If this bug remains in NEEDINFO thirty (30) days from now,
we will automatically close it.

If you can reproduce this bug in a maintained Fedora version (7, 8, or
rawhide), please change this bug to the respective version and change
the status to ASSIGNED. (If you're unable to change the bug's version
or status, add a comment to the bug and someone will change it for you.)

Thanks for your help, and we apologize again that we haven't handled
these issues to this point.

The process we're following is outlined here:
http://fedoraproject.org/wiki/BugZappers/F9CleanUp

We will be following the process here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping to ensure this
doesn't happen again.

Comment 8 Michal Jaegermann 2008-04-05 18:44:36 UTC

Interfaces drastically changed and the report is not relevant
any longer. There is simply no such options anymore.