Bug 2312867

Summary: Review Request: python-django-q2 - A multiprocessing distributed task queue for Django
Product: [Fedora] Fedora Reporter: Michel Lind <michel>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://django-q2.readthedocs.org
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-09-17 21:50:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2245467    

Description Michel Lind 2024-09-17 15:26:33 UTC
Spec URL: https://salimma.fedorapeople.org/python-django-q2.spec
SRPM URL: https://salimma.fedorapeople.org/python-django-q2-1.7.2-1.fc40.src.rpm

Description:
Django Q2 is a native Django task queue, scheduler and worker application using
Python multiprocessing.

Fedora Account System Username: salimma

Comment 1 Fedora Review Service 2024-09-17 15:32:06 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8028005
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2312867-python-django-q2/fedora-rawhide-x86_64/08028005-python-django-q2/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Michel Lind 2024-09-17 15:34:16 UTC
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=123548100

Note: per https://django-q2.readthedocs.io/en/master/install.html#migrate-from-django-q-to-django-q2 this is a drop-in replacement for django-q but

- a DB migration is required
- per the Python guidelines we can't provide the machine-readable provides for the old package - python3dist(django-q) and python3.Ydist(django-q) - so we probably should not provide python3-django-q either
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Machine-readable-provides

But it seems compatible enough to still mark this as Obsolete-ing the previous python3-django-q rather than just marking it as conflicting (the module name is still django_q)

Comment 3 Michel Lind 2024-09-17 15:51:06 UTC
Fixed scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=123548862

Comment 4 Neal Gompa 2024-09-17 19:31:22 UTC
Review notes:

* Package follows Fedora packaging guidelines
* Package follows Fedora Python packaging guidelines
* Package licensing is correct and license files are correctly installed
* Package builds and installs
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 5 Fedora Admin user for bugzilla script actions 2024-09-17 21:16:47 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-django-q2

Comment 6 Fedora Update System 2024-09-17 21:47:54 UTC
FEDORA-2024-bd9f3e9d68 (python-django-q2-1.7.2-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-bd9f3e9d68

Comment 7 Fedora Update System 2024-09-17 21:50:25 UTC
FEDORA-2024-bd9f3e9d68 (python-django-q2-1.7.2-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.