Bug 2313237

$ cat rust2rpm.toml 
[tests]
run = ["none"]
comments = ["Tests fail to build due to missing artifacts"]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8030619
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2313237-rust-x509-parser/fedora-rawhide-x86_64/08030619-rust-x509-parser/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

*** Bug 2332216 has been marked as a duplicate of this bug. ***

Spec URL: https://dcavalca.fedorapeople.org/review/rust-x509-parser/rust-x509-parser.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-x509-parser/rust-x509-parser-0.16.0-1.fc42.src.rpm

Changelog:
- regenerate with rust2rpm 27

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8481939
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2313237-rust-x509-parser/fedora-rawhide-x86_64/08481939-rust-x509-parser/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Missing rust-der-parser, but it seems that's been pushed to F42: https://bugzilla.redhat.com/show_bug.cgi?id=2312638#c6

[fedora-review-service-build]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8491609
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2313237-rust-x509-parser/fedora-rawhide-x86_64/08491609-rust-x509-parser/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package looks almost good to me.

The package.include setting in Cargo.toml is very strange though:
I'm quite sure that `.gitignore` and `.travis.yml` should just be dropped from that list.
`Cargo.toml` is always included in published crates, so there's no need to list it explicitly.

And I'm a bit confused why the tests fail with missing files, when there's a lot of stuff in "assets" that *does* look like test data.
Are the paths in test code just wrong?

Can the "assets" directory be excluded from packaged files, if it's indeed just test input files?

Polite ping -- is there any update here? This dependency is preventing me from packaging one of my projects.

> And I'm a bit confused why the tests fail with missing files, when there's a lot of stuff in "assets" that *does* look like test data.
> Are the paths in test code just wrong?

It looks like some of the tests are looking for certs that aren't included in the packaged crate :(

Spec URL: https://dcavalca.fedorapeople.org/review/rust-x509-parser/rust-x509-parser.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-x509-parser/rust-x509-parser-0.16.0-1.fc42.src.rpm

Changelog:
- exclude unnecessary files

$ cat rust2rpm.toml 
[package]
cargo-toml-patch-comments = ["Drop unnecessary files"]

[tests]
run = ["none"]
comments = ["Tests fail to build due to missing artifacts"]

Created attachment 2066702 [details]
The .spec file difference from Copr build 8491609 to 8546983

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8546983
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2313237-rust-x509-parser/fedora-rawhide-x86_64/08546983-rust-x509-parser/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Thanks for checking, looks good to me!

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass (disabled with justification)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-x509-parser

FEDORA-2025-70013f4e40 (rust-x509-parser-0.16.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-70013f4e40

FEDORA-2025-70013f4e40 (rust-x509-parser-0.16.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.