Bug 2313904

Summary: /usr/bin/qemu-ga: unrecognized option '--blacklist='
Product: [Fedora] Fedora Reporter: Steve <y9t7sypezp>
Component: qemuAssignee: Fedora Virtualization Maintainers <virt-maint>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: berrange, cfergeau, crobinso, mcascell, pbonzini, philmd, rjones, suraj.ghimire7, virt-maint
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-09-21 08:02:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Steve 2024-09-21 02:13:14 UTC 
Description of problem:

$ systemctl status qemu-guest-agent.service
× qemu-guest-agent.service - QEMU Guest Agent
     Loaded: loaded (/usr/lib/systemd/system/qemu-guest-agent.service; enabled; preset: enabled)
    Drop-In: /usr/lib/systemd/system/service.d
             └─10-timeout-abort.conf
     Active: failed (Result: exit-code) since Sat 2024-09-21 01:43:06 UTC; 24min ago
   Duration: 10ms
 Invocation: fffbcf43a4724a8dbb047d18b09bd04d
    Process: 976 ExecStart=/usr/bin/qemu-ga --method=virtio-serial --path=/dev/virtio-ports/org.qemu.guest_agent.0 --blacklist=${BLACKLIST_RPC} ->
   Main PID: 976 (code=exited, status=1/FAILURE)

Sep 21 01:43:06 fedora-workstation-2 systemd[1]: qemu-guest-agent.service: Scheduled restart job, restart counter is at 5.
Sep 21 01:43:06 fedora-workstation-2 systemd[1]: qemu-guest-agent.service: Start request repeated too quickly.
Sep 21 01:43:06 fedora-workstation-2 systemd[1]: qemu-guest-agent.service: Failed with result 'exit-code'.
Sep 21 01:43:06 fedora-workstation-2 systemd[1]: Failed to start qemu-guest-agent.service - QEMU Guest Agent.

Version-Release number of selected component (if applicable):

qemu-guest-agent-9.1.0-1.fc42.x86_64

How reproducible:
Always.

Steps to Reproduce:
1. Boot F42 Workstation in a VM.

Actual results:
Error.

Expected results:
No error.

Additional info:

VM XML configuration per virt-manager:

<channel type="unix">
  <source mode="bind" path="/run/user/1000/libvirt/qemu/run/channel/1-fedora-workstation-2/org.qemu.guest_agent.0"/>
  <target type="virtio" name="org.qemu.guest_agent.0" state="disconnected"/>
  <alias name="channel0"/>
  <address type="virtio-serial" controller="0" bus="0" port="1"/>
</channel>

VM host is F40 Xfce:

qemu-system-x86-core-8.2.6-3.fc40.x86_64
libvirt-daemon-driver-qemu-10.1.0-4.fc40.x86_64
virt-manager-4.1.0-5.fc40.noarch
systemd-255.12-1.fc40.x86_64

kernel 6.10.10-200.fc40.x86_64
Comment 1 Steve 2024-09-21 02:51:36 UTC 
With systemd debugging enabled on the kernel command-line:

$ journalctl --no-hostname -b | egrep -n -C0 'Command line|qemu-ga'

2:Sep 21 02:26:36 kernel: Command line: BOOT_IMAGE=(hd0,gpt2)/vmlinuz-6.12.0-0.rc0.20240918git4a39ac5b7d62.6.fc42.x86_64 root=UUID=287e1461-51fc-4b16-86e6-60c121cfbc87 ro systemd.log_level=debug
--
45191:Sep 21 02:26:40 systemd[1]: qemu-guest-agent.service: Will spawn child (service_enter_start): /usr/bin/qemu-ga
--
45196:Sep 21 02:26:40 systemd[1]: qemu-guest-agent.service: About to execute: /usr/bin/qemu-ga --method=virtio-serial --path=/dev/virtio-ports/org.qemu.guest_agent.0 "--blacklist=\${BLACKLIST_RPC}" "-F\${FSFREEZE_HOOK_PATHNAME}"
--
45199:Sep 21 02:26:40 systemd[1]: qemu-guest-agent.service: Forked /usr/bin/qemu-ga as 816 (via CLONE_INTO_CGROUP)
--
45322:Sep 21 02:26:40 (qemu-ga)[816]: Found cgroup2 on /sys/fs/cgroup/, full unified hierarchy
--
45332:Sep 21 02:26:40 (qemu-ga)[816]: Found cgroup2 on /sys/fs/cgroup/, full unified hierarchy
--
45334:Sep 21 02:26:40 (qemu-ga)[816]: qemu-guest-agent.service: Referenced but unset environment variable evaluates to an empty string: BLACKLIST_RPC
45335:Sep 21 02:26:40 (qemu-ga)[816]: qemu-guest-agent.service: Executing: /usr/bin/qemu-ga --method=virtio-serial --path=/dev/virtio-ports/org.qemu.guest_agent.0 --blacklist= -F/etc/qemu-ga/fsfreeze-hook
--
45366:Sep 21 02:26:40 qemu-ga[816]: /usr/bin/qemu-ga: unrecognized option '--blacklist='
45367:Sep 21 02:26:40 qemu-ga[816]: /usr/bin/qemu-ga: unrecognized option '--blacklist='
45368:Sep 21 02:26:40 qemu-ga[816]: Unknown option, try '/usr/bin/qemu-ga --help' for more information.
--
45817:Sep 21 02:26:40 systemd[1]: Child 816 (qemu-ga) died (code=exited, status=1/FAILURE)
--
46086:Sep 21 02:26:40 qemu-ga[851]: /usr/bin/qemu-ga: unrecognized option '--blacklist='
--
46088:Sep 21 02:26:40 qemu-ga[851]: /usr/bin/qemu-ga: unrecognized option '--blacklist='
46089:Sep 21 02:26:40 qemu-ga[851]: Unknown option, try '/usr/bin/qemu-ga --help' for more information.
--
46482:Sep 21 02:26:40 qemu-ga[856]: /usr/bin/qemu-ga: unrecognized option '--blacklist='
46483:Sep 21 02:26:40 qemu-ga[856]: /usr/bin/qemu-ga: unrecognized option '--blacklist='
46484:Sep 21 02:26:40 qemu-ga[856]: Unknown option, try '/usr/bin/qemu-ga --help' for more information.
--
46501:Sep 21 02:26:40 systemd[1]: qemu-guest-agent.service: Will spawn child (service_enter_start): /usr/bin/qemu-ga
--
46543:Sep 21 02:26:40 (qemu-ga)[851]: Found cgroup2 on /sys/fs/cgroup/, full unified hierarchy
--
46568:Sep 21 02:26:40 (qemu-ga)[851]: Found cgroup2 on /sys/fs/cgroup/, full unified hierarchy
--
46577:Sep 21 02:26:40 (qemu-ga)[851]: qemu-guest-agent.service: Referenced but unset environment variable evaluates to an empty string: BLACKLIST_RPC
--
46579:Sep 21 02:26:40 (qemu-ga)[851]: qemu-guest-agent.service: Executing: /usr/bin/qemu-ga --method=virtio-serial --path=/dev/virtio-ports/org.qemu.guest_agent.0 --blacklist= -F/etc/qemu-ga/fsfreeze-hook
--
46735:Sep 21 02:26:40 systemd[1]: Received SIGCHLD from PID 851 (qemu-ga).
46736:Sep 21 02:26:40 systemd[1]: Child 851 (qemu-ga) died (code=exited, status=1/FAILURE)
--
46872:Sep 21 02:26:40 systemd[1]: qemu-guest-agent.service: Will spawn child (service_enter_start): /usr/bin/qemu-ga
--
46874:Sep 21 02:26:40 systemd[1]: qemu-guest-agent.service: About to execute: /usr/bin/qemu-ga --method=virtio-serial --path=/dev/virtio-ports/org.qemu.guest_agent.0 "--blacklist=\${BLACKLIST_RPC}" "-F\${FSFREEZE_HOOK_PATHNAME}"
--
46888:Sep 21 02:26:40 systemd[1]: qemu-guest-agent.service: Forked /usr/bin/qemu-ga as 856 (via CLONE_INTO_CGROUP)
--
46915:Sep 21 02:26:40 (qemu-ga)[856]: Found cgroup2 on /sys/fs/cgroup/, full unified hierarchy
--
46992:Sep 21 02:26:40 (qemu-ga)[856]: Found cgroup2 on /sys/fs/cgroup/, full unified hierarchy
46993:Sep 21 02:26:40 (qemu-ga)[856]: qemu-guest-agent.service: Referenced but unset environment variable evaluates to an empty string: BLACKLIST_RPC
46994:Sep 21 02:26:40 (qemu-ga)[856]: qemu-guest-agent.service: Executing: /usr/bin/qemu-ga --method=virtio-serial --path=/dev/virtio-ports/org.qemu.guest_agent.0 --blacklist= -F/etc/qemu-ga/fsfreeze-hook
--
47013:Sep 21 02:26:40 systemd[1]: Received SIGCHLD from PID 856 (qemu-ga).
47014:Sep 21 02:26:40 systemd[1]: Child 856 (qemu-ga) died (code=exited, status=1/FAILURE)
--
47058:Sep 21 02:26:40 qemu-ga[864]: /usr/bin/qemu-ga: unrecognized option '--blacklist='
47059:Sep 21 02:26:40 qemu-ga[864]: /usr/bin/qemu-ga: unrecognized option '--blacklist='
47060:Sep 21 02:26:40 qemu-ga[864]: Unknown option, try '/usr/bin/qemu-ga --help' for more information.
--
47105:Sep 21 02:26:40 systemd[1]: qemu-guest-agent.service: Will spawn child (service_enter_start): /usr/bin/qemu-ga
--
47107:Sep 21 02:26:40 systemd[1]: qemu-guest-agent.service: About to execute: /usr/bin/qemu-ga --method=virtio-serial --path=/dev/virtio-ports/org.qemu.guest_agent.0 "--blacklist=\${BLACKLIST_RPC}" "-F\${FSFREEZE_HOOK_PATHNAME}"
--
47218:Sep 21 02:26:40 systemd[1]: qemu-guest-agent.service: Forked /usr/bin/qemu-ga as 864 (via CLONE_INTO_CGROUP)
--
47400:Sep 21 02:26:40 (qemu-ga)[864]: Found cgroup2 on /sys/fs/cgroup/, full unified hierarchy
--
47480:Sep 21 02:26:40 (qemu-ga)[864]: Found cgroup2 on /sys/fs/cgroup/, full unified hierarchy
--
47505:Sep 21 02:26:40 (qemu-ga)[864]: qemu-guest-agent.service: Referenced but unset environment variable evaluates to an empty string: BLACKLIST_RPC
--
47534:Sep 21 02:26:40 (qemu-ga)[864]: qemu-guest-agent.service: Executing: /usr/bin/qemu-ga --method=virtio-serial --path=/dev/virtio-ports/org.qemu.guest_agent.0 --blacklist= -F/etc/qemu-ga/fsfreeze-hook
--
47577:Sep 21 02:26:40 systemd[1]: Received SIGCHLD from PID 864 (qemu-ga).
47578:Sep 21 02:26:40 systemd[1]: Child 864 (qemu-ga) died (code=exited, status=1/FAILURE)
--
47599:Sep 21 02:26:40 qemu-ga[870]: /usr/bin/qemu-ga: unrecognized option '--blacklist='
47600:Sep 21 02:26:40 qemu-ga[870]: /usr/bin/qemu-ga: unrecognized option '--blacklist='
--
47602:Sep 21 02:26:40 qemu-ga[870]: Unknown option, try '/usr/bin/qemu-ga --help' for more information.
--
47643:Sep 21 02:26:40 systemd[1]: qemu-guest-agent.service: Will spawn child (service_enter_start): /usr/bin/qemu-ga
--
47645:Sep 21 02:26:40 systemd[1]: qemu-guest-agent.service: About to execute: /usr/bin/qemu-ga --method=virtio-serial --path=/dev/virtio-ports/org.qemu.guest_agent.0 "--blacklist=\${BLACKLIST_RPC}" "-F\${FSFREEZE_HOOK_PATHNAME}"
--
47654:Sep 21 02:26:40 systemd[1]: qemu-guest-agent.service: Forked /usr/bin/qemu-ga as 870 (via CLONE_INTO_CGROUP)
--
47678:Sep 21 02:26:40 (qemu-ga)[870]: Found cgroup2 on /sys/fs/cgroup/, full unified hierarchy
--
47689:Sep 21 02:26:40 (qemu-ga)[870]: Found cgroup2 on /sys/fs/cgroup/, full unified hierarchy
47690:Sep 21 02:26:40 (qemu-ga)[870]: qemu-guest-agent.service: Referenced but unset environment variable evaluates to an empty string: BLACKLIST_RPC
47691:Sep 21 02:26:40 (qemu-ga)[870]: qemu-guest-agent.service: Executing: /usr/bin/qemu-ga --method=virtio-serial --path=/dev/virtio-ports/org.qemu.guest_agent.0 --blacklist= -F/etc/qemu-ga/fsfreeze-hook
--
47702:Sep 21 02:26:40 systemd[1]: Received SIGCHLD from PID 870 (qemu-ga).
47703:Sep 21 02:26:40 systemd[1]: Child 870 (qemu-ga) died (code=exited, status=1/FAILURE)
Comment 2 Steve 2024-09-21 02:53:54 UTC 
This could be the problem:

$ /usr/bin/qemu-ga --blacklist=
/usr/bin/qemu-ga: unrecognized option '--blacklist='
/usr/bin/qemu-ga: unrecognized option '--blacklist='
Unknown option, try '/usr/bin/qemu-ga --help' for more information.

$ echo $?
1
Comment 3 Steve 2024-09-21 04:42:16 UTC 
See:

qga: Remove deprecated 'blacklist' argument / config key
May 29, 2024
https://gitlab.com/qemu-project/qemu/-/commit/a7a2d636ae4549ef0551134d4bf8e084a14431c4

So qemu-guest-agent.service needs to be updated:

$ fgrep blacklist /usr/lib/systemd/system/qemu-guest-agent.service
  --blacklist=${BLACKLIST_RPC} \
Comment 4 Steve 2024-09-21 04:53:54 UTC 
The build that would fix this failed a required test:

qemu-9.1.0-2.fc42
https://bodhi.fedoraproject.org/updates/FEDORA-2024-45f0cf84b7
Comment 5 Richard W.M. Jones 2024-09-21 08:02:36 UTC 

*** This bug has been marked as a duplicate of bug 2258100 ***
Comment 6 Richard W.M. Jones 2024-09-21 08:03:06 UTC 
I have waive the test, the updated build should appear in Rawhide in a day or two.
Comment 7 Steve 2024-09-21 17:05:29 UTC 
qemu-guest-agent-9.1.0-2.fc42.x86_64 starts as expected:

$ systemctl -q list-units qemu-guest-agent.service
  qemu-guest-agent.service loaded active running QEMU Guest Agent