Bug 2314085
| Summary: | Review Request: rust-rancor - Scalable and efficient error handling without type composition | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Beasley <code> | ||||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||||
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://crates.io/crates/rancor | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2024-10-15 00:17:13 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 2117427, 2117428 | ||||||||
| Bug Blocks: | 2173812 | ||||||||
| Attachments: |
|
||||||||
|
Description
Ben Beasley
2024-09-22 12:24:04 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8053992 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2314085-rust-rancor/fedora-rawhide-x86_64/08053992-rust-rancor/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/8053991 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2314085-rust-rancor/fedora-rawhide-x86_64/08053991-rust-rancor/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Created attachment 2048194 [details]
Updated configuration for rust2rpm
The inconsistent line endings were fixed upstream in https://github.com/rkyv/rancor/commit/b65012a3848487155c072682b151f50599404bae. I can add a link to that commit above "find . -type f | xargs -r -t dos2unix --keepdate" in %prep on import. Reviewed on the basis of pending ptr_meta v0.3 updates and successful build in COPR. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rancor Thank you for the review! https://release-monitoring.org/project/374818/ FEDORA-2024-bb7c9f77a4 (rust-bytecheck0.6-0.6.12-1.fc42, rust-bytecheck-0.8.0-1.fc42, and 13 more) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-bb7c9f77a4 FEDORA-2024-0954b642d0 (rust-bytecheck0.6-0.6.12-1.fc41, rust-bytecheck-0.8.0-1.fc41, and 14 more) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-0954b642d0 FEDORA-2024-bb7c9f77a4 (rust-bytecheck0.6-0.6.12-1.fc42, rust-bytecheck-0.8.0-1.fc42, and 13 more) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-0954b642d0 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0954b642d0` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0954b642d0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-df7046e381 (rust-bytecheck0.6-0.6.12-1.fc40, rust-bytecheck-0.8.0-1.fc40, and 14 more) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-df7046e381 FEDORA-2024-3a741ce360 (rust-bytecheck0.6-0.6.12-1.fc39, rust-bytecheck-0.8.0-1.fc39, and 14 more) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-3a741ce360 FEDORA-2024-3a741ce360 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-3a741ce360` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-3a741ce360 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-df7046e381 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-df7046e381` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-df7046e381 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-0954b642d0 (rust-bytecheck0.6-0.6.12-1.fc41, rust-bytecheck-0.8.0-1.fc41, and 14 more) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-3a741ce360 (rust-bytecheck0.6-0.6.12-1.fc39, rust-bytecheck-0.8.0-1.fc39, and 14 more) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-df7046e381 (rust-bytecheck0.6-0.6.12-1.fc40, rust-bytecheck-0.8.0-1.fc40, and 14 more) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |