Bug 2314132
| Summary: | Review Request: python-durationpy - converts between datetime.timedelta and Go's Duration strings | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jason Montleon <jmontleo> |
| Component: | Package Review | Assignee: | Peter Lemenkov <lemenkov> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | lemenkov, package-review |
| Target Milestone: | --- | Flags: | lemenkov:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://github.com/icholy/durationpy | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-11-15 01:20:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2313897 | ||
| Attachments: | |||
|
Description
Jason Montleon
2024-09-22 22:51:38 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8060892 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2314132-python-durationpy/fedora-rawhide-x86_64/08060892-python-durationpy/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://people.redhat.com/jmontleo/python-durationpy.spec SRPM URL: https://people.redhat.com/jmontleo/python-durationpy-0.9-1.fc40.src.rpm Spec URL: https://people.redhat.com/jmontleo/python-durationpy.spec SRPM URL: https://people.redhat.com/jmontleo/python-durationpy-0.9-1.fc41.src.rpm Created attachment 2055560 [details]
The .spec file difference from Copr build 8060892 to 8209064
Copr build: https://copr.fedorainfracloud.org/coprs/build/8209064 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2314132-python-durationpy/fedora-rawhide-x86_64/08209064-python-durationpy/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] Created attachment 2055565 [details]
The .spec file difference from Copr build 8209064 to 8209107
Copr build: https://copr.fedorainfracloud.org/coprs/build/8209107 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2314132-python-durationpy/fedora-rawhide-x86_64/08209107-python-durationpy/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] Created attachment 2055583 [details]
The .spec file difference from Copr build 8209107 to 8209687
Copr build: https://copr.fedorainfracloud.org/coprs/build/8209687 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2314132-python-durationpy/fedora-rawhide-x86_64/08209687-python-durationpy/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] Created attachment 2055584 [details]
The .spec file difference from Copr build 8209687 to 8209701
Copr build: https://copr.fedorainfracloud.org/coprs/build/8209701 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2314132-python-durationpy/fedora-rawhide-x86_64/08209701-python-durationpy/fedora-review/review.txt Found issues: - python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. `- python3-pytest7 is deprecated, you must not depend on it.` is a false positive, unless I am missing something. The package builds fine on Fedora 41 using python3-pytest-8.3.3-1.fc41.noarch. pytest 7 appears to be the only version available in Fedora 40 and 39, but nothing is tied to this version and nowhere in newer Fedora releases is it relying on the python3-pytest7 package. The rawhide build in Copr also built using python3-pytest-8.3.3-3.fc42.noarch [fedora-review-service-build] Created attachment 2055586 [details]
The .spec file difference from Copr build 8209701 to 8209771
Copr build: https://copr.fedorainfracloud.org/coprs/build/8209771 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2314132-python-durationpy/fedora-rawhide-x86_64/08209771-python-durationpy/fedora-review/review.txt Found issues: - python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. I'll review it The package is very straightforward, the only thing is that you don't need to specify %license file - in this case it was picked up by %pyproject_save_files automatically. Check with ```rpm -qpL python3-durationpy-0.9-1.fc42.noarch.rpm```. Not a blocker you may keep specify %license manually - I found out that sometimes it confuses people when they don't see an explicit %license invocation. I don't see any issues so here is my formal Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package must not depend on deprecated() packages. Note: python3-pytest7 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ ^^^ false positive. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license (MIT). [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package does not contain desktop file (not a GUI application). [-]: The package does not have separate development files. [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: The package is not a rename of another package. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package does not contain systemd file(s). [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 452 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: No Python eggs. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: I did not test if the package functions as described. [ ]: Latest version is packaged (0.9). [x]: Package does not include license text files separate from upstream. [-]: Sources weren't verified with gpgverify (upstream does not publish signatures). [?]: I did not test if the ackage compiles and builds into binary rpms on all supported architectures. The package is noarch anyway. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-durationpy-0.9-1.fc42.noarch.rpm python-durationpy-0.9-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpfpdrl09a')] checks: 32, packages: 2 python-durationpy.src: E: spelling-error ('timedelta', 'Summary(en_US) timedelta -> time delta, time-delta, mealtime') python-durationpy.src: E: spelling-error ('timedelta', '%description -l en_US timedelta -> time delta, time-delta, mealtime') python3-durationpy.noarch: E: spelling-error ('timedelta', 'Summary(en_US) timedelta -> time delta, time-delta, mealtime') python3-durationpy.noarch: E: spelling-error ('timedelta', '%description -l en_US timedelta -> time delta, time-delta, mealtime') 2 packages and 0 specfiles checked; 4 errors, 0 warnings, 11 filtered, 4 badness; has taken 0.5 s ^^^ false positives Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-durationpy.noarch: E: spelling-error ('timedelta', 'Summary(en_US) timedelta -> time delta, time-delta, mealtime') python3-durationpy.noarch: E: spelling-error ('timedelta', '%description -l en_US timedelta -> time delta, time-delta, mealtime') 1 packages and 0 specfiles checked; 2 errors, 0 warnings, 5 filtered, 2 badness; has taken 0.1 s Source checksums ---------------- https://github.com/icholy/durationpy/archive/refs/tags/0.9.tar.gz : CHECKSUM(SHA256) this package : 0f932886b257a20c79a1fcebdcd115492b3bc07707fee8a939cf1b46e8674542 CHECKSUM(SHA256) upstream package : 0f932886b257a20c79a1fcebdcd115492b3bc07707fee8a939cf1b46e8674542 Requires -------- python3-durationpy (rpmlib, GLIBC filtered): python(abi) Provides -------- python3-durationpy: python-durationpy python3-durationpy python3.13-durationpy python3.13dist(durationpy) python3dist(durationpy) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2314132 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Ocaml, Perl, C/C++, Haskell, Java, SugarActivity, R, PHP, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH This package is ================ === APPROVED === ================ The Pagure repository was created at https://src.fedoraproject.org/rpms/python-durationpy FEDORA-2024-a4fb767271 (python-durationpy-0.9-1.fc41 and python-kubernetes-31.0.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-a4fb767271 FEDORA-2024-a4fb767271 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-a4fb767271` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-a4fb767271 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-a4fb767271 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-a4fb767271` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-a4fb767271 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-a4fb767271 (python-durationpy-0.9-2.fc41 and python-kubernetes-31.0.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |